Re: [f2fs-dev] [PATCH] f2fs: compress: don't redirty sparse cluster during {, de}compress

2024-08-15 Thread Chao Yu
On 2024/8/13 14:11, Yeongjin Gil wrote: In f2fs_do_write_data_page, when the data block is NULL_ADDR, it skips writepage considering that it has been already truncated. This results in an infinite loop as the PAGECACHE_TAG_TOWRITE tag is not cleared during the writeback process for a compressed f

Re: [f2fs-dev] [PATCH] f2fs: compress: don't redirty sparse cluster during {, de}compress

2024-08-15 Thread Yeongjin Gil
Thanks for your review. I will send patch v2. >On 2024/8/13 14:11, Yeongjin Gil wrote: >> In f2fs_do_write_data_page, when the data block is NULL_ADDR, it skips >> writepage considering that it has been already truncated. >> This results in an infinite loop as the PAGECACHE_TAG_TOWRITE tag is >> n

Re: [f2fs-dev] [PATCH] f2fs: fix unreleased reader lock on return

2024-08-15 Thread Jaegeuk Kim
On 08/15, Diogo Jahchan Koike wrote: > No problem whatsoever. Thanks. I removed the original patch from -next. Chao, please post a fixed version. > > Thanks, > > Em qua., 14 de ago. de 2024, 21:51, Chao Yu escreveu: > > > On 2024/8/15 5:16, Diogo Jahchan Koike wrote: > > > fix reader lock unr

Re: [f2fs-dev] (2) [PATCH] f2fs: avoid unused block when dio write in LFS mode

2024-08-15 Thread Daejun Park
Hi Chao Yu, >  >- Original Message - >Sender : Chao Yu >Date : 2024-08-14 18:50 (GMT+9) >Title : Re: [PATCH] f2fs: avoid unused block when dio write in LFS mode >  >On 2024/8/1 15:47, Daejun Park wrote: >> This patch addresses the problem that when using LFS mode, unused blocks >>

[f2fs-dev] [PATCH v2 4/4] f2fs: atomic: fix to forbid dio in atomic_file

2024-08-15 Thread Chao Yu
atomic write can only be used via buffered IO, let's fail direct IO on atomic_file and return -EOPNOTSUPP. Signed-off-by: Chao Yu --- v2: - fix error path handling. fs/f2fs/file.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/fs/f2fs/f

Re: [f2fs-dev] (2) [PATCH] f2fs-tools: add write hint support

2024-08-15 Thread Daejun Park
Hi Chao Yu, >  >- Original Message - >Sender : Chao Yu >Date : 2024-08-15 12:33 (GMT+9) >Title : Re: [PATCH] f2fs-tools: add write hint support >  >On 2024/8/9 15:32, Daejun Park wrote: >> This patch enables support for write hints by segment type. > >What about adding an option t

Re: [f2fs-dev] (2) [PATCH] f2fs: avoid unused block when dio write in LFS mode

2024-08-15 Thread Chao Yu
On 2024/8/16 8:17, Daejun Park wrote: Hi Chao Yu, - Original Message - Sender : Chao Yu Date : 2024-08-14 18:50 (GMT+9) Title : Re: [PATCH] f2fs: avoid unused block when dio write in LFS mode On 2024/8/1 15:47, Daejun Park wrote: This patch addresses the problem that when

Re: [f2fs-dev] [PATCH] f2fs: check discard support for conventional zones

2024-08-15 Thread Damien Le Moal
On 8/16/24 11:23, Shin'ichiro Kawasaki wrote: > As the helper function f2fs_bdev_support_discard() shows, f2fs checks if > the target block devices support discard by calling > bdev_max_discard_sectors() and bdev_is_zoned(). This check works good s/good/well > for most cases, but it does not work

[f2fs-dev] [PATCH] f2fs: check discard support for conventional zones

2024-08-15 Thread Shin'ichiro Kawasaki via Linux-f2fs-devel
As the helper function f2fs_bdev_support_discard() shows, f2fs checks if the target block devices support discard by calling bdev_max_discard_sectors() and bdev_is_zoned(). This check works good for most cases, but it does not work for conventional zones on zoned block devices. F2fs assumes that zo

Re: [f2fs-dev] (2) (2) [PATCH] f2fs: avoid unused block when dio write in LFS mode

2024-08-15 Thread Daejun Park
Hi Chao Yu, >  >- Original Message - >Sender : Chao Yu >Date : 2024-08-16 10:56 (GMT+9) >Title : Re: (2) [PATCH] f2fs: avoid unused block when dio write in LFS mode >  >On 2024/8/16 8:17, Daejun Park wrote: >> Hi Chao Yu, >>>  >>> - Original Message - >>> Sender :

[f2fs-dev] [PATCH v2] f2fs: check discard support for conventional zones

2024-08-15 Thread Shin'ichiro Kawasaki via Linux-f2fs-devel
As the helper function f2fs_bdev_support_discard() shows, f2fs checks if the target block devices support discard by calling bdev_max_discard_sectors() and bdev_is_zoned(). This check works well for most cases, but it does not work for conventional zones on zoned block devices. F2fs assumes that zo

Re: [f2fs-dev] [PATCH] f2fs: check discard support for conventional zones

2024-08-15 Thread Shinichiro Kawasaki via Linux-f2fs-devel
Thank you for the comments. Will reflect them and post v2. ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: check discard support for conventional zones

2024-08-15 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel