Re: [f2fs-dev] [PATCH 1/2] f2fs: fix missing discard candidates in fstrim

2025-01-03 Thread Chunhai Guo via Linux-f2fs-devel
在 1/3/2025 11:26 AM, Chao Yu 写道: > On 2025/1/2 18:13, Chunhai Guo wrote: >> fstrim may miss candidates that need to be discarded in fstrim, as shown in >> the examples below. >> The root cause is that when cpc->reason is set with CP_DISCARD, >> add_discard_addrs() expects that ckpt_valid_map and cu

Re: [f2fs-dev] [PATCH v2] f2fs: Introduce linear search for dentries

2025-01-03 Thread Christoph Hellwig
On Mon, Dec 23, 2024 at 04:57:35PM +, Jaegeuk Kim wrote: > > That means you have really bad worst case behavior for negative lookups. > > I don' think this is in any way a good idea. > > No surprise. Please check: > https://lore.kernel.org/lkml/z1mzu4eg6cpur...@google.com/ Well, I think Linus