Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in new_curseg (2)

2025-02-11 Thread syzbot
syzbot has bisected this issue to: commit 84b5bb8bf0f6a78c232a20c2eecdbb8112ac2703 Author: Qi Han Date: Fri Oct 25 09:18:23 2024 + f2fs: modify f2fs_is_checkpoint_ready logic to allow more data to be written with the CP disable bisection log: https://syzkaller.appspot.com/x/bisect.t

Re: [f2fs-dev] [PATCH v2] f2fs: add ioctl to get IO priority hint

2025-02-11 Thread Jaegeuk Kim via Linux-f2fs-devel
This patch adds an ioctl to give a per-file priority hint to attach REQ_PRIO. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c| 6 ++ fs/f2fs/f2fs.h| 1 + fs/f2fs/file.c| 20 include/uapi/linux/f2fs.h | 7 +++ 4 files changed, 34 i

Re: [f2fs-dev] [PATCH 1/2] f2fs: don't retry IO for corrupted data scenario

2025-02-11 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 12 Feb 2025 09:54:12 +0800 you wrote: > F2FS-fs (dm-105): inconsistent node block, nid:430, > node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] > F2FS-fs (dm-105):

[f2fs-dev] [PATCH 1/2] f2fs: keep POSIX_FADV_NOREUSE ranges

2025-02-11 Thread Jaegeuk Kim via Linux-f2fs-devel
This patch records POSIX_FADV_NOREUSE ranges for users to reclaim the caches instantly off from LRU. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c | 3 +++ fs/f2fs/f2fs.h | 12 +- fs/f2fs/file.c | 60 - fs/f2fs/inode.c | 14

[f2fs-dev] [PATCH 0/2 v9] reclaim file-backed pages given POSIX_FADV_NOREUSE

2025-02-11 Thread Jaegeuk Kim via Linux-f2fs-devel
This patch series does not add new API, but implements POSIX_FADV_NOREUSE where it keeps the page ranges in the f2fs superblock and add a way for users to reclaim the pages manually. Change log from v8: - remove new APIs, but use fadvise(POSIX_FADV_NOREUSE) Jaegeuk Kim (2): f2fs: keep POSIX_FA

[f2fs-dev] Patchwork summary for: f2fs

2025-02-11 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: [f2fs-dev,1/2] f2fs: don't retry IO for corrupted data scenario Submitter: Chao Yu Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=932946 Lore link: https://l

[f2fs-dev] [PATCH 2/2] f2fs: add a sysfs entry to reclaim POSIX_FADV_NOREUSE pages

2025-02-11 Thread Jaegeuk Kim via Linux-f2fs-devel
1. fadvise(fd1, POSIX_FADV_NOREUSE, {0,3}); 2. fadvise(fd2, POSIX_FADV_NOREUSE, {1,2}); 3. fadvise(fd3, POSIX_FADV_NOREUSE, {3,1}); 4. echo 1024 > /sys/fs/f2fs/tuning/reclaim_caches_kb This gives a way to reclaim file-backed pages by iterating all f2fs mounts until reclaiming 1MB page cache ranges

Re: [f2fs-dev] [PATCH v3 RESEND] f2fs: add check for deleted inode

2025-02-11 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 11 Feb 2025 15:17:25 +0800 you wrote: > From: Leo Stone > > The syzbot reproducer mounts a f2fs image, then tries to unlink an > existing file. However, the unlinked file already has a link count of 0 > when it is

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid panic once fallocation fails for pinfile

2025-02-11 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 11 Feb 2025 14:36:57 +0800 you wrote: > syzbot reports a f2fs bug as below: > > [ cut here ] > kernel BUG at fs/f2fs/segment.c:2746! > CPU: 0 UID: 0 PID: 5323 Comm: syz.0.0 Not tainted > 6.1

[f2fs-dev] Patchwork summary for: f2fs

2025-02-11 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev,v3,RESEND] f2fs: add check for deleted inode Submitter: Chao Yu Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=932638 Lore

Re: [f2fs-dev] [PATCH v2] f2fs: add ioctl to get IO priority hint

2025-02-11 Thread Chao Yu via Linux-f2fs-devel
On 2/12/25 05:01, Jaegeuk Kim via Linux-f2fs-devel wrote: > This patch adds an ioctl to give a per-file priority hint to attach > REQ_PRIO. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-dev

Re: [f2fs-dev] [PATCH v3 RESEND] f2fs: add check for deleted inode

2025-02-11 Thread Chao Yu via Linux-f2fs-devel
On 2/12/25 11:24, Jaegeuk Kim wrote: > On 02/11, Chao Yu wrote: >> From: Leo Stone >> >> The syzbot reproducer mounts a f2fs image, then tries to unlink an >> existing file. However, the unlinked file already has a link count of 0 >> when it is read for the first time in do_read_inode(). >> >> Add

Re: [f2fs-dev] [PATCH 0/2 v6] add ioctl/sysfs to donate file-backed pages

2025-02-11 Thread Jaegeuk Kim via Linux-f2fs-devel
On 02/10, Jaegeuk Kim wrote: > On 02/10, Matthew Wilcox wrote: > > On Mon, Feb 10, 2025 at 05:00:47PM +, Jaegeuk Kim wrote: > > > On 02/04, Jaegeuk Kim wrote: > > > > On 01/17, Jaegeuk Kim wrote: > > > > > On 01/17, Matthew Wilcox wrote: > > > > > > On Fri, Jan 17, 2025 at 06:48:55PM +, Jae

[f2fs-dev] [PATCH 1/2] f2fs: don't retry IO for corrupted data scenario

2025-02-11 Thread Chao Yu via Linux-f2fs-devel
F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:212

[f2fs-dev] [PATCH 2/2] f2fs: add dump_stack() in f2fs_handle_critical_error()

2025-02-11 Thread Chao Yu via Linux-f2fs-devel
To show call stack, so that we can see who causes critical error, note that it won't call dump_stack() for shutdown path. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 24ded06c8980..1af78b75906b 100644 ---

Re: [f2fs-dev] [PATCH v3 RESEND] f2fs: add check for deleted inode

2025-02-11 Thread Jaegeuk Kim via Linux-f2fs-devel
On 02/11, Chao Yu wrote: > From: Leo Stone > > The syzbot reproducer mounts a f2fs image, then tries to unlink an > existing file. However, the unlinked file already has a link count of 0 > when it is read for the first time in do_read_inode(). > > Add a check to sanity_check_inode() for i_nlink

[f2fs-dev] [PATCH v4] f2fs: add check for deleted inode

2025-02-11 Thread Chao Yu via Linux-f2fs-devel
From: Leo Stone The syzbot reproducer mounts a f2fs image, then tries to unlink an existing file. However, the unlinked file already has a link count of 0 when it is read for the first time in do_read_inode(). Add a check to sanity_check_inode() for i_nlink == 0. [Chao Yu: rebase the code and f

[f2fs-dev] [PATCH] f2fs: fix to avoid accessing uninitialized curseg

2025-02-11 Thread Chao Yu via Linux-f2fs-devel
syzbot reports a f2fs bug as below: F2FS-fs (loop3): Stopped filesystem due to reason: 7 kworker/u8:7: attempt to access beyond end of device BUG: unable to handle page fault for address: ed1604ea3dfa RIP: 0010:get_ckpt_valid_blocks fs/f2fs/segment.h:361 [inline] RIP: 0010:has_curseg_enough_sp