Re: [f2fs-dev] [PATCH v3] f2fs: fix missing discard candidates in fstrim

2025-03-15 Thread Jaegeuk Kim via Linux-f2fs-devel
On 03/12, Chunhai Guo wrote: > fstrim may miss candidates that need to be discarded, as shown in the > examples below. > > The root cause is that when cpc->reason is set with CP_DISCARD, > add_discard_addrs() expects that ckpt_valid_map and cur_valid_map have > been synced by seg_info_to_raw_sit()

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid atomicity corruption of atomic file

2025-03-15 Thread Daeho Jeong
On Fri, Mar 14, 2025 at 5:28 AM Yeongjin Gil wrote: > > In the case of the following call stack for an atomic file, > FI_DIRTY_INODE is set, but FI_ATOMIC_DIRTIED is not subsequently set. > > f2fs_file_write_iter > f2fs_map_blocks > f2fs_reserve_new_blocks > inc_valid_block_count >

Re: [f2fs-dev] [PATCH 1/4] common/config: remove redundant export of F2FS_IO_PROG

2025-03-15 Thread David Disseldorp
On Thu, 6 Mar 2025 16:18:06 +0800, Chao Yu wrote: > F2FS_IO_PROG was been exported twice, remove the redudant one. > > Cc: Jaegeuk Kim > Signed-off-by: Chao Yu > --- > common/config | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/common/config b/common/config > index 2afbda14..8d3047

Re: [f2fs-dev] [PATCH 6/9] f2fs: Pass sbi rather than sb to f2fs_set_test_dummy_encryption

2025-03-15 Thread Chao Yu via Linux-f2fs-devel
On 3/4/25 01:12, Eric Sandeen wrote: > This removes another sb instance from parse_options() > > Signed-off-by: Eric Sandeen Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourcef

Re: [f2fs-dev] [PATCH] f2fs_io: add fragread command to evaluate fragmented buffer for reads

2025-03-15 Thread Chao Yu via Linux-f2fs-devel
On 3/12/25 03:36, Jaegeuk Kim wrote: > On 03/11, Chao Yu wrote: >> On 3/4/25 09:10, Jaegeuk Kim via Linux-f2fs-devel wrote: >>> From: Jaegeuk Kim >>> >>> This adds a fragread command in f2fs_io, which is able to measure the >>> read performance on fragmented data buffer. >>> >>> Signed-off-by: Jae

Re: [f2fs-dev] [PATCH v3] f2fs: fix missing discard candidates in fstrim

2025-03-15 Thread Chunhai Guo via Linux-f2fs-devel
在 3/12/2025 10:27 PM, Jaegeuk Kim 写道: > On 03/12, Chunhai Guo wrote: >> fstrim may miss candidates that need to be discarded, as shown in the >> examples below. >> >> The root cause is that when cpc->reason is set with CP_DISCARD, >> add_discard_addrs() expects that ckpt_valid_map and cur_valid_map