Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Gao Xiang
Hi Matthew, On 2025/7/16 04:40, Matthew Wilcox wrote: I've started looking at how the page cache can help filesystems handle compressed data better. Feedback would be appreciated! I'll probably say a few things which are obvious to anyone who knows how compressed files work, but I'm trying to

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Nanzhe Zhao
Dear Matthew and other filesystem developers, I've been experimenting with implementing large folio support for compressed files in F2FS locally, and I'd like to describe the situation from the F2FS perspective. > First, I believe that all filesystems work by compressing fixed-size > plaintext in

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-15 Thread Jens Axboe
On 7/15/25 9:34 PM, hanqi wrote: > > > ? 2025/7/15 22:28, Jens Axboe ??: >> On 7/14/25 9:10 PM, Qi Han wrote: >>> Jens has already completed the development of uncached buffered I/O >>> in git [1], and in f2fs, the feature can be enabled simply by setting >>> the FOP_DONTCACHE flag in f2fs_file_o

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-15 Thread hanqi via Linux-f2fs-devel
在 2025/7/15 22:28, Jens Axboe 写道: On 7/14/25 9:10 PM, Qi Han wrote: Jens has already completed the development of uncached buffered I/O in git [1], and in f2fs, the feature can be enabled simply by setting the FOP_DONTCACHE flag in f2fs_file_operations. You need to ensure that for any DONTCAC

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Gao Xiang
On 2025/7/16 12:54, Qu Wenruo wrote: 在 2025/7/16 10:46, Gao Xiang 写道: ... There's some discrepancy between filesystems whether you need scratch space for decompression.  Some filesystems read the compressed data into the pagecache and decompress in-place, while other filesystems read th

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Qu Wenruo via Linux-f2fs-devel
在 2025/7/16 10:46, Gao Xiang 写道: ... There's some discrepancy between filesystems whether you need scratch space for decompression.  Some filesystems read the compressed data into the pagecache and decompress in-place, while other filesystems read the compressed data into scratch pages and

[f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-15 Thread Qi Han via Linux-f2fs-devel
Jens has already completed the development of uncached buffered I/O in git [1], and in f2fs, the feature can be enabled simply by setting the FOP_DONTCACHE flag in f2fs_file_operations. [1] https://lore.kernel.org/all/20241220154831.1086649-10-ax...@kernel.dk/T/#m58520a94b46f543d82db3711453dfc7bb5

Re: [f2fs-dev] [question] Design rationale behind f2fs_map_blocks block reuse in LFS mode with DIO

2025-07-15 Thread Chao Yu via Linux-f2fs-devel
Hi, Sorry for the delay. On 6/12/25 20:32, 김규진 wrote: > Hi F2FS developers, > > I'm testing multi-threaded direct I/O in LFS mode on Linux kernel > 6.8.0-57.59, and noticed what seems to be an inefficiency in block > allocation behavior inside `fs/f2fs/data.c` (specifically > `f2fs_map_blocks()`

[f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Matthew Wilcox
I've started looking at how the page cache can help filesystems handle compressed data better. Feedback would be appreciated! I'll probably say a few things which are obvious to anyone who knows how compressed files work, but I'm trying to be explicit about my assumptions. First, I believe that

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Qu Wenruo via Linux-f2fs-devel
在 2025/7/16 06:10, Matthew Wilcox 写道: I've started looking at how the page cache can help filesystems handle compressed data better. Feedback would be appreciated! I'll probably say a few things which are obvious to anyone who knows how compressed files work, but I'm trying to be explicit abo

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Gao Xiang
... There's some discrepancy between filesystems whether you need scratch space for decompression.  Some filesystems read the compressed data into the pagecache and decompress in-place, while other filesystems read the compressed data into scratch pages and decompress into the page cache. B

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Boris Burkov
On Tue, Jul 15, 2025 at 09:40:42PM +0100, Matthew Wilcox wrote: > I've started looking at how the page cache can help filesystems handle > compressed data better. Feedback would be appreciated! I'll probably > say a few things which are obvious to anyone who knows how compressed > files work, but

Re: [f2fs-dev] Compressed files & the page cache

2025-07-15 Thread Gao Xiang
On 2025/7/16 07:32, Gao Xiang wrote: Hi Matthew, On 2025/7/16 04:40, Matthew Wilcox wrote: I've started looking at how the page cache can help filesystems handle compressed data better.  Feedback would be appreciated!  I'll probably say a few things which are obvious to anyone who knows how c

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-15 Thread Jens Axboe
On 7/14/25 9:10 PM, Qi Han wrote: > Jens has already completed the development of uncached buffered I/O > in git [1], and in f2fs, the feature can be enabled simply by setting > the FOP_DONTCACHE flag in f2fs_file_operations. You need to ensure that for any DONTCACHE IO that the completion is rout

Re: [f2fs-dev] [syzbot] [f2fs?] INFO: task hung in f2fs_issue_checkpoint (2)

2025-07-15 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:0be23810e32e Add linux-next specific files for 20250714 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=1409f0f058 kernel config: https://syzkaller.appspot.com/x/.config?x=adc3ea2bfe

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-15 Thread hanqi via Linux-f2fs-devel
在 2025/7/15 14:58, Chao Yu 写道: On 7/15/25 11:10, Qi Han wrote: Jens has already completed the development of uncached buffered I/O in git [1], and in f2fs, the feature can be enabled simply by setting the FOP_DONTCACHE flag in f2fs_file_operations. Hi Qi, do you have any numbers of f2fs befor