[f2fs-dev] [PATCH 5/5] f2fs: convert recover_orphan_inodes to void

2013-11-27 Thread Chao Yu
Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c |6 +++--- fs/f2fs/f2fs.h |2 +- fs/f2fs/super.c |8 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 7fe69ff..b28e61b 100644 --- a/fs/f2fs/checkpoint.c

[f2fs-dev] [PATCH 4/5] f2fs: check return value of f2fs_readpage in find_data_page

2013-11-27 Thread Chao Yu
We should return error if we do not get an updated page in find_date_page when f2fs_readpage failed. Signed-off-by: Chao Yu --- fs/f2fs/data.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 2d02cf3..85071d6 100644 --- a/fs/f2fs/data.c +++ b/fs/f2f

[f2fs-dev] [PATCH 2/5] f2fs: add unlikely macro for compiler optimization

2013-11-27 Thread Chao Yu
Signed-off-by: Chao Yu --- fs/f2fs/node.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 0fe9a97..954155b 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1160,7 +1160,7 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi

[f2fs-dev] [PATCH 3/5] f2fs: use true and false for boolean variable

2013-11-27 Thread Chao Yu
Signed-off-by: Chao Yu --- fs/f2fs/node.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 954155b..daf8ee8 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -791,7 +791,7 @@ int truncate_xattr_node(struct inode *inode, struct page *p

[f2fs-dev] [PATCH 1/5] f2fs: correct type of wait in struct bio_private

2013-11-27 Thread Chao Yu
Signed-off-by: Chao Yu --- fs/f2fs/segment.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index b84dd23..5f733ec 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -96,7 +96,7 @@ struct bio_private { struct f2fs_sb_in

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Thursday, November 28, 2013 11:33 AM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; '谭姝' > Subject: RE: [f2fs-dev] [PATCH] f2fs

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Jaegeuk Kim
Thank you Dan. I wrote two patches to address the warnings below. Thanks. >From 1745cd1e14eff75089a8d88fe07f07549e1f3946 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Thu, 28 Nov 2013 12:44:05 +0900 Subject: [PATCH 1/2] f2fs: bug fix on bit overflow from 32bits to 64bits Cc: linux-fsde...@vge

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Jaegeuk Kim
Hi, 2013-11-28 (목), 09:26 +0800, Chao Yu: > Hi Kim, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > > Sent: Wednesday, November 27, 2013 4:19 PM > > To: Chao Yu > > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > > linux-f2fs-devel@lis

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Chao Yu
Hi Kim, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Wednesday, November 27, 2013 4:19 PM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; '谭姝' > Subject: RE: [f2fs-dev] [PATCH]

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Dan Carpenter
On Wed, Nov 27, 2013 at 06:04:57PM +0900, Jaegeuk Kim wrote: > Hi, > > 2013-11-27 (수), 11:31 +0300, Dan Carpenter: > > On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote: > > > Hi Dan, > > > > > > Thank you for the report. > > > > > > How about this? > > > Thanks, > > > > You've just d

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Jaegeuk Kim
Hi, 2013-11-27 (수), 11:31 +0300, Dan Carpenter: > On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote: > > Hi Dan, > > > > Thank you for the report. > > > > How about this? > > Thanks, > > You've just disguised the bug instead of fixing it. Later versions of > this static checker will

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Dan Carpenter
On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote: > Hi Dan, > > Thank you for the report. > > How about this? > Thanks, You've just disguised the bug instead of fixing it. Later versions of this static checker will complain about the new code as well. We're unlikely to support 18TB

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Jaegeuk Kim
Hi, 2013-11-27 (수), 15:58 +0800, Chao Yu: > Hi Kim, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > > Sent: Wednesday, November 27, 2013 1:30 PM > > To: Chao Yu > > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > > linux-f2fs-devel@lis