[f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Chao Yu
As we know, some of our branch condition will rarely be true. So we could add 'unlikely' to let compiler optimize these code, by this way we could drop unneeded 'jump' assemble code to improve performance. change log: o add *unlikely* as many as possible across the whole source files at once

Re: [f2fs-dev] [PATCH 3/3] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-05 Thread Chao Yu
Hi, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Friday, December 06, 2013 9:43 AM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; 谭姝 Subject: RE: [f2fs-dev] [PATCH 3/3] f2fs:

Re: [f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Jaegeuk Kim
Hi, Just in case, if you agreed the following comments, I'll fix those and merge the patch by myself. Thanks, 2013-12-05 (목), 17:15 +0800, Chao Yu: As we know, some of our branch condition will rarely be true. So we could add 'unlikely' to let compiler optimize these code, by this way we could

[f2fs-dev] [PATCH] f2fs: add unlikely() macro for compiler more aggressively

2013-12-05 Thread Jaegeuk Kim
This patch adds unlikely() macro into the most of codes. The basic rule is to add that when: - checking unusual errors, - checking page mappings, - and the other unlikely conditions. Cc: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c |