[f2fs-dev] [PATCH] f2fs: write dirty meta pages collectively

2013-12-17 Thread Jaegeuk Kim
This patch enhances writing dirty meta pages collectively in background. During the file data writes, it'd better avoid to write small dirty meta pages frequently. So let's give a chance to collect a number of dirty meta pages for a while. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com ---

Re: [f2fs-dev] [PATCH 05/18] fs: make posix_acl_chmod more useful

2013-12-17 Thread Andreas Gruenbacher
Christoph, +int +posix_acl_chmod(struct inode *inode) +{ + struct posix_acl *acl; + int ret = 0; + + if (S_ISLNK(inode-i_mode) || !inode-i_op-set_acl) + return -EOPNOTSUPP; Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check here.

Re: [f2fs-dev] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

2013-12-17 Thread Christoph Hellwig
On Thu, Dec 12, 2013 at 08:08:38PM +0100, Andreas Gruenbacher wrote: Christoph, gfs2 has a left-over get_acl callback in gfs2_symlink_iops in fs/gfs2/inode.c, from a long time ago, which should be removed as well. Ok, will fix.

Re: [f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-17 Thread Christoph Hellwig
On Thu, Dec 12, 2013 at 08:06:09PM +0100, Andreas Gruenbacher wrote: + /* +* A filesystem can force a ACL callback by just never filling the +* ACL cache. But normally you'd fill the cache either at inode +* instantiation time, or on the first -get_acl call. +* +*

Re: [f2fs-dev] [PATCH 05/18] fs: make posix_acl_chmod more useful

2013-12-17 Thread Christoph Hellwig
On Thu, Dec 12, 2013 at 08:07:20PM +0100, Andreas Gruenbacher wrote: Christoph, +int +posix_acl_chmod(struct inode *inode) +{ + struct posix_acl *acl; + int ret = 0; + + if (S_ISLNK(inode-i_mode) || !inode-i_op-set_acl) + return -EOPNOTSUPP; Symlinks never

Re: [f2fs-dev] [PATCH 04/18] fs: add generic xattr_acl handlers

2013-12-17 Thread Andreas Gruenbacher
Christoph, +static int +posix_acl_xattr_set(struct dentry *dentry, const char *name, + const void *value, size_t size, int flags, int type) +{ + struct inode *inode = dentry-d_inode; + struct posix_acl *acl = NULL; + int ret; + + if (!IS_POSIXACL(inode)) +

Re: [f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-17 Thread Andreas Gruenbacher
Christoph, +struct posix_acl *get_acl(struct inode *inode, int type) +{ + struct posix_acl *acl; + + acl = get_cached_acl(inode, type); + if (acl != ACL_NOT_CACHED) + return acl; + + if (!IS_POSIXACL(inode)) + return NULL; + + /* + * A