Re: [f2fs-dev] [PATCH 2/2] f2fs: fix the number of orphan inode blocks

2015-02-25 Thread Chao Yu
Hi Wanpeng, > -Original Message- > From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] > Sent: Thursday, February 26, 2015 7:57 AM > To: Jaegeuk Kim > Cc: Wanpeng Li; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH 2/2] f2fs: fix the nu

Re: [f2fs-dev] [PATCH 1/2] f2fs: introduce macro __cp_payload

2015-02-25 Thread Chao Yu
Hi Wanpeng, > -Original Message- > From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] > Sent: Thursday, February 26, 2015 7:57 AM > To: Jaegeuk Kim > Cc: Wanpeng Li; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH 1/2] f2fs: introduce

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery

2015-02-25 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, February 26, 2015 5:47 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong

[f2fs-dev] [PATCH 2/2] f2fs: fix the number of orphan inode blocks

2015-02-25 Thread Wanpeng Li
cp_pack_start_sum is calculated in do_checkpoint and is equal to cpu_to_le32(1 + cp_payload_blks + orphan_blocks). The number of orphan inode blocks is take advantage of by recover_orphan_inodes to readahead meta pages and recovery inodes. However, current codes forget to reduce the number of c

[f2fs-dev] [PATCH 1/2] f2fs: introduce macro __cp_payload

2015-02-25 Thread Wanpeng Li
This patch introduce macro __cp_payload. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 7 +++ fs/f2fs/f2fs.h | 7 ++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 7f794b7..4dbcc81 100644 --- a/fs/f2fs/checkp

Re: [f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Wanpeng Li
Hi Jaegeuk, On Wed, Feb 25, 2015 at 10:35:23AM -0800, Jaegeuk Kim wrote: >Hi Wanpeng, > >On Wed, Feb 25, 2015 at 12:53:37PM +0800, Wanpeng Li wrote: >> recover_orphan_inodes is used to recover orphan inodes, the meta pages >> which readahead should be orphan_blkaddr - start_blk instead of >> orph

[f2fs-dev] [PATCH 1/2] f2fs: remove obsolete code

2015-02-25 Thread Jaegeuk Kim
This patch removes obsolete code in which summary variable is not needed. Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 188a034..b2a92d4 100644 --- a/fs/f2fs/recovery.c +++ b/fs/f2fs/recovery.c

[f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery

2015-02-25 Thread Jaegeuk Kim
From: Jaegeuk Kim During the roll-forward recovery, -ENOENT for f2fs_iget can be skipped. So, this error value should not be propagated. Change-Id: I230ad2371e3fb4b9df42059c4a61f92c1f9838de Signed-off-by: Jaegeuk Kim --- fs/f2fs/recovery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[f2fs-dev] [PATCH] fsck.f2fs: remove corrupted data indices in direct node blocks

2015-02-25 Thread Jaegeuk Kim
Previously, only data blocks locating in its inode block could be fixed. This patch investigates direct node blocks to fix indices too. Signed-off-by: Jaegeuk Kim --- fsck/fsck.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 9d6f

Re: [f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Jaegeuk Kim
Hi Wanpeng, On Wed, Feb 25, 2015 at 12:53:37PM +0800, Wanpeng Li wrote: > recover_orphan_inodes is used to recover orphan inodes, the meta pages > which readahead should be orphan_blkaddr - start_blk instead of > orphan_blkaddr. > This patch fix it. > > Signed-off-by: Wanpeng Li > --- > fs/f2

[f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Wanpeng Li
recover_orphan_inodes is used to recover orphan inodes, the meta pages which readahead should be orphan_blkaddr - start_blk instead of orphan_blkaddr. This patch fix it. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs