Re: [f2fs-dev] [PATCH RFC] f2fs: recovering broken superblock during mount

2015-05-21 Thread Jaegeuk Kim
Hi Hu, Looks good to me, except one minor thing where + int recovery = 0, i; - AFAIK, kernel coding style recommends to split them. Let me change that to int recovery = 0; int i; Merged. Thanks, On Thu, May 21, 2015 at 02:42:53PM +0800, hujianyang wrote: On

[f2fs-dev] [PATCH 3/3] f2fs crypto: preallocate BIO_MAX_PAGES for writeback

2015-05-21 Thread Jaegeuk Kim
This patch changes the number of preallocated pages to BIO_MAX_PAGES to prepare writeback encryption. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/crypto.c b/fs/f2fs/crypto.c index 2ceee68..cfe5a04

[f2fs-dev] [PATCH 1/3] f2fs crypto: use per-inode tfm structure

2015-05-21 Thread Jaegeuk Kim
This patch applies the following ext4 patch: ext4 crypto: use per-inode tfm structure As suggested by Herbert Xu, we shouldn't allocate a new tfm each time we read or write a page. Instead we can use a single tfm hanging off the inode's crypt_info structure for all of our encryption needs for

[f2fs-dev] [PATCH 2/3] f2fs crypto: use bounce pages from mempool first

2015-05-21 Thread Jaegeuk Kim
If a lot of write streams are triggered, alloc_page and __free_page are costly called, resulting in high memory pressure. In order to avoid that, let's reuse mempool pages for writeback pages. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/crypto.c | 16 1 file

Re: [f2fs-dev] [PATCH RFC] f2fs: recovering broken superblock during mount

2015-05-21 Thread hujianyang
On 2015/5/22 6:44, Jaegeuk Kim wrote: Hi Hu, Looks good to me, except one minor thing where + int recovery = 0, i; - AFAIK, kernel coding style recommends to split them. Let me change that to int recovery = 0; int i; Merged. Thanks, Hi Jaegeuk, Thank