Re: [f2fs-dev] [PATCH v2] f2fs: should get a victim from retrials

2015-09-28 Thread Jaegeuk Kim
Change log from v1: o avoid __get_victim call twice, since each call registers the victim in bitmap >From 45c3aaea805751e5c1899dd9c76d89e6f73a7a8f Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 18 Sep 2015 17:33:00 -0700 Subject: [PATCH] f2fs: should get a victim from retrials If we do n

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-28 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 03:53:53PM +0200, Marc Lehmann wrote: > On Sat, Sep 26, 2015 at 12:36:55AM -0700, Jaegeuk Kim > wrote: > > > Care to share why? :) > > > > Mostly, in the flash storages, it is multiple 2MB normally. :) > > Well, any value of -s gives me a multiple of 2MB, no? :) > > > >

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-09-28 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 03:59:57PM +0200, Marc Lehmann wrote: > On Sat, Sep 26, 2015 at 12:52:53AM -0700, Jaegeuk Kim > wrote: > > > Just for fun I'll start doing a -s64 run. > > (which had the same result). > > > Okay, so before finding bad commits, if possible, can you get block traces? > >

[f2fs-dev] [PATCH 08/17] fs/f2fs: remove unnecessary new_valid_dev check

2015-09-28 Thread Yaowei Bai
As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/f2fs/namei.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index a680bf3..c87ec52 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@

[f2fs-dev] [PATCH] f2fs: fix to update {m, c}time correctly when truncating larger

2015-09-28 Thread Chao Yu
This patch fixes to update ctime and atime correctly when truncating larger in ->setattr. The bug is reported by xfstest generic/313 as below: generic/313 2s ... - output mismatch (see ./results/generic/313.out.bad) --- tests/generic/313.out 2015-08-04 15:28:53.430798882 +0800 +++ resul

[f2fs-dev] [PATCH v3] f2fs: fix to correct freed section number during gc

2015-09-28 Thread Chao Yu
This patch fixes to maintain the right section count freed in garbage collecting when triggering a foreground gc. Besides, when a foreground gc is running on current selected section, once we fail to gc one segment, it's better to abandon gcing the left segments in current section, because anyway

Re: [f2fs-dev] [PATCH v2] f2fs: fix to correct freed section number during gc

2015-09-28 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Saturday, September 26, 2015 2:04 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2] f2fs: fix to correct freed section number during gc > > On Fr