Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid f2fs_lock_op in f2fs_write_begin

2015-12-23 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, December 24, 2015 10:15 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 3/4] f2fs

Re: [f2fs-dev] [PATCH 2/4] f2fs: return early when trying to read null nid

2015-12-23 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, December 24, 2015 10:15 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/4] f2fs

Re: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed

2015-12-23 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, December 24, 2015 3:14 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only

Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: avoid unnecessary f2fs_gc for dir operations

2015-12-23 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, December 24, 2015 10:13 AM > To: Chao Yu > Cc: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: avoid un

[f2fs-dev] [PATCH 4/4] f2fs: declare static function

2015-12-23 Thread Jaegeuk Kim
The __f2fs_commit_super is static. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 597b533..75704d9 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1195,7 +1195,7 @@ next: re

[f2fs-dev] [PATCH 2/4] f2fs: return early when trying to read null nid

2015-12-23 Thread Jaegeuk Kim
If get_node_page() gets zero nid, we can return early without getting a wrong page. For example, get_dnode_of_data() can try to do that. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 341de5d..e17128d 100

[f2fs-dev] [PATCH 3/4] f2fs: avoid f2fs_lock_op in f2fs_write_begin

2015-12-23 Thread Jaegeuk Kim
If f2fs_write_begin is to update data, we can bypass calling f2fs_lock_op() in order to avoid the checkpoint latency in the write syscall. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 43 ++- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git

[f2fs-dev] [PATCH 1/4] f2fs: introduce prepare_write_begin to clean up

2015-12-23 Thread Jaegeuk Kim
This patch adds prepare_write_begin to clean f2fs_write_begin. The major role of this function is to convert any inline_data and allocate or find block address. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 92 ++ 1 file changed, 54 inser

Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: avoid unnecessary f2fs_gc for dir operations

2015-12-23 Thread Jaegeuk Kim
Hi Chao, Right. But, in the rename path, we still need to do f2fs_balance_fs, since it produces another dirty node page in the mean time. How about this? >From bbc5bf8f6c940cd75a4d71ce40ce4bd3f647a823 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 22 Dec 2015 11:56:08 -0800 Subject: [PAT

Re: [f2fs-dev] [PATCH 3/4 v2] f2fs: record node block allocation in dnode_of_data

2015-12-23 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, December 24, 2015 3:00 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 3/4 v2] f2fs: record node block alloc

Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: avoid unnecessary f2fs_gc for dir operations

2015-12-23 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, December 24, 2015 2:55 AM > To: Chao Yu > Cc: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 2/4 v2] f2

Re: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed

2015-12-23 Thread Jaegeuk Kim
Change log v2: - add dio case >From c2d16a526371954671f9c8cff5f09f9d230f7993 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 22 Dec 2015 13:23:35 -0800 Subject: [PATCH] f2fs: call f2fs_balance_fs only when node was changed If user tries to update or read data, we don't need to call f2fs_b

Re: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed

2015-12-23 Thread Jaegeuk Kim
Hi Chao, On Wed, Dec 23, 2015 at 05:46:59PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Wednesday, December 23, 2015 9:00 AM > > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > > linux-f2fs-dev

Re: [f2fs-dev] [PATCH 3/4 v2] f2fs: record node block allocation in dnode_of_data

2015-12-23 Thread Jaegeuk Kim
Change log from v1: - remove redundant set - adjust memory alignment >From 60c6a898094535e850268dd77701255a37cce3d3 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 22 Dec 2015 12:59:54 -0800 Subject: [PATCH] f2fs: record node block allocation in dnode_of_data This patch introduces record

Re: [f2fs-dev] [PATCH 3/4] f2fs: record node block allocation in dnode_of_data

2015-12-23 Thread Jaegeuk Kim
Hi Chao, On Wed, Dec 23, 2015 at 04:00:36PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Wednesday, December 23, 2015 9:00 AM > > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > > linux-f2fs-dev

Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: avoid unnecessary f2fs_gc for dir operations

2015-12-23 Thread Jaegeuk Kim
Chang log from v1: - add more cases >From 9fea6346f5dd2992525e853e27a4fe899d122379 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 22 Dec 2015 11:56:08 -0800 Subject: [PATCH] f2fs: avoid unnecessary f2fs_gc for dir operations The f2fs_balance_fs doesn't need to cover f2fs_new_inode or f2f

Re: [f2fs-dev] [PATCH 2/2] f2fs: speed up shrinking extent tree entries

2015-12-23 Thread Chao Yu
> -Original Message- > From: He YunLei [mailto:heyun...@huawei.com] > Sent: Tuesday, December 22, 2015 8:35 PM > To: Chao Yu > Cc: 'Jaegeuk Kim'; linux-fsde...@vger.kernel.org; > linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 2/2] f2

[f2fs-dev] [PATCH 2/2] f2fs: don't convert inline inode when inline_data option is disable

2015-12-23 Thread Chao Yu
If inline_data option is disable, when truncating an inline inode with size which is not exceed maxinum inline size, we should not convert inline inode to regular one to avoid the overhead of synchronizing conversion. Signed-off-by: Chao Yu --- fs/f2fs/inline.c | 3 --- fs/f2fs/namei.c | 2 +-

[f2fs-dev] [PATCH 1/2] f2fs: report error of do_checkpoint

2015-12-23 Thread Chao Yu
do_checkpoint and write_checkpoint can fail due to reasons like triggering in a readonly fs or encountering IO error of storage device. So it's better to report such error info to user, let user be aware of failure of doing checkpoint. Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c | 29 ++

Re: [f2fs-dev] [PATCH 4/4] f2fs: call f2fs_balance_fs only when node was changed

2015-12-23 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, December 23, 2015 9:00 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 4/4] f2fs

Re: [f2fs-dev] [PATCH 3/4] f2fs: record node block allocation in dnode_of_data

2015-12-23 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, December 23, 2015 9:00 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 3/4] f2fs