Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread Yunlong Song
OK, Got it. On 2018/2/11 11:50, Chao Yu wrote: On 2018/2/11 11:34, Yunlong Song wrote: Ping... move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will lack these data pages in move_data_block, and write_checkpoint can not make sure this pages committed to the flash. Hmm.. data

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread heyunlei
>-Original Message- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaeg...@kernel.org; c...@kernel.org; Yuchao (T); yunlong.s...@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; >linux-f2fs-devel@lists.sourceforge.net;

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread Chao Yu
On 2018/2/11 11:34, Yunlong Song wrote: > Ping... > > move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will > lack these data pages in move_data_block, and write_checkpoint can > not make sure this pages committed to the flash. Hmm.. data block migration is running based on meta

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread Yunlong Song
Ping... move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will lack these data pages in move_data_block, and write_checkpoint can not make sure this pages committed to the flash. On 2018/2/8 20:33, Yunlong Song wrote: Signed-off-by: Yunlong Song ---

Re: [f2fs-dev] Cold log explanation

2018-02-10 Thread Chao Yu
On 2018/2/10 23:45, Piergiorgio Sartor wrote: > Hi all, > > I noticed that "mkfs.f2fs" has an option, "-e", > to store certain files into the "cold log". > > First, basic question, what is the "cold log" or, > better, what is the differnce between the "normal" > ("warm", I guess) log and this

Re: [f2fs-dev] [PATCH] f2fs: remove unneed reada during build free nids

2018-02-10 Thread Chao Yu
On 2018/2/11 9:55, heyunlei wrote: > > >> -Original Message- >> From: Chao Yu [mailto:c...@kernel.org] >> Sent: Friday, February 09, 2018 9:37 PM >> To: heyunlei; jaeg...@kernel.org; Yuchao (T); >> linux-f2fs-devel@lists.sourceforge.net >> Subject: Re: [f2fs-dev] [PATCH] f2fs: remove

Re: [f2fs-dev] [PATCH v2] f2fs: introduce "strict_fsync" for posix standard fsync

2018-02-10 Thread Junling Zheng
Hi, Jaegeuk On 2018/2/10 8:44, Jaegeuk Kim wrote: > On 02/02, Junling Zheng wrote: >> Commit "0a007b97aad6"(f2fs: recover directory operations by fsync) >> fixed xfstest generic/342 case, but it also increased the written >> data and caused the performance degradation. In most cases, there's >>

Re: [f2fs-dev] [PATCH] f2fs: remove unneed reada during build free nids

2018-02-10 Thread heyunlei
>-Original Message- >From: Chao Yu [mailto:c...@kernel.org] >Sent: Friday, February 09, 2018 9:37 PM >To: heyunlei; jaeg...@kernel.org; Yuchao (T); >linux-f2fs-devel@lists.sourceforge.net >Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneed reada during build free >nids > >On 2018/2/9

Re: [f2fs-dev] [RFC PATCH 0/2] f2fs: introduce lost+found feature

2018-02-10 Thread Sheng Yong
Hi, Jaegeuk On 2018/2/10 10:50, Jaegeuk Kim wrote: On 02/06, Sheng Yong wrote: This patchset introduces lost+found feature in f2fs. If the feature is enabled, f2fs should avoid to encrypting root directory. In that case, we need to add test_dummy_encryption likewise ext4. If the

[f2fs-dev] Cold log explanation

2018-02-10 Thread Piergiorgio Sartor
Hi all, I noticed that "mkfs.f2fs" has an option, "-e", to store certain files into the "cold log". First, basic question, what is the "cold log" or, better, what is the differnce between the "normal" ("warm", I guess) log and this one. Second, it is possible to disable this list *after*