Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Jaegeuk Kim
On 07/18, Chao Yu wrote: > On 2019/7/18 11:12, Jaegeuk Kim wrote: > > f2fs_allocate_data_block() invalidates old block address and enable new > > block > > address. Then, if we try to read old block by f2fs_submit_page_bio(), it > > will > > give WARN due to reading invalid blocks. > > > >

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Chao Yu
On 2019/7/18 11:30, Chao Yu wrote: > On 2019/7/18 11:12, Jaegeuk Kim wrote: >> f2fs_allocate_data_block() invalidates old block address and enable new block >> address. Then, if we try to read old block by f2fs_submit_page_bio(), it will >> give WARN due to reading invalid blocks. >> >> Let's make

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Chao Yu
On 2019/7/18 11:12, Jaegeuk Kim wrote: > f2fs_allocate_data_block() invalidates old block address and enable new block > address. Then, if we try to read old block by f2fs_submit_page_bio(), it will > give WARN due to reading invalid blocks. > > Let's make the order sanely back. Hmm.. to avoid

[f2fs-dev] [PATCH] f2fs_io: add fallocate

2019-07-17 Thread Jaegeuk Kim
This simply supports keep_size. Signed-off-by: Jaegeuk Kim --- tools/f2fs_io/f2fs_io.c | 45 + 1 file changed, 45 insertions(+) diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c index 7fd4425..f087da4 100644 --- a/tools/f2fs_io/f2fs_io.c +++

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Jaegeuk Kim
f2fs_allocate_data_block() invalidates old block address and enable new block address. Then, if we try to read old block by f2fs_submit_page_bio(), it will give WARN due to reading invalid blocks. Let's make the order sanely back. Signed-off-by: Jaegeuk Kim --- v2: I was fixing the comments. :)

Re: [f2fs-dev] [PATCH] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Chao Yu
On 2019/7/18 10:39, Chao Yu wrote: > On 2019/7/18 9:37, Jaegeuk Kim wrote: >> f2fs_allocate_data_block() invalidates old block address and enable new block >> address. Then, if we try to read old block by f2fs_submit_page_bio(), it will >> give WARN due to reading invalid blocks. >> >> Let's make

Re: [f2fs-dev] [PATCH] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Chao Yu
On 2019/7/18 9:37, Jaegeuk Kim wrote: > f2fs_allocate_data_block() invalidates old block address and enable new block > address. Then, if we try to read old block by f2fs_submit_page_bio(), it will > give WARN due to reading invalid blocks. > > Let's make the order sanely back. > >

[f2fs-dev] [Bug 204193] BUG: KASAN: null-ptr-deref in f2fs_write_end_io+0x215/0x650

2019-07-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204193 --- Comment #2 from midwinter1...@gmail.com --- (In reply to Chao Yu from comment #1) > How to reproduce this, remount to change io_bits option? It's not triggered by remount, the following script manifests it (note that this bug does not occur

[f2fs-dev] [PATCH] f2fs: fix to read source block before invalidating it

2019-07-17 Thread Jaegeuk Kim
f2fs_allocate_data_block() invalidates old block address and enable new block address. Then, if we try to read old block by f2fs_submit_page_bio(), it will give WARN due to reading invalid blocks. Let's make the order sanely back. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 57

[f2fs-dev] [Bug 202495] oops in fs/f2fs/checkpoint.c:150 f2fs_is_valid_blkaddr

2019-07-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202495 --- Comment #8 from Chao Yu (c...@kernel.org) --- It's here, it should be merged in AOSP as well. :) https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-stable.git/commit/?h=linux-4.14.y=3cc9792fa1ea67bbfdaee28737e37f9045976b76 -- You

[f2fs-dev] [Bug 202495] oops in fs/f2fs/checkpoint.c:150 f2fs_is_valid_blkaddr

2019-07-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202495 --- Comment #7 from phiber2...@gmx.de --- (In reply to Chao Yu from comment #6) > Was fixed with a backported patch ("f2fs: fix to skip verifying block > address for non-regular inode") Maybe my mistake, but I can't find the backported patch in

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Support case-insensitive file name lookups

2019-07-17 Thread Chao Yu
Hi Daniel, On 2019/7/17 11:14, Daniel Rosenberg wrote: > Modeled after commit b886ee3e778e ("ext4: Support case-insensitive file > name lookups") > > """ > This patch implements the actual support for case-insensitive file name > lookups in f2fs, based on the feature bit and the encoding stored

Re: [f2fs-dev] [PATCH] f2fs_io: fix wrong buffered/dio option

2019-07-17 Thread Chao Yu
On 2019/7/13 5:20, Jaegeuk Kim wrote: > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: include charset encoding information in the superblock

2019-07-17 Thread Chao Yu
On 2019/7/17 11:14, Daniel Rosenberg wrote: > Add charset encoding to f2fs to support casefolding. It is modeled after > the same feature introduced in commit c83ad55eaa91 ("ext4: include charset > encoding information in the superblock") > > Currently this is not compatible with encryption,

[f2fs-dev] [PATCH] f2fs: support FS_IOC_{GET,SET}FSLABEL

2019-07-17 Thread Chao Yu
Support two generic fs ioctls FS_IOC_{GET,SET}FSLABEL, letting f2fs pass generic/492 testcase. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 3 ++ fs/f2fs/file.c | 78 ++ 2 files changed, 81 insertions(+) diff --git a/fs/f2fs/f2fs.h