[f2fs-dev] [PATCH] f2fs: fix a comment in f2fs_shrink_count()

2019-09-27 Thread Chengguang Xu via Linux-f2fs-devel
Fix a mismatched comment in f2fs_shrink_count(). Signed-off-by: Chengguang Xu --- fs/f2fs/shrinker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c index a467aca29cfe..d66de5999a26 100644 --- a/fs/f2fs/shrinker.c +++

Re: [PATCH] f2fs: fix comment of f2fs_evict_inode

2019-09-27 Thread Gao Xiang
Hi Jaegeuk, On Fri, Sep 27, 2019 at 11:31:50AM -0700, Jaegeuk Kim wrote: > Hi Chao, > > On 09/25, Chao Yu wrote: > > evict() should be called once i_count is zero, rather than i_nlinke > > is zero. > > > > Reported-by: Gao Xiang > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/inode.c | 2 +- >

Re: [PATCH] f2fs: fix comment of f2fs_evict_inode

2019-09-27 Thread Jaegeuk Kim
Hi Chao, On 09/25, Chao Yu wrote: > evict() should be called once i_count is zero, rather than i_nlinke > is zero. > > Reported-by: Gao Xiang > Signed-off-by: Chao Yu > --- > fs/f2fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c

[PATCH] f2fs: fix inconsistent comments

2019-09-27 Thread Chao Yu
Lack of maintenance on comments may mislead developers, fix them. Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c | 18 -- fs/f2fs/data.c | 19 ++- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 1 - fs/f2fs/gc.c | 5 - fs/f2fs/inode.c

[f2fs-dev] [PATCH] common/rc: generalize _get_filesize()

2019-09-27 Thread Chao Yu
There are some testcases use below command to get file size, generalize it as global function _get_filesize() ls -l $1 | $AWK_PROG '{print $5}' - adjust common/defrag, generic/275 and generic/315 to use it - remove unused _filesize in generic/013 Signed-off-by: Chao Yu --- common/defrag |

[f2fs-dev] [PATCH] generic/group: add missing dedupe tag for generic/493

2019-09-27 Thread Chao Yu
We missed to add the tag, fix it. Signed-off-by: Chao Yu --- tests/generic/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/group b/tests/generic/group index 7cf4f6c4..18b5a545 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -495,7 +495,7 @@

[f2fs-dev] [PATCH 2/2] common/casefold: support f2fs

2019-09-27 Thread Chao Yu
Now, f2fs has ported casefold feature from ext4, let's enable the testcase. Signed-off-by: Chao Yu --- common/casefold | 9 + 1 file changed, 9 insertions(+) diff --git a/common/casefold b/common/casefold index 2a7ab3eb..9172d818 100644 --- a/common/casefold +++ b/common/casefold @@

[f2fs-dev] [PATCH 1/2] common/defrag: support f2fs

2019-09-27 Thread Chao Yu
F2FS supports defragment based on file granularity, adjust test suit to support f2fs. Signed-off-by: Chao Yu --- common/config | 2 ++ common/defrag | 11 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/common/config b/common/config index 4c86a492..c43be339 100644

[PATCH] f2fs: fix to update time in lazytime mode

2019-09-27 Thread Chao Yu
generic/018 reports an inconsistent status of atime, the testcase is as below: - open file with O_SYNC - write file to construct fraged space - calc md5 of file - record {a,c,m}time - defrag file --- do nothing - umount & mount - check {a,c,m}time The root cause is, as f2fs enables lazytime by

Re: [f2fs-dev] [PATCH] f2fs: mark recovery flag correctly in read_raw_super_block()

2019-09-27 Thread Chao Yu
On 2019/9/27 9:35, Chengguang Xu via Linux-f2fs-devel wrote: > On the combination of first fail and second success, > we will miss to mark recovery flag because currently > we reuse err variable in the loop. > > Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Thanks,