Re: [f2fs-dev] [PATCH] f2fs: fix comment of f2fs_evict_inode

2019-09-28 Thread Chao Yu
On 2019/9/29 10:20, Gao Xiang wrote: > On Sun, Sep 29, 2019 at 08:53:05AM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2019/9/28 2:31, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On 09/25, Chao Yu wrote: evict() should be called once i_count is zero, rather than i_nlinke is zero. R

Re: [f2fs-dev] [PATCH] f2fs: fix a comment in f2fs_shrink_count()

2019-09-28 Thread admin via Linux-f2fs-devel
在 星期日, 2019-09-29 08:56:25 Chao Yu 撰写 > Hi Chengguang, > > Thanks a lot for the patch, previously I've sent a patch to fix most > inconsistent comments including below one, could you check that? > > https://lore.kernel.org/linux-f2fs-devel/20190927102305.11587-1-yuch...@huawei.c

Re: [f2fs-dev] [PATCH] f2fs: fix comment of f2fs_evict_inode

2019-09-28 Thread Gao Xiang
On Sun, Sep 29, 2019 at 08:53:05AM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2019/9/28 2:31, Jaegeuk Kim wrote: > > Hi Chao, > > > > On 09/25, Chao Yu wrote: > >> evict() should be called once i_count is zero, rather than i_nlinke > >> is zero. > >> > >> Reported-by: Gao Xiang > >> Signed-off-b

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-28 Thread Chao Yu
On 2019/9/25 16:05, Shinichiro Kawasaki wrote: > On Sep 21, 2019 / 17:42, Chao Yu wrote: >> On 2019/9/18 11:07, Shinichiro Kawasaki wrote: >>> Thanks for the comments. I read f2fs code further, and think still the >>> SIT vs write pointer check can be implemented and meaningful. >>> >>> F2fs ensure

Re: [f2fs-dev] [PATCH] f2fs: fix a comment in f2fs_shrink_count()

2019-09-28 Thread Chao Yu
Hi Chengguang, Thanks a lot for the patch, previously I've sent a patch to fix most inconsistent comments including below one, could you check that? https://lore.kernel.org/linux-f2fs-devel/20190927102305.11587-1-yuch...@huawei.com/T/#u Thanks, On 2019/9/28 9:40, Chengguang Xu via Linux-f2fs-de

Re: [PATCH] f2fs: fix comment of f2fs_evict_inode

2019-09-28 Thread Chao Yu
Hi Jaegeuk, On 2019/9/28 2:31, Jaegeuk Kim wrote: > Hi Chao, > > On 09/25, Chao Yu wrote: >> evict() should be called once i_count is zero, rather than i_nlinke >> is zero. >> >> Reported-by: Gao Xiang >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/inode.c | 2 +- >> 1 file changed, 1 insertion(+