Re: [f2fs-dev] [RFC] errno.h: Provide EFSCORRUPTED for everybody

2019-11-05 Thread Dave Chinner
On Tue, Nov 05, 2019 at 04:15:50PM +0100, David Sterba wrote: > On Sat, Nov 02, 2019 at 08:38:23AM +1100, Dave Chinner wrote: > > On Fri, Nov 01, 2019 at 09:57:31PM +0100, Geert Uytterhoeven wrote: > > > Hi Valdis, > > > > > > On Thu, Oct 31, 2019 at 2:11 AM Valdis Kletnieks > > > wrote: > > > >

Re: [f2fs-dev] [PATCH v2 1/3] fscrypt: add support for IV_INO_LBLK_64 policies

2019-11-05 Thread Eric Biggers
On Tue, Nov 05, 2019 at 10:35:44PM -0500, Theodore Y. Ts'o wrote: > On Thu, Oct 24, 2019 at 02:54:36PM -0700, Eric Biggers wrote: > > @@ -83,6 +118,10 @@ bool fscrypt_supported_policy(const union > > fscrypt_policy *policy_u, > > return false; > > } > > > > +

Re: [f2fs-dev] [PATCH v2 1/3] fscrypt: add support for IV_INO_LBLK_64 policies

2019-11-05 Thread Theodore Y. Ts'o
On Thu, Oct 24, 2019 at 02:54:36PM -0700, Eric Biggers wrote: > @@ -83,6 +118,10 @@ bool fscrypt_supported_policy(const union fscrypt_policy > *policy_u, > return false; > } > > + if ((policy->flags & FSCRYPT_POLICY_FLAG_IV_INO_LBLK_64) && > +

Re: [f2fs-dev] [PATCH v2 2/3] ext4: add support for IV_INO_LBLK_64 encryption policies

2019-11-05 Thread Theodore Y. Ts'o
On Thu, Oct 24, 2019 at 02:54:37PM -0700, Eric Biggers wrote: > From: Eric Biggers > > IV_INO_LBLK_64 encryption policies have special requirements from the > filesystem beyond those of the existing encryption policies: > > - Inode numbers must never change, even if the filesystem is resized. >

[f2fs-dev] Please Read Carefully

2019-11-05 Thread Robert
Hello there, I got your contact from an online directory and I have a proposition that may be of interest to you. I am a Personal Assistant to a former minister in the South African government cabinet. During my bosses time as a minister, he used his position as a minister to amass to amass

Re: [f2fs-dev] [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody

2019-11-05 Thread Dave Chinner
On Mon, Nov 04, 2019 at 09:46:14PM -0500, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Looks good, minor nit below: > diff --git a/include/uapi/asm-generic/errno.h >

Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-11-05 Thread Christoph Hellwig
On Mon, Nov 04, 2019 at 06:01:17PM -0800, Eric Biggers wrote: > I think that "Severely bloating the per-I/O data structure" is an > exaggeration, > since that it's only 32 bytes, and it isn't in struct bio directly but rather > in > struct bio_crypt_ctx... Yes, and none of that is needed for

Re: [f2fs-dev] [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr

2019-11-05 Thread Mark Salyzyn via Linux-f2fs-devel
On 11/5/19 1:48 AM, Jan Kara wrote: @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler, break; case 1: data = buf; - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); + dsize =

Re: [f2fs-dev] [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody

2019-11-05 Thread Darrick J. Wong
On Mon, Nov 04, 2019 at 09:46:14PM -0500, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Acked-by: Darrick J. Wong You can build all six filesystems with both this and

Re: [f2fs-dev] [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody

2019-11-05 Thread Theodore Y. Ts'o
On Mon, Nov 04, 2019 at 09:46:14PM -0500, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Acked-by: Theodore Ts'o - Ted

Re: [f2fs-dev] [PATCH 0/2] f2fs-tools: Introduce cache to speed up fsck

2019-11-05 Thread Chao Yu
Hi Robin, Could you explain what is the basic idea for this user-space cache? Thanks, On 2019/10/29 15:46, Robin Hsu wrote: > Implemented cache and related command line options. > > Robin Hsu (2): > libf2fs_io: Add user-space cache > fsck.f2fs: Enable user-space cache > > fsck/main.c

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Check write pointer consistency of non-open zones

2019-11-05 Thread Chao Yu
On 2019/10/28 14:58, Shin'ichiro Kawasaki wrote: > To catch f2fs bugs in write pointer handling code for zoned block > devices, check write pointers of non-open zones that current segments do > not point to. Do this check at mount time, after the fsync data recovery > and current segments' write

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: Check write pointer consistency of open zones

2019-11-05 Thread Chao Yu
On 2019/10/28 14:58, Shin'ichiro Kawasaki wrote: > On sudden f2fs shutdown, write pointers of zoned block devices can go > further but f2fs meta data keeps current segments at positions before the > write operations. After remounting the f2fs, this inconsistency causes > write operations not at

Re: [f2fs-dev] [PATCH v6 8/8] fsck: Check write pointer consistency of non-open zones

2019-11-05 Thread Chao Yu
On 2019/10/28 14:55, Shin'ichiro Kawasaki wrote: > To catch f2fs bug in write pointer handling code for zoned block devices, > have fsck check consistency of write pointers of non-open zones, that > current segments do not point to. Check two items comparing write pointer > positions with valid

Re: [f2fs-dev] [PATCH v6 7/8] fsck: Check write pointer consistency of open zones

2019-11-05 Thread Chao Yu
On 2019/10/28 14:55, Shin'ichiro Kawasaki wrote: > On sudden f2fs shutdown, write pointers of zoned block devices can go > further but f2fs meta data keeps current segments at positions before the > write operations. After remounting the f2fs, this inconsistency causes > write operations not at

Re: [f2fs-dev] [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr

2019-11-05 Thread Jan Kara
> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler > *handler, > break; > case 1: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > + dsize = scnprintf(buf, sizeof(buf), "%u",

Re: [f2fs-dev] [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody

2019-11-05 Thread Jan Kara
On Mon 04-11-19 21:46:14, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Thanks for the patch! It looks good to me. You can add: Reviewed-by: Jan Kara

[f2fs-dev] Investment opportunity

2019-11-05 Thread Peter Wong
Greetings, Find the attached mail very confidential. reply for more details Thanks. Peter Wong This email was sent by the shareware version of Postman Professional. ___ Linux-f2fs-devel