Re: [f2fs-dev] [PATCH 3/4] fscrypt: support test_dummy_encryption=v2

2020-05-18 Thread Jaegeuk Kim
On 05/18, Eric Biggers wrote: > On Mon, May 18, 2020 at 08:02:05PM -0700, Eric Biggers wrote: > > On Mon, May 18, 2020 at 10:53:55PM -0400, Theodore Y. Ts'o wrote: > > > On Tue, May 12, 2020 at 04:32:50PM -0700, Eric Biggers wrote: > > > > From: Eric Biggers > > > > > > > > v1 encryption

Re: [f2fs-dev] [PATCH 3/4] fscrypt: support test_dummy_encryption=v2

2020-05-18 Thread Eric Biggers
On Mon, May 18, 2020 at 08:02:05PM -0700, Eric Biggers wrote: > On Mon, May 18, 2020 at 10:53:55PM -0400, Theodore Y. Ts'o wrote: > > On Tue, May 12, 2020 at 04:32:50PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > v1 encryption policies are deprecated in favor of v2, and some

Re: [f2fs-dev] [PATCH 3/4] fscrypt: support test_dummy_encryption=v2

2020-05-18 Thread Eric Biggers
On Mon, May 18, 2020 at 10:53:55PM -0400, Theodore Y. Ts'o wrote: > On Tue, May 12, 2020 at 04:32:50PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > v1 encryption policies are deprecated in favor of v2, and some new > > features (e.g. encryption+casefolding) are only being added for

Re: [f2fs-dev] [PATCH 4/4] fscrypt: make test_dummy_encryption use v2 by default

2020-05-18 Thread Theodore Y. Ts'o
On Tue, May 12, 2020 at 04:32:51PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Since v1 encryption policies are deprecated, make test_dummy_encryption > test v2 policies by default. > > Note that this causes ext4/023 and ext4/028 to start failing due to > known bugs in those tests (see

Re: [f2fs-dev] [PATCH 3/4] fscrypt: support test_dummy_encryption=v2

2020-05-18 Thread Theodore Y. Ts'o
On Tue, May 12, 2020 at 04:32:50PM -0700, Eric Biggers wrote: > From: Eric Biggers > > v1 encryption policies are deprecated in favor of v2, and some new > features (e.g. encryption+casefolding) are only being added for v2. > > Therefore, the "test_dummy_encryption" mount option (which is used

Re: [f2fs-dev] [PATCH] f2fs: don't return vmalloc() memory from f2fs_kmalloc()

2020-05-18 Thread Jaegeuk Kim
On 05/18, Eric Biggers wrote: > On Mon, May 18, 2020 at 11:06:48AM -0700, Jaegeuk Kim wrote: > > On 05/05, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > kmalloc() returns kmalloc'ed memory, and kvmalloc() returns either > > > kmalloc'ed or vmalloc'ed memory. But the f2fs wrappers,

Re: [f2fs-dev] [PATCH] f2fs: don't return vmalloc() memory from f2fs_kmalloc()

2020-05-18 Thread Eric Biggers
On Mon, May 18, 2020 at 11:06:48AM -0700, Jaegeuk Kim wrote: > On 05/05, Eric Biggers wrote: > > From: Eric Biggers > > > > kmalloc() returns kmalloc'ed memory, and kvmalloc() returns either > > kmalloc'ed or vmalloc'ed memory. But the f2fs wrappers, f2fs_kmalloc() > > and f2fs_kvmalloc(), both

Re: [f2fs-dev] [PATCH] f2fs: don't return vmalloc() memory from f2fs_kmalloc()

2020-05-18 Thread Jaegeuk Kim
On 05/05, Eric Biggers wrote: > From: Eric Biggers > > kmalloc() returns kmalloc'ed memory, and kvmalloc() returns either > kmalloc'ed or vmalloc'ed memory. But the f2fs wrappers, f2fs_kmalloc() > and f2fs_kvmalloc(), both return both kinds of memory. > > It's redundant to have two functions

Re: [f2fs-dev] [PATCH] f2fs: flush dirty meta pages when flushing them

2020-05-18 Thread Jaegeuk Kim
On 05/18, Chao Yu wrote: > On 2020/5/15 22:45, Jaegeuk Kim wrote: > > On 05/15, Chao Yu wrote: > >> On 2020/5/15 10:15, Jaegeuk Kim wrote: > >>> Let's guarantee flusing dirty meta pages to avoid infinite loop. > >> > >> What's the root cause? Race case or meta page flush failure? > > > >

Re: [f2fs-dev] [PATCH v13 00/12] Inline Encryption Support

2020-05-18 Thread Christoph Hellwig
On Fri, May 15, 2020 at 10:00:59AM -0700, Eric Biggers wrote: > The fallback is actually really useful. First, for testing: it allows all the > filesystem code that uses inline crypto to be tested using gce-xfstests and > kvm-xfstests, so that it's covered by the usual ext4 and f2fs regression >

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-18 Thread Naresh Kamboju
895 done Writing inode tables: 0/895 done Creating journal (131072 blocks): [ 31.251333] mkfs.ext4 invoked oom-killer: gfp_mask=0x101cc0(GFP_USER|__GFP_WRITE), order=0, oom_score_adj=0 [ 31.261172] CPU: 0 PID: 397 Comm: mkfs.ext4 Not tainted 5.7.0-rc6-next-202