Re: [f2fs-dev] [RFC PATCH] f2fs: expand f2fs_compr_option to allow ioctl setting compression level

2023-03-30 Thread Sheng Yong via Linux-f2fs-devel
On 2023/3/31 0:15, Yangtao Li wrote: Hi Sheng Yong, Your idea, I also put forward before. And has been sent to version 2, but Chao and Jaegeuk have no comments yet. Time to talk about the series? https://lore.kernel.org/linux-f2fs-devel/20230112133503.16802-1-frank...@vivo.com/ Hi,

[f2fs-dev] [PATCH] f2fs: support to show noage_extent_cache mount option

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
This patch support noage_extent_cache mount option. Signed-off-by: Yangtao Li --- Documentation/filesystems/f2fs.rst | 2 ++ fs/f2fs/super.c| 7 +++ 2 files changed, 9 insertions(+) diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst

[f2fs-dev] [RESEND] f2fs: set default compress option only when sb_has_compression

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
If the compress feature is not enabled, there is no need to set compress-related parameters. Signed-off-by: Yangtao Li --- fs/f2fs/super.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 768be1c76a47..b5828a67f7c1 100644 ---

[f2fs-dev] [PATCH v2] f2fs: merge lz4hc_compress_pages() to lz4_compress_pages()

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
Remove unnecessary lz4hc_compress_pages(). Signed-off-by: Yangtao Li --- v2: -rebase fs/f2fs/compress.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index 3182e1506252..f8b15c932c97 100644 ---

[f2fs-dev] [RESEND] f2fs: add sanity compress level check for compressed file

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
Commit 3fde13f817e2 ("f2fs: compress: support compress level") forgot to do basic compress level check, let's add it. Signed-off-by: Yangtao Li --- fs/f2fs/inode.c | 94 + include/linux/zstd_lib.h| 3 ++ lib/zstd/compress/clevels.h | 4 -- 3

Re: [f2fs-dev] [RFC PATCH] f2fs: expand f2fs_compr_option to allow ioctl setting compression level

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
Hi Sheng Yong, Your idea, I also put forward before. And has been sent to version 2, but Chao and Jaegeuk have no comments yet. Time to talk about the series? https://lore.kernel.org/linux-f2fs-devel/20230112133503.16802-1-frank...@vivo.com/ Thx, Yangtao

[f2fs-dev] [RFC PATCH] f2fs: expand f2fs_compr_option to allow ioctl setting compression level

2023-03-30 Thread Sheng Yong via Linux-f2fs-devel
This patch adds `level` in `struct f2fs_compr_option` to allow ioctl setting compression level. The first byte of original f2fs_compr_option indicates which algorithm is used. While the new f2fs_compr_option splits the first byte into two parts: * the MBS 4 bits indicate the version * the LBS

[f2fs-dev] [PATCH v2] f2fs: support fault injection for f2fs_down_write_trylock()

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
Similar to FAULT_LOCK_OP, this patch supports to inject fault into f2fs_down_write_trylock(). Usage: a) echo 524288 > /sys/fs/f2fs//inject_type or b) mount -o fault_type=524288 Signed-off-by: Yangtao Li --- v2: -remove f2fs_down_write_trylock macro Documentation/ABI/testing/sysfs-fs-f2fs

[f2fs-dev] [PATCH v3] f2fs: add iostat latency statistics support for discard

2023-03-30 Thread Yangtao Li via Linux-f2fs-devel
In this patch, it adds to account discard latency. Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303211005.rgxljvli-...@intel.com/ Signed-off-by: Yangtao Li --- v3: -force conversion to enum iostat_lat_type type v2: -rename get_bio_iostat_private to

Re: [f2fs-dev] [PATCH] f2fs: get out of a repeat loop when getting a locked data page

2023-03-30 Thread Chao Yu
On 2023/3/27 23:30, Jaegeuk Kim wrote: On 03/26, Chao Yu wrote: On 2023/3/24 5:39, Jaegeuk Kim wrote: https://bugzilla.kernel.org/show_bug.cgi?id=216050 Somehow we're getting a page which has a different mapping. Let's avoid the infinite loop. Cc: Signed-off-by: Jaegeuk Kim ---

[f2fs-dev] [Bug 217266] kernel panic on f2fs filesystem when f2fs_commit_atomic_write

2023-03-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217266 --- Comment #4 from michalechne...@googlemail.com --- Am Do., 30. März 2023 um 05:31 Uhr schrieb Chao Yu : > > On 2023/3/30 10:48, bugzilla-dae...@kernel.org wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=217266 > > > > --- Comment #2

Re: [f2fs-dev] [Bug 217266] kernel panic on f2fs filesystem when f2fs_commit_atomic_write

2023-03-30 Thread Micha L via Linux-f2fs-devel
Am Do., 30. März 2023 um 05:31 Uhr schrieb Chao Yu : > > On 2023/3/30 10:48, bugzilla-dae...@kernel.org wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=217266 > > > > --- Comment #2 from shilka (shilk...@gmail.com) --- > > (In reply to michalechner92 from comment #1) > >> That looks