Re: [f2fs-dev] [PATCH v2] f2fs: Fix system crash due to lack of free space in LFS

2023-03-31 Thread Chao Yu
On 2023/3/21 8:12, Yonggil Song wrote: When f2fs tries to checkpoint during foreground gc in LFS mode, system crash occurs due to lack of free space if the amount of dirty node and dentry pages generated by data migration exceeds free space. The reproduction sequence is as follows. - 20GiB

Re: [f2fs-dev] [PATCH] f2fs: fix align check for npo2

2023-03-31 Thread Chao Yu
On 2023/3/24 21:07, Yohan Joung wrote: Fix alignment check to be correct in npo2 as well Signed-off-by: Yohan Joung --- fs/f2fs/segment.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 055e70e77aa2..f4a22a065277 100644

Re: [f2fs-dev] [PATCH 2/2] f2fs: add __pack attribute for extent_info

2023-03-31 Thread Chao Yu
On 2023/3/31 17:26, Bo Ye wrote: From: Qilin Tan Need add __pack for struct extent_info to align to memory layout of struct rb_entry. Jaegeuk has fixed this bug w/ below patchset, please check it: https://lore.kernel.org/linux-f2fs-devel/20230313201216.924234-1-jaeg...@kernel.org/ Thanks,

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix iostat lock protection

2023-03-31 Thread Chao Yu
On 2023/3/31 17:26, Bo Ye wrote: From: Qilin Tan Made iostat lock irq safe to avoid potentinal deadlock. Deadlock scenario: f2fs_attr_store -> f2fs_sbi_store -> _sbi_store -> spin_lock(sbi->iostat_lock) -> scsi_end_request -> bio_endio -> f2fs_dio_read_end_io

Re: [f2fs-dev] f2fs: support fault injection for f2fs_down_write_trylock()

2023-03-31 Thread Yangtao Li via Linux-f2fs-devel
> I guess we can cover all trylock w/ FAULT_LOCK_OP type fault injection, > rather than just cover f2fs_down_write_trylock(). > > Including: > - inode_trylock > - down_read_trylock > - down_write_trylock > - mutex_trylock > - sb_start_write_trylock > - trylock_page > > Bug only excluding

[f2fs-dev] [PATCH v3] f2fs: support fault injection for *_trylock()

2023-03-31 Thread Yangtao Li via Linux-f2fs-devel
This patch extends the fault injection of FAULT_LOCK_OP type, including: - inode_trylock - down_read_trylock - down_write_trylock - mutex_trylock - sb_start_write_trylock - trylock_page Since it supports not only the original lock_op fault injection, let's rename lock_op to lock.

Re: [f2fs-dev] [PATCH 3/7] libfs: Validate negative dentries in case-insensitive directories

2023-03-31 Thread Gabriel Krisman Bertazi
Al Viro writes: > On Wed, Jun 22, 2022 at 03:45:59PM -0400, Gabriel Krisman Bertazi wrote: > >> +static inline int generic_ci_d_revalidate(struct dentry *dentry, >> + const struct qstr *name, >> + unsigned int flags) >> +{

Re: [f2fs-dev] [PATCH v3] f2fs: change the current atomic write way

2023-03-31 Thread Tudor Ambarus
Hi! On 4/28/22 19:18, Daeho Jeong wrote: > From: Daeho Jeong > > Current atomic write has three major issues like below. > - keeps the updates in non-reclaimable memory space and they are even >hard to be migrated, which is not good for contiguous memory >allocation. > - disk spaces

Re: [f2fs-dev] [PATCH v2] f2fs: support fault injection for f2fs_down_write_trylock()

2023-03-31 Thread Chao Yu
On 2023/3/30 23:25, Yangtao Li wrote: Similar to FAULT_LOCK_OP, this patch supports to inject fault into f2fs_down_write_trylock(). I guess we can cover all trylock w/ FAULT_LOCK_OP type fault injection, rather than just cover f2fs_down_write_trylock(). Including: - inode_trylock -

[f2fs-dev] [PATCH] f2fs: convert to use sysfs_emit

2023-03-31 Thread Yangtao Li via Linux-f2fs-devel
Let's use sysfs_emit. Signed-off-by: Yangtao Li --- fs/f2fs/sysfs.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 9ddc6ee19433..2c0b2cb05a3a 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -312,19 +312,13 @@ static

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-03-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #141 from Guido (guido.iod...@gmail.com) --- Today I forced the gc on all partitions. No problem at all. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the

[f2fs-dev] [PATCH 2/2] f2fs: add __pack attribute for extent_info

2023-03-31 Thread Bo Ye via Linux-f2fs-devel
From: Qilin Tan Need add __pack for struct extent_info to align to memory layout of struct rb_entry. struct rb_entry { struct rb_node rb_node; /* rb node located in rb-tree */ union { struct { unsigned int ofs; /* start offset of the entry */

[f2fs-dev] [PATCH 1/2] f2fs: fix iostat lock protection

2023-03-31 Thread Bo Ye via Linux-f2fs-devel
From: Qilin Tan Made iostat lock irq safe to avoid potentinal deadlock. Deadlock scenario: f2fs_attr_store -> f2fs_sbi_store -> _sbi_store -> spin_lock(sbi->iostat_lock) -> scsi_end_request -> bio_endio -> f2fs_dio_read_end_io -> f2fs_update_iostat ->