[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #168 from Matias (lp61...@gmail.com) --- Removed background_gc=sync and it happened again, i hope this message gets sent so you could take a look, this is the journalctl log after it happens. Kernel: 6.3.1 with f2fs updates of

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #167 from Jaegeuk Kim (jaeg...@kernel.org) --- Matias, you saw the issue with the f2fs updates in 6.4-rc1, right? If so, we may need to consider [1] back.. [1]

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 Matias (lp61...@gmail.com) changed: What|Removed |Added CC||lp61...@gmail.com ---

[f2fs-dev] [PATCH] f2fs: close unused open zones while mounting

2023-05-05 Thread Daeho Jeong
From: Daeho Jeong Zoned UFS allows only 6 open zones at the same time, so we need to take care of the count of open zones while mounting. Signed-off-by: Daeho Jeong --- fs/f2fs/segment.c | 53 +++ 1 file changed, 31 insertions(+), 22 deletions(-)

[f2fs-dev] [PATCH] f2fs: fix the wrong condition to determine atomic context

2023-05-05 Thread Jaegeuk Kim
Should use !in_task for irq context. Fixes: 1aa161e43106 ("f2fs: fix scheduling while atomic in decompression path") Signed-off-by: Jaegeuk Kim --- fs/f2fs/compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #165 from Guido (guido.iod...@gmail.com) --- Thank you, for now I'm trying linux-next-git 20230504.r0.g145e5cddfe8b-1 from AUR, it should have the patch already applied. -- You may reply to this email to add a comment. You are

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #164 from Jaegeuk Kim (jaeg...@kernel.org) --- Yup, 6.4-rc1 should have all patches, which is worth giving it a try. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #163 from Guido (guido.iod...@gmail.com) --- To be clear: should I try the patch merged in 6.4-rc1 to 6.3.1 kernel? If so, I prefer to try the kernel 6.4-rc1 instead, with that patche already in place. -- You may reply to this

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #162 from Guido (guido.iod...@gmail.com) --- I'll try ASAP. I tried to patch 6.3.1 with the patches for 6.2.x but fails saying they are already in place. Seeing the code it seems so. -- You may reply to this email to add a comment.

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #161 from Jaegeuk Kim (jaeg...@kernel.org) --- >From Linus tree, could you please try this patch which was merged in 6.4-rc1?

[f2fs-dev] [PATCH] f2fs-tools: allocate memory to handle label

2023-05-05 Thread Jaegeuk Kim
Let's avoid memory alignment of sb->volume_name. Signed-off-by: Jaegeuk Kim --- fsck/main.c| 4 ++-- fsck/mount.c | 4 ++-- include/f2fs_fs.h | 4 ++-- lib/libf2fs.c | 37 - mkfs/f2fs_format.c | 2 +- 5 files changed, 35 insertions(+),

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-05-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #160 from Guido (guido.iod...@gmail.com) --- After several weeks, no problem. I also foced gc now with no problem. Now I would like to swith to kernel 6.3, what patch I should use? -- You may reply to this email to add a comment.

[f2fs-dev] [PATCH] f2fs: maintain six open zones for zoned devices

2023-05-05 Thread Jaegeuk Kim
From: Daeho Jeong To keep six open zone constraints, make them not to be open over six open zones. Signed-off-by: Daeho Jeong Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 57 ++ fs/f2fs/f2fs.h | 5 + 2 files changed, 62 insertions(+)

Re: [f2fs-dev] [PATCH] f2fs_io: support move_range command

2023-05-05 Thread Chao Yu
On 2023/5/4 22:44, Yangtao Li wrote: This patch supports a new sub-command 'move_range' in f2fs_io to move a range of data blocks from source file to destination file via F2FS_IOC_MOVE_RANGE ioctl. Signed-off-by: Yangtao Li --- man/f2fs_io.8 | 4 tools/f2fs_io/f2fs_io.c | 35

Re: [f2fs-dev] [PATCH] f2fs: fix to call invalidate_mapping_pages in f2fs_move_file_range

2023-05-05 Thread Chao Yu
On 2023/5/5 2:52, Yangtao Li wrote: In the following scenario, after executing the move_range ioctl syscall, the block size of the source file is 0, but data can still be read. # stat test File: test Size: 6 Blocks: 8 IO Block: 4096 regular file #

Re: [f2fs-dev] [PATCH] fsck.f2fs: Detect looped node chain more efficiently.

2023-05-05 Thread Chao Yu
On 2023/5/4 11:30, Chunhai Guo wrote: Now we detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make it more efficient. Below is the log we

Re: [f2fs-dev] [PATCH v5] f2fs: add async reset zone command support

2023-05-05 Thread Chao Yu
On 2023/5/4 11:26, Daejun Park wrote: v4 -> v5 Added f2fs iostat for zone reset command. v3 -> v4 Fixed build error caused by unused function. v2 -> v3 Modified arguments to be correct for ftrace parameter. Changed __submit_zone_reset_cmd to void return. Refactored the f2fs_wait_discard_bio

[f2fs-dev] [PATCH 3/6] f2fs-tools: fix typo in f2fs_inode structure

2023-05-05 Thread Chao Yu
:%s/i_compress_algrithm/i_compress_algorithm/g Signed-off-by: Chao Yu --- fsck/mount.c | 2 +- fsck/segment.c | 2 +- include/f2fs_fs.h | 2 +- mkfs/f2fs_format.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c index

[f2fs-dev] [PATCH 2/6] f2fs-tools: rename i_padding to i_compress_flag

2023-05-05 Thread Chao Yu
Commit b28f047b28c5 ("f2fs: compress: support chksum") renames i_padding to i_compress_flag in struct f2fs_inode, adjust f2fs-tools' codes as well. Signed-off-by: Chao Yu --- fsck/mount.c | 2 +- include/f2fs_fs.h | 5 - mkfs/f2fs_format.c | 4 ++-- 3 files changed, 7 insertions(+),

[f2fs-dev] [PATCH 6/6] f2fs-tools: use f2fs_init_inode() to clean up codes

2023-05-05 Thread Chao Yu
No logic changes. Signed-off-by: Chao Yu --- fsck/node.c| 7 ++- include/f2fs_fs.h | 36 +- mkfs/f2fs_format.c | 118 - 3 files changed, 50 insertions(+), 111 deletions(-) diff --git a/fsck/node.c b/fsck/node.c index

[f2fs-dev] [PATCH 1/6] f2fs-tools: add packed attribute for struct f2fs_super_block

2023-05-05 Thread Chao Yu
Otherwise, it may trigger static assert below when the structure updates. static_assert(sizeof(struct f2fs_super_block) == 3072, "") Signed-off-by: Chao Yu --- include/f2fs_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index

[f2fs-dev] [PATCH 5/6] f2fs-tools: print more raw sb info

2023-05-05 Thread Chao Yu
Output is as below: magic [0xf2f52010 : 4076150800] major_ver [0x 1 : 1] minor_ver [0x 10 : 16] log_sectorsize [0x 9 : 9] log_sectors_per_block

[f2fs-dev] [PATCH 4/6] f2fs-tools: add DISP_u8() macro

2023-05-05 Thread Chao Yu
Introduce DISP_u8(), and use DISP_u16() and DISP_u8() to print below fields: - i_compress_algorithm - i_log_cluster_size - i_compress_flag Signed-off-by: Chao Yu --- fsck/mount.c | 6 +++--- include/f2fs_fs.h | 11 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git