[f2fs-dev] [PATCH v3] f2fs: fix to avoid mmap vs set_compress_option case

2023-07-05 Thread Chao Yu
Compression option in inode should not be changed after they have been used, however, it may happen in below race case: Thread AThread B - f2fs_ioc_set_compress_option - check f2fs_is_mmap_file() - check get_dirty_pages() - check F2FS_HAS_BLOCKS()

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-05 Thread Chao Yu
On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote: If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim.

Re: [f2fs-dev] [PATCH 01/13] iomap: update ki_pos a little later in iomap_dio_complete

2023-07-05 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Andrew Morton : On Fri, 19 May 2023 11:35:09 +0200 you wrote: > Move the ki_pos update down a bit to prepare for a better common > helper that invalidates pages based of an iocb. > > Signed-off-by: Christoph Hellwig > --- >

Re: [f2fs-dev] [PATCH 01/17] fs: unexport buffer_check_dirty_writeback

2023-07-05 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jens Axboe : On Mon, 24 Apr 2023 07:49:10 +0200 you wrote: > buffer_check_dirty_writeback is only used by the block device aops, > remove the export. > > Signed-off-by: Christoph Hellwig > --- > fs/buffer.c | 1 - > 1 file changed, 1

[f2fs-dev] Patchwork summary for: f2fs

2023-07-05 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: [f2fs-dev,01/12] backing_dev: remove current->backing_dev_info Submitter: Christoph Hellwig Committer: Andrew Morton Patchwork:

Re: [f2fs-dev] [GIT PULL] f2fs update for 6.5

2023-07-05 Thread patchwork-bot+f2fs
Hello: This pull request was applied to jaegeuk/f2fs.git (dev) by Linus Torvalds : On Wed, 5 Jul 2023 10:54:07 -0700 you wrote: > Hi Linus, > > Could you please consider this pull request? > > Thank you. > > The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: > >

Re: [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories

2023-07-05 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Christian Brauner : On Thu, 1 Jun 2023 12:58:20 +0200 you wrote: > Hello, > > this patch set fixes a problem with cross directory renames originally > reported > in [1]. To quickly sum it up some filesystems (so far we know at least

Re: [f2fs-dev] [PATCH v21 19/30] f2fs: Provide a splice-read stub

2023-07-05 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jens Axboe : On Sat, 20 May 2023 01:00:38 +0100 you wrote: > Provide a splice_read stub for f2fs. This does some checks and tracing > before calling filemap_splice_read() and will update the iostats > afterwards. Direct I/O is handled

Re: [f2fs-dev] [PATCH v22 19/31] f2fs: Provide a splice-read wrapper

2023-07-05 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jens Axboe : On Mon, 22 May 2023 14:50:06 +0100 you wrote: > Provide a splice_read wrapper for f2fs. This does some checks and tracing > before calling filemap_splice_read() and will update the iostats > afterwards. Direct I/O is

Re: [f2fs-dev] [PATCH 01/12] backing_dev: remove current->backing_dev_info

2023-07-05 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Andrew Morton : On Thu, 1 Jun 2023 16:58:53 +0200 you wrote: > The last user of current->backing_dev_info disappeared in commit > b9b1335e6403 ("remove bdi_congested() and wb_congested() and related > functions"). Remove the field and

Re: [f2fs-dev] [PATCH 01/30] block: also call ->open for incremental partition opens

2023-07-05 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jens Axboe : On Thu, 8 Jun 2023 13:02:29 +0200 you wrote: > For whole devices ->open is called for each open, but for partitions it > is only called on the first open of a partition, e.g.: > > open("/dev/vdb", ...) >

Re: [f2fs-dev] [PATCH v2] fsverity: use shash API instead of ahash API

2023-07-05 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Eric Biggers : On Mon, 15 May 2023 22:23:06 -0700 you wrote: > From: Eric Biggers > > The "ahash" API, like the other scatterlist-based crypto APIs such as > "skcipher", comes with some well-known limitations. First, it can't > easily

Re: [f2fs-dev] [PATCH v2 08/92] fs: new helper: simple_rename_timestamp

2023-07-05 Thread Jeff Layton
On Thu, 2023-07-06 at 08:19 +0900, Damien Le Moal wrote: > On 7/6/23 03:58, Jeff Layton wrote: > > A rename potentially involves updating 4 different inode timestamps. Add > > a function that handles the details sanely, and convert the libfs.c > > callers to use it. > > > > Signed-off-by: Jeff

Re: [f2fs-dev] [PATCH v2 92/92] fs: rename i_ctime field to __i_ctime

2023-07-05 Thread Damien Le Moal
On 7/6/23 03:58, Jeff Layton wrote: > Now that everything in-tree is converted to use the accessor functions, > rename the i_ctime field in the inode to discourage direct access. > > Signed-off-by: Jeff Layton Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital

Re: [f2fs-dev] [PATCH v2 08/92] fs: new helper: simple_rename_timestamp

2023-07-05 Thread Damien Le Moal
On 7/6/23 03:58, Jeff Layton wrote: > A rename potentially involves updating 4 different inode timestamps. Add > a function that handles the details sanely, and convert the libfs.c > callers to use it. > > Signed-off-by: Jeff Layton > --- > fs/libfs.c | 36

Re: [f2fs-dev] [PATCH v2 07/92] fs: add ctime accessors infrastructure

2023-07-05 Thread Damien Le Moal
On 7/6/23 03:58, Jeff Layton wrote: > struct timespec64 has unused bits in the tv_nsec field that can be used > for other purposes. In future patches, we're going to change how the > inode->i_ctime is accessed in certain inodes in order to make use of > them. In order to do that safely though,

Re: [f2fs-dev] [PATCH v2 00/89] fs: new accessors for inode->i_ctime

2023-07-05 Thread Jeff Layton
sent me an Acked-by or Reviewed-by in the previous set, then I tried to keep it on the patch here, since the respun patches are mostly just renaming stuff from v1. Let me know if I've missed any. I've also pushed the pile to my tree as this tag: https://git.kernel.org/pub/scm/linux/kernel/git/j

[f2fs-dev] [PATCH 1/2] fsverity: simplify handling of errors during initcall

2023-07-05 Thread Eric Biggers
From: Eric Biggers Since CONFIG_FS_VERITY is a bool, not a tristate, fs/verity/ can only be builtin or absent entirely; it can't be a loadable module. Therefore, the error code that gets returned from the fsverity_init() initcall is never used. If any part of the initcall does fail, which

[f2fs-dev] [PATCH 0/2] fsverity: simplify initcall and move sysctl registration

2023-07-05 Thread Eric Biggers
This series simplifies handling of errors during the fsverity_init() initcall, and moves the sysctl registration out of signature.c so that it is not unnecessarily tied to the builtin signature feature. Eric Biggers (2): fsverity: simplify handling of errors during initcall fsverity: move

[f2fs-dev] [PATCH 2/2] fsverity: move sysctl registration out of signature.c

2023-07-05 Thread Eric Biggers
From: Eric Biggers Currently the registration of the fsverity sysctls happens in signature.c, which couples it to CONFIG_FS_VERITY_BUILTIN_SIGNATURES. This makes it hard to add new sysctls unrelated to builtin signatures. Also, some users have started checking whether the directory

Re: [f2fs-dev] [GIT PULL] f2fs update for 6.5

2023-07-05 Thread pr-tracker-bot
The pull request you sent on Wed, 5 Jul 2023 10:54:07 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > tags/f2fs-for-6.5-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/73a3fcdaa73200e38e38f7e8a32c9b901c5b95b5 Thank you! --

[f2fs-dev] [PATCH v2 43/92] f2fs: convert to ctime accessor functions

2023-07-05 Thread Jeff Layton
In later patches, we're going to change how the inode's ctime field is used. Switch to using accessor functions instead of raw accesses of inode->i_ctime. Signed-off-by: Jeff Layton --- fs/f2fs/dir.c | 8 fs/f2fs/f2fs.h | 4 +++- fs/f2fs/file.c | 20 ++--

[f2fs-dev] [PATCH v2 92/92] fs: rename i_ctime field to __i_ctime

2023-07-05 Thread Jeff Layton
Now that everything in-tree is converted to use the accessor functions, rename the i_ctime field in the inode to discourage direct access. Signed-off-by: Jeff Layton --- include/linux/fs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/fs.h

[f2fs-dev] [PATCH v2 07/92] fs: add ctime accessors infrastructure

2023-07-05 Thread Jeff Layton
struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is accessed in certain inodes in order to make use of them. In order to do that safely though, we'll need to eradicate raw accesses of the

[f2fs-dev] [PATCH v2 08/92] fs: new helper: simple_rename_timestamp

2023-07-05 Thread Jeff Layton
A rename potentially involves updating 4 different inode timestamps. Add a function that handles the details sanely, and convert the libfs.c callers to use it. Signed-off-by: Jeff Layton --- fs/libfs.c | 36 +++- include/linux/fs.h | 2 ++ 2 files

[f2fs-dev] [PATCH v2 00/89] fs: new accessors for inode->i_ctime

2023-07-05 Thread Jeff Layton
v2: - prepend patches to add missing ctime updates - add simple_rename_timestamp helper function - rename ctime accessor functions as inode_get_ctime/inode_set_ctime_* - drop individual inode_ctime_set_{sec,nsec} helpers I've been working on a patchset to change how the inode->i_ctime is accessed

[f2fs-dev] [GIT PULL] f2fs update for 6.5

2023-07-05 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thank you. The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-05 Thread Jaegeuk Kim
On 07/04, Chao Yu wrote: > On 2023/7/4 18:53, Jaegeuk Kim wrote: > > On 07/03, Chao Yu wrote: > > > On 2023/6/15 0:10, Jaegeuk Kim wrote: > > > > If there're huge # of small discards, this will increase checkpoint > > > > latency > > > > insanely. Let's issue small discards only by trim. > > > >

Re: [f2fs-dev] [PATCH 01/32] block: Provide blkdev_get_handle_* functions

2023-07-05 Thread Jan Kara
On Tue 04-07-23 07:06:26, Bart Van Assche wrote: > On 7/4/23 05:21, Jan Kara wrote: > > +struct bdev_handle { > > + struct block_device *bdev; > > + void *holder; > > +}; > > Please explain in the patch description why a holder pointer is introduced > in struct bdev_handle and how it relates

Re: [f2fs-dev] [PATCH 01/32] block: Provide blkdev_get_handle_* functions

2023-07-05 Thread Bart Van Assche
On 7/4/23 09:14, Matthew Wilcox wrote: On Tue, Jul 04, 2023 at 07:06:26AM -0700, Bart Van Assche wrote: On 7/4/23 05:21, Jan Kara wrote: +struct bdev_handle { + struct block_device *bdev; + void *holder; +}; Please explain in the patch description why a holder pointer is

Re: [f2fs-dev] [PATCH 01/32] block: Provide blkdev_get_handle_* functions

2023-07-05 Thread Jan Kara
On Tue 04-07-23 10:28:36, Keith Busch wrote: > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > > + void *holder, const struct blk_holder_ops *hops) > > +{ > > + struct bdev_handle *handle =

[f2fs-dev] [PATCH v2] f2fs: including waf data in f2fs status information

2023-07-05 Thread beomsu kim
When evaluating in f2fs, it takes much time to obtain waf data. This patch helps to obtain waf data without calcluation. Signed-off-by: Beomsu Kim --- fs/f2fs/iostat.c | 17 + 1 file changed, 17 insertions(+) diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c index