Re: [f2fs-dev] circular locking dependency warning in f2fs

2023-08-21 Thread Guenter Roeck
On Mon, Aug 21, 2023 at 12:37:12PM -0700, Jaegeuk Kim wrote: > On 08/18, Guenter Roeck wrote: > > On Fri, Aug 18, 2023 at 05:35:25PM -0700, Jaegeuk Kim wrote: > > > May I know if this works? > > > > > > https://lore.kernel.org/linux-f2fs-devel/20230819003012.3473675-1-jaeg...@kernel.org/T/#u > >

Re: [f2fs-dev] [PATCH 1/2] f2fs: doc: fix description of max_small_discards

2023-08-21 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Sun, 30 Jul 2023 22:25:51 +0800 you wrote: > The description of max_small_discards is out-of-update in below two > aspects, fix it. > - it is disabled by default > - small discards will be issued during checkpoint > >

Re: [f2fs-dev] [PATCH] f2fs: avoid false alarm of circular locking

2023-08-21 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 18 Aug 2023 17:30:12 -0700 you wrote: > == > WARNING: possible circular locking dependency detected > 6.5.0-rc5-syzkaller-00353-gae545c3283dc #0 Not tainted >

[f2fs-dev] Patchwork summary for: f2fs

2023-08-21 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: [f2fs-dev,1/2] f2fs: doc: fix description of max_small_discards Submitter: Chao Yu Committer: Jaegeuk Kim Patchwork:

Re: [f2fs-dev] circular locking dependency warning in f2fs

2023-08-21 Thread Jaegeuk Kim
On 08/18, Guenter Roeck wrote: > On Fri, Aug 18, 2023 at 05:35:25PM -0700, Jaegeuk Kim wrote: > > May I know if this works? > > > > https://lore.kernel.org/linux-f2fs-devel/20230819003012.3473675-1-jaeg...@kernel.org/T/#u > > > > Yes, that fixes the problem for me. That makes me wonder, though:

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-08-21 Thread Gabriel Krisman Bertazi
Christian Brauner writes: > On Thu, Aug 17, 2023 at 10:06:58AM -0700, Eric Biggers wrote: >> On Wed, Aug 16, 2023 at 01:07:54AM -0400, Gabriel Krisman Bertazi wrote: >> > Hi, >> > >> > This is v6 of the negative dentry on case-insensitive directories. >> > Thanks Eric for the review of the last

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-08-21 Thread Christian Brauner
On Thu, Aug 17, 2023 at 10:06:58AM -0700, Eric Biggers wrote: > On Wed, Aug 16, 2023 at 01:07:54AM -0400, Gabriel Krisman Bertazi wrote: > > Hi, > > > > This is v6 of the negative dentry on case-insensitive directories. > > Thanks Eric for the review of the last iteration. This version > > drops

[f2fs-dev] [PATCH 3/3] f2fs: compress: fix to assign compress_level for lz4 correctly

2023-08-21 Thread Chao Yu
After remount, F2FS_OPTION().compress_level was assgin to LZ4HC_DEFAULT_CLEVEL incorrectly, result in lz4hc:9 was enabled, fix it. 1. mount /dev/vdb /dev/vdb on /mnt/f2fs type f2fs (...,compress_algorithm=lz4,compress_log_size=2,...) 2. mount -t f2fs -o remount,compress_log_size=3 /mnt/f2fs/ 3.

[f2fs-dev] [PATCH 1/3] f2fs: clean up error handling in sanity_check_{compress_, }inode()

2023-08-21 Thread Chao Yu
In sanity_check_{compress_,}inode(), it doesn't need to set SBI_NEED_FSCK in each error case, instead, we can set the flag in do_read_inode() only once when sanity_check_inode() fails. Signed-off-by: Chao Yu --- fs/f2fs/inode.c | 23 --- 1 file changed, 4 insertions(+), 19

[f2fs-dev] [PATCH 2/3] f2fs: fix error path of f2fs_submit_page_read()

2023-08-21 Thread Chao Yu
In error path of f2fs_submit_page_read(), it missed to call iostat_update_and_unbind_ctx() and free bio_post_read_ctx, fix it. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 5d9697717353..916e317ac925 100644

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2023-08-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #181 from Guido (guido.iod...@gmail.com) --- The fact that dirty segments don't go below 1 suggests that the bug is not completely fixed even with this patch. This is unfortunate because the 5.15 kernel, which is not affected by