Re: [f2fs-dev] [PATCH v1] f2fs: fix max open zone constraints

2024-01-16 Thread Wenjie Qi
Do you mean we down the semaphore when we write the first block of the zone and up it when the last bio of the zone finishes? That seems a bit more concise. On Wed, Jan 17, 2024 at 7:12 AM Daeho Jeong wrote: > > On Tue, Jan 16, 2024 at 2:58 PM Daeho Jeong wrote: > > > > On Tue, Jan 16, 2024 at

Re: [f2fs-dev] [PATCH v1] f2fs: fix NULL pointer dereference in f2fs_submit_page_write()

2024-01-16 Thread Wenjie Qi
Hello Daeho, I don't think moving just the "out" label will work. If a fio is zone end and in_list = 1, that fio is missed without being judged. On Wed, Jan 17, 2024 at 5:58 AM Daeho Jeong wrote: > > On Tue, Jan 16, 2024 at 6:13 AM Wenjie Qi wrote: > > > > BUG: kernel NULL pointer dereference,

Re: [f2fs-dev] [PATCH v1] f2fs: fix max open zone constraints

2024-01-16 Thread Daeho Jeong
On Tue, Jan 16, 2024 at 2:58 PM Daeho Jeong wrote: > > On Tue, Jan 16, 2024 at 6:36 AM Wenjie Qi wrote: > > > > We can get the number of remaining available zone > > resources by subtracting the number of active logs from > > the number of max active zones of zoned devices. We can > > use these

Re: [f2fs-dev] [PATCH v1] f2fs: fix max open zone constraints

2024-01-16 Thread Daeho Jeong
On Tue, Jan 16, 2024 at 6:36 AM Wenjie Qi wrote: > > We can get the number of remaining available zone > resources by subtracting the number of active logs from > the number of max active zones of zoned devices. We can > use these available zone resources to reduce the number > of pending bio

Re: [f2fs-dev] [PATCH v1] f2fs: fix NULL pointer dereference in f2fs_submit_page_write()

2024-01-16 Thread Daeho Jeong
On Tue, Jan 16, 2024 at 6:13 AM Wenjie Qi wrote: > > BUG: kernel NULL pointer dereference, address: 0014 > RIP: 0010:f2fs_submit_page_write+0x6cf/0x780 [f2fs] > Call Trace: > > ? show_regs+0x6e/0x80 > ? __die+0x29/0x70 > ? page_fault_oops+0x154/0x4a0 > ? prb_read_valid+0x20/0x30 > ?

[f2fs-dev] Patchwork summary for: f2fs

2024-01-16 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: [f2fs-dev,1/5] virtio_blk: cleanup zoned device probing Submitter: Christoph Hellwig Committer: Jens Axboe Patchwork:

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2024-01-16 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Gabriel Krisman Bertazi : On Wed, 16 Aug 2023 01:07:54 -0400 you wrote: > Hi, > > This is v6 of the negative dentry on case-insensitive directories. > Thanks Eric for the review of the last iteration. This version > drops the patch to

Re: [f2fs-dev] [PATCH 1/5] virtio_blk: cleanup zoned device probing

2024-01-16 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jens Axboe : On Sun, 17 Dec 2023 17:53:55 +0100 you wrote: > Move reading and checking the zoned model from virtblk_probe_zoned_device > into the caller, leaving only the code to perform the actual setup for > host managed zoned devices

Re: [f2fs-dev] [GIT PULL] f2fs update for 6.8-rc1

2024-01-16 Thread patchwork-bot+f2fs
Hello: This pull request was applied to jaegeuk/f2fs.git (dev) by Linus Torvalds : On Thu, 11 Jan 2024 10:28:10 -0800 you wrote: > Hi Linus, > > Happy new year! > > Could you please consider this pull request? > > Thank you. > > [...] Here is the summary with links: - [f2fs-dev,GIT,PULL]

Re: [f2fs-dev] [PATCH v2 0/2] Move fscrypt keyring destruction to after ->put_super

2024-01-16 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Eric Biggers : On Wed, 27 Dec 2023 11:14:27 -0600 you wrote: > This series moves the fscrypt keyring destruction to after ->put_super, > as this will be needed by the btrfs fscrypt support. To make this > possible, it also changes f2fs

Re: [f2fs-dev] [PATCH] f2fs: compress: fix to cover f2fs_disable_compressed_file() w/ i_sem

2024-01-16 Thread Jaegeuk Kim
On 01/11, Chao Yu wrote: > - f2fs_disable_compressed_file > - check inode_has_data > - f2fs_file_mmap > - mkwrite >- f2fs_get_block_locked >

[f2fs-dev] [PATCH v1] f2fs: fix max open zone constraints

2024-01-16 Thread Wenjie Qi
We can get the number of remaining available zone resources by subtracting the number of active logs from the number of max active zones of zoned devices. We can use these available zone resources to reduce the number of pending bio when switching zones. If max active zones is 0, there is no

[f2fs-dev] [Bug 218349] f2fs partitions corrupted during power failures and cannot be fixed with fsck.

2024-01-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218349 Chao Yu (c...@kernel.org) changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[f2fs-dev] [PATCH] fsck.f2fs: fix to avoid assert in do_record_fsync_data()

2024-01-16 Thread Chao Yu
As Kane Ch'in reported in bugzilla [1] I am using some Debian VMs with f2fs root partition for development. My host machine crashed for some reason and this caused the f2fs partitions in the VMs to become corrupted. I tried to boot from Debian Live and repair the partitions but failed.

[f2fs-dev] [PATCH v1] f2fs: fix NULL pointer dereference in f2fs_submit_page_write()

2024-01-16 Thread Wenjie Qi
BUG: kernel NULL pointer dereference, address: 0014 RIP: 0010:f2fs_submit_page_write+0x6cf/0x780 [f2fs] Call Trace: ? show_regs+0x6e/0x80 ? __die+0x29/0x70 ? page_fault_oops+0x154/0x4a0 ? prb_read_valid+0x20/0x30 ? __irq_work_queue_local+0x39/0xd0 ? irq_work_queue+0x36/0x70 ?

[f2fs-dev] [PATCH v2] f2fs: fix zoned block device information initialization

2024-01-16 Thread Wenjie Qi
If the max active zones of zoned devices are less than the active logs of F2FS, the device may error due to insufficient zone resources when multiple active logs are being written at the same time. If this value is 0, there is no limit. Signed-off-by: Wenjie Qi --- fs/f2fs/f2fs.h | 1 +