Re: [f2fs-dev] [PATCH v3] f2fs: reduce expensive checkpoint trigger frequency

2024-03-04 Thread Zhiguo Niu
Sorry, move jaegeuk to the "To" list Dear Jaegeuk, Let me describe the problem process, it is reproduced by monkey stability test: 1.SBI_NEED_CP flag bit is set, set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP); 2.Ckpt thread is blocked by IO busy when it is doing CP, it can not get request

Re: [f2fs-dev] [PATCH v3] f2fs: reduce expensive checkpoint trigger frequency

2024-03-04 Thread Zhiguo Niu
Dear Jaegeuk, Let me describe the problem process, it is reproduced by monkey stability test: 1.SBI_NEED_CP flag bit is set, set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP); 2.Ckpt thread is blocked by IO busy when it is doing CP, it can not get request tag from block queue, PID: 505

[f2fs-dev] [PATCH] f2fs: add a proc entry show disk map

2024-03-04 Thread Jaegeuk Kim
This patch adds the disk map of block address ranges configured by multiple partitions. Signed-off-by: Jaegeuk Kim --- fs/f2fs/sysfs.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 10f308b3128f..e81af6adb85b 100644 ---

Re: [f2fs-dev] [PATCH 1/4] f2fs: fix blkofs_end correctly in f2fs_migrate_blocks()

2024-03-04 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 26 Feb 2024 09:32:05 +0800 you wrote: > In f2fs_migrate_blocks(), when traversing blocks in last section, > blkofs_end should be (start_blk + blkcnt - 1) % blk_per_sec, fix it. > > Signed-off-by: Chao Yu > --- >

Re: [f2fs-dev] [PATCH] f2fs: fix to check return value in f2fs_insert_range()

2024-03-04 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 26 Feb 2024 11:19:16 +0800 you wrote: > In f2fs_insert_range(), it missed to check return value of > filemap_write_and_wait_range(), fix it. > > Meanwhile, just return error number once __exchange_data_block() >

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to check return value __allocate_new_segment

2024-03-04 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 1 Mar 2024 16:25:54 +0800 you wrote: > __allocate_new_segment may return error when get_new_segment > fails, so its caller should check its return value. > > Signed-off-by: Zhiguo Niu > --- > fs/f2fs/f2fs.h

[f2fs-dev] Patchwork summary for: f2fs

2024-03-04 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev,v2] f2fs: introduce SEGS_TO_BLKS/BLKS_TO_SEGS for cleanup Submitter: Chao Yu Committer: Jaegeuk Kim Patchwork:

Re: [f2fs-dev] [PATCH] f2fs: fix to do sanity check in update_sit_entry

2024-03-04 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 28 Feb 2024 19:59:54 +0800 you wrote: > If GET_SEGNO return NULL_SEGNO for some unecpected case, > update_sit_entry will access invalid memory address, > cause system crash. It is better to do sanity check about >

Re: [f2fs-dev] [PATCH v2] f2fs: fix to use correct segment type in f2fs_allocate_data_block()

2024-03-04 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Sun, 25 Feb 2024 14:36:28 +0800 you wrote: > @type in f2fs_allocate_data_block() indicates log header's type, it > can be CURSEG_COLD_DATA_PINNED or CURSEG_ALL_DATA_ATGC, rather than > type of data/node, however

Re: [f2fs-dev] [PATCH v2] f2fs: introduce SEGS_TO_BLKS/BLKS_TO_SEGS for cleanup

2024-03-04 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 4 Mar 2024 11:28:55 +0800 you wrote: > Just cleanup, no functional change. > > Signed-off-by: Chao Yu > --- > v2: > - don't cast type of segment number from unsigned int > to long long, because segs <<

Re: [f2fs-dev] [PATCH 1/2] f2fs: ro: compress: fix to avoid caching unaligned extent

2024-03-04 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 26 Feb 2024 15:35:38 +0800 you wrote: > Mapping info from dump.f2fs: > i_addr[0x2d] cluster flag [0xfffe : 4294967294] > i_addr[0x2e] [0x 10428 : 66600] > i_addr[0x2f]

Re: [f2fs-dev] [PATCH 3/5] f2fs: print zone status in string and some log

2024-03-04 Thread Jaegeuk Kim
On 02/23, Jaegeuk Kim wrote: > No functional change, but add some more logs. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/segment.c | 34 -- > fs/f2fs/super.c | 1 + > 2 files changed, 25 insertions(+), 10 deletions(-) > > diff --git a/fs/f2fs/segment.c

[f2fs-dev] [PATCH] f2fs: fix to remove f2fs_bug_on in add_bio_entry

2024-03-04 Thread Zhiguo Niu
add_bio_entry should not trigger system panic when bio_add_page fail, fix to remove it. Fixes: 0b20fcec8651 ("f2fs: cache global IPU bio") Signed-off-by: Zhiguo Niu --- fs/f2fs/data.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index

Re: [f2fs-dev] [PATCH] f2fs: fix to check result of new_curseg in f2fs_allocate_segment_for_resize

2024-03-04 Thread Zhiguo Niu
On Mon, Mar 4, 2024 at 5:19 PM Chao Yu wrote: > > On 2024/3/4 15:52, Zhiguo Niu wrote: > > On Mon, Mar 4, 2024 at 3:17 PM Chao Yu wrote: > >> > >> On 2024/3/4 11:33, Zhiguo Niu wrote: > >>> On Mon, Mar 4, 2024 at 11:19 AM Chao Yu wrote: > > On 2024/3/1 19:36, Zhiguo Niu wrote: > >

Re: [f2fs-dev] [PATCH] f2fs: fix to check result of new_curseg in f2fs_allocate_segment_for_resize

2024-03-04 Thread Chao Yu
On 2024/3/4 15:52, Zhiguo Niu wrote: On Mon, Mar 4, 2024 at 3:17 PM Chao Yu wrote: On 2024/3/4 11:33, Zhiguo Niu wrote: On Mon, Mar 4, 2024 at 11:19 AM Chao Yu wrote: On 2024/3/1 19:36, Zhiguo Niu wrote: new_curseg may return error if get_new_segment fail, so its result should be check