Re: [f2fs-dev] [bug report]WARNING: CPU: 22 PID: 44011 at fs/iomap/iter.c:51 iomap_iter+0x32b observed with blktests zbd/010

2024-03-11 Thread Shinichiro Kawasaki via Linux-f2fs-devel
On Mar 01, 2024 / 15:49, Yi Zhang wrote: > On Wed, Feb 28, 2024 at 8:08 PM Yi Zhang wrote: > > > > On Wed, Feb 28, 2024 at 7:09 PM Shinichiro Kawasaki > > wrote: > > > > > > On Feb 19, 2024 / 00:58, Yi Zhang wrote: > > > > Hello > > > > I reproduced this issue on the latest linux-block/for-next,

Re: [f2fs-dev] [PATCH 2/2] f2fs: prevent writing without fallocate() for pinned files

2024-03-11 Thread Chao Yu
On 2024/3/12 7:59, Daeho Jeong wrote: From: Daeho Jeong In a case writing without fallocate(), we can't guarantee it's allocated in the conventional area for zoned stroage. Signed-off-by: Daeho Jeong --- fs/f2fs/data.c | 7 +++ fs/f2fs/file.c | 4 2 files changed, 11

Re: [f2fs-dev] [PATCH 1/2] f2fs: prevent atomic write on pinned file

2024-03-11 Thread Chao Yu
On 2024/3/12 7:59, Daeho Jeong wrote: From: Daeho Jeong Since atomic write way was changed to out-place-update, we should prevent it on pinned files. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list

Re: [f2fs-dev] [PATCH] f2fs: support .shutdown in f2fs_sops

2024-03-11 Thread Chao Yu
Ping, On 2024/2/29 22:38, Chao Yu wrote: Support .shutdown callback in f2fs_sops, then, it can be called to shut down the file system when underlying block device is marked dead. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/file.c | 70

Re: [f2fs-dev] [PATCH] f2fs: fix to return EIO when reading after device removal

2024-03-11 Thread Chao Yu
Ping, Jaegeuk, do you have any comments on this patch? Thanks, On 2024/2/26 16:00, Chao Yu wrote: Any comments? Thanks, On 2024/2/19 11:13, Chao Yu wrote: On 2024/2/8 8:18, Jaegeuk Kim wrote: On 02/06, Chao Yu wrote: generic/730 2s ... - output mismatch (see

[f2fs-dev] [PATCH 2/2] f2fs: prevent writing without fallocate() for pinned files

2024-03-11 Thread Daeho Jeong
From: Daeho Jeong In a case writing without fallocate(), we can't guarantee it's allocated in the conventional area for zoned stroage. Signed-off-by: Daeho Jeong --- fs/f2fs/data.c | 7 +++ fs/f2fs/file.c | 4 2 files changed, 11 insertions(+) diff --git a/fs/f2fs/data.c

[f2fs-dev] [PATCH 1/2] f2fs: prevent atomic write on pinned file

2024-03-11 Thread Daeho Jeong
From: Daeho Jeong Since atomic write way was changed to out-place-update, we should prevent it on pinned files. Signed-off-by: Daeho Jeong --- fs/f2fs/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 1c044fb19c87..82277e95c88f

Re: [f2fs-dev] [PATCH] f2fs: Cast expression type to unsigned long in __count_extent_cache()

2024-03-11 Thread David Laight
From: Jaegeuk Kim > Sent: 11 March 2024 20:37 > On 03/10, David Laight wrote: > > From: Roman Smirnov > > > Sent: 05 March 2024 08:10 > > > > > > Cast expression type to unsigned long in __count_extent_cache() > > > to prevent integer overflow. > > > > > > Found by Linux Verification Center

Re: [f2fs-dev] [PATCH] f2fs: Cast expression type to unsigned long in __count_extent_cache()

2024-03-11 Thread Jaegeuk Kim
On 03/10, David Laight wrote: > From: Roman Smirnov > > Sent: 05 March 2024 08:10 > > > > Cast expression type to unsigned long in __count_extent_cache() > > to prevent integer overflow. > > > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Another broken analysis tool

Re: [f2fs-dev] [PATCH V2 2/2] f2fs: fix to handle error paths of {new, change}_curseg()

2024-03-11 Thread Chao Yu
On 2024/3/11 15:48, Zhiguo Niu wrote: {new,change}_curseg() may return error in some special cases, error handling should be did in their callers, and this will also facilitate subsequent error path expansion in {new,change}_curseg(). Signed-off-by: Zhiguo Niu Signed-off-by: Chao Yu

[f2fs-dev] [PATCH V2 2/2] f2fs: fix to handle error paths of {new, change}_curseg()

2024-03-11 Thread Zhiguo Niu
{new,change}_curseg() may return error in some special cases, error handling should be did in their callers, and this will also facilitate subsequent error path expansion in {new,change}_curseg(). Signed-off-by: Zhiguo Niu Signed-off-by: Chao Yu --- v2: remove the part that are irrelevant to

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to remove f2fs_bug_on in add_bio_entry

2024-03-11 Thread Zhiguo Niu
On Mon, Mar 11, 2024 at 11:54 AM Chao Yu wrote: > > On 2024/3/8 18:12, Zhiguo Niu wrote: > > add_bio_entry should not trigger system panic when bio_add_page fail, > > fix to remove it. > > > > Fixes: 0b20fcec8651 ("f2fs: cache global IPU bio") > > Signed-off-by: Zhiguo Niu > > --- > >

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to handle error paths of {new, change}_curseg()

2024-03-11 Thread Zhiguo Niu
On Mon, Mar 11, 2024 at 2:09 PM Chao Yu wrote: > > On 2024/3/8 18:12, Zhiguo Niu wrote: > > {new,change}_curseg() may return error in some special cases, > > error handling should be did in their callers, and this will also > > facilitate subsequent error path expansion in {new,change}_curseg().

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to handle error paths of {new, change}_curseg()

2024-03-11 Thread Chao Yu
On 2024/3/8 18:12, Zhiguo Niu wrote: {new,change}_curseg() may return error in some special cases, error handling should be did in their callers, and this will also facilitate subsequent error path expansion in {new,change}_curseg(). Signed-off-by: Zhiguo Niu Signed-off-by: Chao Yu ---