Re: [f2fs-dev] [PATCH] f2fs: add REQ_TIME time update for some user behaviors

2024-03-14 Thread Zhiguo Niu
On Fri, Mar 15, 2024 at 11:07 AM Chao Yu wrote: > > On 2024/3/15 9:46, Zhiguo Niu wrote: > > On Thu, Mar 14, 2024 at 9:06 PM Chao Yu wrote: > >> > >> On 2024/3/13 12:11, Zhiguo Niu wrote: > >>> some user behaviors requested filesystem operations, which > >>> will cause filesystem not idle. > >>>

Re: [f2fs-dev] [PATCH] f2fs: add REQ_TIME time update for some user behaviors

2024-03-14 Thread Chao Yu
On 2024/3/15 9:46, Zhiguo Niu wrote: On Thu, Mar 14, 2024 at 9:06 PM Chao Yu wrote: On 2024/3/13 12:11, Zhiguo Niu wrote: some user behaviors requested filesystem operations, which will cause filesystem not idle. Meanwhile adjust f2fs_update_time(REQ_TIME) of f2fs_ioc_defragment to

Re: [f2fs-dev] [PATCH] f2fs: add REQ_TIME time update for some user behaviors

2024-03-14 Thread Zhiguo Niu
On Thu, Mar 14, 2024 at 9:06 PM Chao Yu wrote: > > On 2024/3/13 12:11, Zhiguo Niu wrote: > > some user behaviors requested filesystem operations, which > > will cause filesystem not idle. > > Meanwhile adjust f2fs_update_time(REQ_TIME) of > > f2fs_ioc_defragment to successful case. > > > >

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2024 09:57:57 -0700 Alison Schofield wrote: > On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >the second week of the merge window of

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Alison Schofield
On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will

[f2fs-dev] Patchwork summary for: f2fs

2024-03-14 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: [f2fs-dev,1/2] f2fs: mark inode dirty for FI_ATOMIC_COMMITTED flag Submitter: Sunmin Jeong Committer: Jaegeuk Kim Patchwork:

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid use-after-free issue in f2fs_filemap_fault

2024-03-14 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 14 Mar 2024 10:05:28 +0800 you wrote: > syzbot reports a f2fs bug as below: > > BUG: KASAN: slab-use-after-free in f2fs_filemap_fault+0xd1/0x2c0 > fs/f2fs/file.c:49 > Read of size 8 at addr 88807bb22680 by

Re: [f2fs-dev] [PATCH 1/2] f2fs: mark inode dirty for FI_ATOMIC_COMMITTED flag

2024-03-14 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 13 Mar 2024 20:26:19 +0900 you wrote: > In f2fs_update_inode, i_size of the atomic file isn't updated until > FI_ATOMIC_COMMITTED flag is set. When committing atomic write right > after the writeback of the inode,

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid use-after-free issue in f2fs_filemap_fault

2024-03-14 Thread Jaegeuk Kim
On 03/14, Chao Yu wrote: > syzbot reports a f2fs bug as below: > > BUG: KASAN: slab-use-after-free in f2fs_filemap_fault+0xd1/0x2c0 > fs/f2fs/file.c:49 > Read of size 8 at addr 88807bb22680 by task syz-executor184/5058 > > CPU: 0 PID: 5058 Comm: syz-executor184 Not tainted >

Re: [f2fs-dev] [PATCH v13 2/9] f2fs: Simplify the handling of cached insensitive names

2024-03-14 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: >> Please, make sure you actually stress test this patchset with fstests >> against both f2fs and ext4 before sending each new version. > > I did run the xfstests, however, maybe I did not run the full suite, or maybe > I am > running it in a wrong way ? No worries. Did

Re: [f2fs-dev] [PATCH] f2fs: add REQ_TIME time update for some user behaviors

2024-03-14 Thread Chao Yu
On 2024/3/13 12:11, Zhiguo Niu wrote: some user behaviors requested filesystem operations, which will cause filesystem not idle. Meanwhile adjust f2fs_update_time(REQ_TIME) of f2fs_ioc_defragment to successful case. Signed-off-by: Zhiguo Niu --- fs/f2fs/file.c | 9 - 1 file changed,

Re: [f2fs-dev] [PATCH 2/2] f2fs: truncate page cache before clearing flags when aborting atomic write

2024-03-14 Thread Chao Yu
On 2024/3/13 19:26, Sunmin Jeong wrote: In f2fs_do_write_data_page, FI_ATOMIC_FILE flag selects the target inode between the original inode and COW inode. When aborting atomic write and writeback occur simultaneously, invalid data can be written to original inode if the FI_ATOMIC_FILE flag is

Re: [f2fs-dev] [PATCH 1/2] f2fs: mark inode dirty for FI_ATOMIC_COMMITTED flag

2024-03-14 Thread Chao Yu
On 2024/3/13 19:26, Sunmin Jeong wrote: In f2fs_update_inode, i_size of the atomic file isn't updated until FI_ATOMIC_COMMITTED flag is set. When committing atomic write right after the writeback of the inode, i_size of the raw inode will not be updated. It can cause the atomicity corruption due

Re: [f2fs-dev] [PATCH v13 2/9] f2fs: Simplify the handling of cached insensitive names

2024-03-14 Thread Eugen Hristev via Linux-f2fs-devel
On 3/14/24 01:36, Gabriel Krisman Bertazi wrote: > Eugen Hristev writes: > >> +void f2fs_free_casefolded_name(struct f2fs_filename *fname) >> +{ >> +unsigned char *buf = (unsigned char *)fname->cf_name.name; >> + >> +kmem_cache_free(f2fs_cf_name_slab, buf); >> +fname->cf_name.name =