Re: [f2fs-dev] [PATCH v3] f2fs: prevent writing without fallocate() for pinned files

2024-03-25 Thread Chao Yu
On 2024/3/25 23:02, Daeho Jeong wrote: On Fri, Mar 22, 2024 at 9:26 PM Chao Yu wrote: On 2024/3/21 1:42, Daeho Jeong wrote: On Wed, Mar 20, 2024 at 2:38 AM Chao Yu wrote: On 2024/3/20 5:23, Daeho Jeong wrote: From: Daeho Jeong In a case writing without fallocate(), we can't guarantee

Re: [f2fs-dev] [bug report]WARNING: CPU: 22 PID: 44011 at fs/iomap/iter.c:51 iomap_iter+0x32b observed with blktests zbd/010

2024-03-25 Thread Chao Yu
On 2024/3/25 14:56, Shinichiro Kawasaki wrote: On Mar 25, 2024 / 11:06, Chao Yu wrote: On 2024/3/25 10:14, Shinichiro Kawasaki wrote: On Mar 24, 2024 / 20:13, Chao Yu wrote: ... Hi Shinichiro, Can you please check below diff? IIUC, for the case: f2fs_map_blocks() returns zero blkaddr in

Re: [f2fs-dev] [PATCH v14 8/9] ext4: Move CONFIG_UNICODE defguards into the code flow

2024-03-25 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > From: Gabriel Krisman Bertazi > > Instead of a bunch of ifdefs, make the unicode built checks part of the > code flow where possible, as requested by Torvalds. > > Signed-off-by: Gabriel Krisman Bertazi > [eugen.hris...@collabora.com: port to 6.8-rc3] > Signed-off-by:

[f2fs-dev] [PATCH 2/2] f2fs: support to map continuous holes or preallocated address

2024-03-25 Thread Chao Yu
This patch supports to map continuous holes or preallocated addresses to improve performace of lookuping mapping info during read DIO. [testcase 1] xfs_io -f /mnt/f2fs/hole -c "truncate 1m" -c "fsync" xfs_io -d /mnt/f2fs/hole -c "pread -b 1m 0 1m" [before] f2fs_direct_IO_enter: dev = (253,16),

[f2fs-dev] [PATCH 1/2] f2fs: introduce map_is_mergeable() for cleanup

2024-03-25 Thread Chao Yu
No logic changes. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 5ef1874b572a..9c000ca4f808 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1507,6 +1507,23 @@

[f2fs-dev] [PATCH] f2fs: multidev: fix to recognize valid zero block address

2024-03-25 Thread Chao Yu
As reported by Yi Zhang in mailing list [1], kernel warning was catched during zbd/010 test as below: ./check zbd/010 zbd/010 (test gap zone support with F2FS)[failed] runtime... 3.752s something found in dmesg: [ 4378.146781] run blktests zbd/010 at

Re: [f2fs-dev] [PATCH v3] f2fs: prevent writing without fallocate() for pinned files

2024-03-25 Thread Daeho Jeong
On Fri, Mar 22, 2024 at 9:26 PM Chao Yu wrote: > > On 2024/3/21 1:42, Daeho Jeong wrote: > > On Wed, Mar 20, 2024 at 2:38 AM Chao Yu wrote: > >> > >> On 2024/3/20 5:23, Daeho Jeong wrote: > >>> From: Daeho Jeong > >>> > >>> In a case writing without fallocate(), we can't guarantee it's

Re: [f2fs-dev] [bug report]WARNING: CPU: 22 PID: 44011 at fs/iomap/iter.c:51 iomap_iter+0x32b observed with blktests zbd/010

2024-03-25 Thread Shinichiro Kawasaki via Linux-f2fs-devel
On Mar 25, 2024 / 11:06, Chao Yu wrote: > On 2024/3/25 10:14, Shinichiro Kawasaki wrote: > > On Mar 24, 2024 / 20:13, Chao Yu wrote: > > ... > > > Hi Shinichiro, > > > > > > Can you please check below diff? IIUC, for the case: f2fs_map_blocks() > > > returns zero blkaddr in non-primary device,