Re: [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropirate defragment pg_end

2024-03-26 Thread Zhiguo Niu
On Tue, Mar 26, 2024 at 7:11 PM Chao Yu wrote: > > On 2024/3/25 13:56, Zhiguo Niu wrote: > > A length that exceeds the real size of the inode may be > > specified from user, although these out-of-range areas > > are not mapped, but they still need to be check in > > while loop, which is

[f2fs-dev] [PATCH v5] f2fs: prevent writing without fallocate() for pinned files

2024-03-26 Thread Daeho Jeong
From: Daeho Jeong In a case writing without fallocate(), we can't guarantee it's allocated in the conventional area for zoned stroage. To make it consistent across storage devices, we disallow it regardless of storage device types. Signed-off-by: Daeho Jeong --- v2: covered the direct io case

Re: [f2fs-dev] [PATCH v3] f2fs: prevent writing without fallocate() for pinned files

2024-03-26 Thread Daeho Jeong
On Mon, Mar 25, 2024 at 8:39 PM Chao Yu wrote: > > On 2024/3/25 23:02, Daeho Jeong wrote: > > On Fri, Mar 22, 2024 at 9:26 PM Chao Yu wrote: > >> > >> On 2024/3/21 1:42, Daeho Jeong wrote: > >>> On Wed, Mar 20, 2024 at 2:38 AM Chao Yu wrote: > > On 2024/3/20 5:23, Daeho Jeong wrote: >

Re: [f2fs-dev] 回覆: [PATCH] f2fs: avoid the deadlock case when stopping discard thread

2024-03-26 Thread Jaegeuk Kim
On 03/22, Jaegeuk Kim wrote: > On 03/22, Light Hsieh (謝明燈) wrote: > > I don't see my added log in sb_free_unlock() which will invoke > > percpu_up_write to release the write semaphore. > > May I ask more details whether thaw_super() was called or not? Ping? > > > > > > >

Re: [f2fs-dev] [PATCH] f2fs: multidev: fix to recognize valid zero block address

2024-03-26 Thread Chao Yu
On 2024/3/26 21:26, Yi Zhang wrote: I confirmed the issue was fixed now, thanks. Tested-by: Yi Zhang Yi, thanks for the test. Thanks, On Mon, Mar 25, 2024 at 11:26 PM Chao Yu wrote: As reported by Yi Zhang in mailing list [1], kernel warning was catched during zbd/010 test as below:

Re: [f2fs-dev] [PATCH] f2fs: multidev: fix to recognize valid zero block address

2024-03-26 Thread Yi Zhang
I confirmed the issue was fixed now, thanks. Tested-by: Yi Zhang On Mon, Mar 25, 2024 at 11:26 PM Chao Yu wrote: > > As reported by Yi Zhang in mailing list [1], kernel warning was catched > during zbd/010 test as below: > > ./check zbd/010 > zbd/010 (test gap zone support with F2FS)

[f2fs-dev] [PATCH] f2fs: fix to wait on page writeback in __clone_blkaddrs()

2024-03-26 Thread Chao Yu
In below race condition, dst page may become writeback status in __clone_blkaddrs(), it needs to wait writeback before update, fix it. Thread AGC Thread - f2fs_move_file_range - filemap_write_and_wait_range(dst) -

Re: [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropirate defragment pg_end

2024-03-26 Thread Chao Yu
On 2024/3/25 13:56, Zhiguo Niu wrote: A length that exceeds the real size of the inode may be specified from user, although these out-of-range areas are not mapped, but they still need to be check in while loop, which is unnecessary. Signed-off-by: Zhiguo Niu --- v2: check i_size within inode

[f2fs-dev] [PATCH] f2fs: remove clear SB_INLINECRYPT flag in default_options

2024-03-26 Thread Yunlei He via Linux-f2fs-devel
In f2fs_remount, SB_INLINECRYPT flag will be clear and re-set. If create new file or open file during this gap, these files will not use inlinecrypt. Worse case, it may lead to data corruption if wrappedkey_v0 is enable. Thread A: Thread B: -f2fs_remount