nr_folios = filemap_get_folios_tag(mapping, &index, end,
> + tag, &fbatch);
> + if (nr_folios == 0)
> break;
>
> - ret = gfs2_write_jdata_pagevec(mapping, wbc, &pvec, nr_pag
On Mon, Apr 24, 2023 at 8:22 AM Christoph Hellwig wrote:
> All callers of generic_perform_write need to updated ki_pos, move it into
> common code.
We've actually got a similar situation with
iomap_file_buffered_write() and its callers. Would it make sense to
fix that up as well?
> Signed-off-by
On Wed, May 24, 2023 at 8:54 AM Christoph Hellwig wrote:
> All callers of iomap_file_buffered_write need to updated ki_pos, move it
> into common code.
Thanks for this set of cleanups, especially for the patch killing
current->backing_dev_info.
Reviewed-by: Andreas Gruenbacher
> S
Christoph,
nice work, and a pretty diffstat.
I see that get_acl and set_acl are being defined in some but not all symlink
inode operations (for example, btrfs them while ext4 does not), and that
posix_acl_xattr_set() doesn't check if set_acl is defined. Symlinks cannot
have ACLs, so set_acl s
Christoph,
> +int
> +posix_acl_chmod(struct inode *inode)
> +{
> + struct posix_acl *acl;
> + int ret = 0;
> +
> + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> + return -EOPNOTSUPP;
Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check
her
Christoph,
gfs2 has a left-over get_acl callback in gfs2_symlink_iops in
fs/gfs2/inode.c, from a long time ago, which should be removed
as well.
Andreas
--
Rapidly troubleshoot problems before they affect your business.
Christoph,
> +static int
> +posix_acl_xattr_set(struct dentry *dentry, const char *name,
> + const void *value, size_t size, int flags, int type)
> +{
> + struct inode *inode = dentry->d_inode;
> + struct posix_acl *acl = NULL;
> + int ret;
> +
> + if (!IS_POSIXACL(inod
Christoph,
> +struct posix_acl *get_acl(struct inode *inode, int type)
> +{
> + struct posix_acl *acl;
> +
> + acl = get_cached_acl(inode, type);
> + if (acl != ACL_NOT_CACHED)
> + return acl;
> +
> + if (!IS_POSIXACL(inode))
> + return NULL;
> +
> + /*
Fix a check in block_page_mkwrite meant to determine whether an offset
is within the inode size. This error has spread to several filesystems
and to iomap_page_mkwrite, so fix those instances as well.
Signed-off-by: Andreas Gruenbacher
---
This patch has a trivial conflict with commit "
computes the bytes in the page up to EOF, and
use that helper in the above mentioned filesystems and in btrfs.
Signed-off-by: Andreas Gruenbacher
---
This patch has a trivial conflict with commit "iomap: Fix overflow in
iomap_page_mkwrite" in Darrick's iomap pull request fo
that by introducing a new page_mkwrite_check_truncate helper that
checks for truncate and computes the bytes in the page up to EOF. Use
the helper in the above mentioned filesystems.
In addition, use the new helper in btrfs as well.
Signed-off-by: Andreas Gruenbacher
Acked-by: David Sterba (btrfs
On Wed, Dec 18, 2019 at 7:55 PM Darrick J. Wong wrote:
> On Wed, Dec 18, 2019 at 02:09:35PM +0100, Andreas Gruenbacher wrote:
> > Hi Darrick,
> >
> > can this fix go in via the xfs tree?
>
> Er, I'd rather not touch five other filesystems via the XFS tree.
> How
by introducing a new page_mkwrite_check_truncate helper that
checks for truncate and computes the bytes in the page up to EOF. Use
the helper in the above mentioned filesystems.
In addition, use the new helper in btrfs as well.
Signed-off-by: Andreas Gruenbacher
Acked-by: David Sterba (btrf
Am Mi., 15. Apr. 2020 um 23:39 Uhr schrieb Matthew Wilcox :
> From: "Matthew Wilcox (Oracle)"
>
> Implement the new readahead aop and convert all callers (block_dev,
> exfat, ext2, fat, gfs2, hpfs, isofs, jfs, nilfs2, ocfs2, omfs, qnx6,
> reiserfs & udf). The callers are all trivial except for GF
On Wed, Jun 17, 2020 at 4:22 AM Matthew Wilcox wrote:
> On Wed, Jun 17, 2020 at 02:57:14AM +0200, Andreas Grünbacher wrote:
> > Am Mi., 17. Juni 2020 um 02:33 Uhr schrieb Matthew Wilcox
> > :
> > >
> > > On Wed, Jun 17, 2020 at 12:36:13AM +0200, Andreas Gruenbach
On Thu, Jun 18, 2020 at 5:03 PM Matthew Wilcox wrote:
>
> On Thu, Jun 18, 2020 at 02:46:03PM +0200, Andreas Gruenbacher wrote:
> > On Wed, Jun 17, 2020 at 4:22 AM Matthew Wilcox wrote:
> > > On Wed, Jun 17, 2020 at 02:57:14AM +0200, Andreas Grünbacher wrote:
> > >
lready
cached, the ->read_iter file operation first tries to read the data with
the IOCB_CACHED flag set. If that fails, the inode glock is locked and
the operation is repeated without the IOCB_CACHED flag.
Signed-off-by: Andreas Gruenbacher
---
fs/gfs2/aops.c | 27 ++
-ECANCELED is returned when readahead would be triggered.
This allows the caller to perform a tentative read out of the page
cache, and to retry the read if the requested pages are not cached.
Please see the next commit for what this is used for.
Signed-off-by: Andreas Gruenbacher
---
include
ad_iter.
A previous version was posted in November:
https://lore.kernel.org/linux-fsdevel/20191122235324.17245-1-agrue...@redhat.com/
Thanks,
Andreas
Andreas Gruenbacher (2):
fs: Add IOCB_CACHED flag for generic_file_read_iter
gfs2: Rework read and page fault locking
fs/gfs2/aops.c
: Andreas Gruenbacher
---
fs/f2fs/xattr.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
index e643173..862368a 100644
--- a/fs/f2fs/xattr.c
+++ b/fs/f2fs/xattr.c
@@ -30,33 +30,27 @@ static size_t f2fs_xattr_generic_list(const struct
: Andreas Gruenbacher
Cc: Jaegeuk Kim
Cc: Changman Lee
Cc: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net
---
fs/f2fs/xattr.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
index e643173..862368a 100644
--- a/fs/f2fs/xattr.c
On Wed, Apr 6, 2022 at 8:07 AM Christoph Hellwig wrote:
>
> Add a helper to query the number of sectors support per each discard bio
> based on the block device and use this helper to stop various places from
> poking into the request_queue to see if discard is supported and if so how
> much. Thi
22 matches
Mail list logo
