Previously, recover_fsync_data still to write checkpoint when there is
nothing to recover with normal umount image.
It may reduce mount performance and flash memory lifetime, so let's remove
it.
Signed-off-by: Tan Shu shu@samsung.com
Signed-off-by: Yu Chao chao2...@samsung.com
---
Since f2fs mount process should scanning all valid SIT entries and reserve
information in memory for following operations during mount process, the
mount performance is worse than ext4 in embedded devices. We found a way to
improve the mount performance based on current f2fs design strategy. For
Previously, check_block_count check valid_map with bit data type in common
scenario that sit has all ones or zeros bitmap, it makes low mount
performance.
So let's check the special bitmap with integer data type instead of the bit
one.
Signed-off-by: Tan Shu shu@samsung.com
Signed-off-by: Yu
Hi, Kim:
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, October 22, 2013 8:24 PM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org; 谭姝
Subject: Re: [f2fs-dev] [PATCH] f2fs: check
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Wednesday, October 23, 2013 5:32 PM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org; '谭姝'
Subject: RE: [f2fs-dev] [PATCH] f2fs
Previously, set_page_dirty is called every time after writting one summary info
into compacted summary page,
To avoid redundant set_page_dirty, we only call set_page_dirty before release
page.
Signed-off-by: Yu Chao chao2...@samsung.com
---
fs/f2fs/segment.c |8
1 file changed, 4
Previously, check_block_count check valid_map with bit data type in common
scenario that sit has all ones or zeros bitmap, it makes low mount performance.
So let's check the special bitmap with integer data type instead of the bit one.
v2:
use find_next_bit_le/find_next_zero_bit_le for
Hi Gu,
-Original Message-
From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com]
Sent: Thursday, October 24, 2013 6:04 PM
To: Chao Yu
Cc: jaegeuk@samsung.com; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; '谭姝'
Subject: Re: [f2fs
Hi Lee,
-Original Message-
From: 이창만 [mailto:cm224@samsung.com]
Sent: Monday, October 28, 2013 10:20 AM
To: 'Chao Yu'; jaegeuk@samsung.com
Cc: linux-fsde...@vger.kernel.org; '谭姝'; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: RE: [f2fs-dev
Hi Lee,
-Original Message-
From: Changman Lee [mailto:cm224@samsung.com]
Sent: Wednesday, October 30, 2013 7:25 AM
To: 'Chao Yu'; jaegeuk@samsung.com
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: RE: [f2fs
In wait_on_node_pages_writeback we will test and clear error flag for all pages
in radix tree, but not necessary.
So we only do this for pages belong to the specified inode.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c |7 ---
1 file changed, 4 insertions(+), 3
Hi Gu,
-Original Message-
From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com]
Sent: Wednesday, November 06, 2013 11:41 AM
To: Chao Yu
Cc: ???; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net; 谭姝
Subject: Re: [f2fs-dev] [PATCH] f2fs
For better read performance, we add a new function to support for merging
contiguous read as the one for write.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c | 45 +
fs/f2fs/f2fs.h |2 ++
2 files changed, 47 insertions(+)
diff
For better read performance, we add a new function to support for merging
contiguous read as the one for write.
v1--v2:
o add declarations here as Gu Zheng suggested.
Signed-off-by: Chao Yu chao2...@samsung.com
Acked-by: Gu Zheng guz.f...@cn.fujitsu.com
---
fs/f2fs/data.c | 45
All DATA/NODE/META bio buffers in superblock is protected by
'sbi-write_mutex', but each bio buffer area is independent, So we
should split write_mutex to three for DATA/NODE/META.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h|2 +-
fs/f2fs/segment.c |8
Hi
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, November 19, 2013 11:36 AM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: split sbi
mark_page_accessed() before release page to delay VM reclaiming them.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/segment.c | 108 -
fs/f2fs/segment.h |2 +
2 files changed, 84 insertions(+), 26 deletions(-)
diff --git a/fs/f2fs
This patch adds a tracepoint for submit_read_page.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c |1 +
include/trace/events/f2fs.h | 30 ++
2 files changed, 31 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index
Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE
in fallocate, so we could remove the useless 'keep size' branch code which
will never be excuted in punch_hole.
Signed-off-by: Chao Yu chao2...@samsung.com
Signed-off-by: Fan Li fanofcode...@samsung.com
---
fs/f2fs/file.c
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/segment.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index b84dd23..5f733ec 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -96,7 +96,7 @@
struct bio_private
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 0fe9a97..954155b 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1160,7 +1160,7 @@ int wait_on_node_pages_writeback
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c |6 +++---
fs/f2fs/f2fs.h |2 +-
fs/f2fs/super.c |8
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 7fe69ff..b28e61b 100644
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Friday, November 29, 2013 6:14 PM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net; 谭姝
Subject: Re: [f2fs-dev] [PATCH 2/5] f2fs
Hi,
Some comments as following.
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Saturday, November 30, 2013 2:26 PM
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] f2fs:
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Saturday, November 30, 2013 9:48 AM
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] f2fs: remove the own
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, December 02, 2013 4:15 PM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net; 谭姝
Subject: RE: [f2fs-dev] [PATCH] f2fs
Hi Liu,
You're right, we should release it instead of holding the resource
with no use. And here are some comments as following.
BTW, your patch is out of format. You'd better not let remote
terminal or editor to instead tab with blanks in the patch.
Thanks,
Yu
-Original Message-
Hi,
Comment as following.
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, December 02, 2013 4:27 PM
To: linux-fsde...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2]
Use inner macro GFP_F2FS_ZERO to instead of GFP_NOFS | __GFP_ZERO for
simplification of code.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c |2 +-
fs/f2fs/recovery.c |2 +-
fs/f2fs/super.c|2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
This patch introduces f2fs_cache_node_page(), in this function, page which is
readed ahead will be copy to node_inode's mapping cache.
It will avoid rereading these node pages.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c | 30 ++
1 file changed
a segment fault in put_page_testzero when CONFIG_DEBUG_VM
is on, or return MM with a bad page with wrong _count num.
So let's just release this page.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/recovery.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs
suggested by Jaegeuk Kim.
Suggested-by: Jaegeuk Kim jaegeuk@samsung.com
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c | 10 +-
fs/f2fs/data.c |4 ++--
fs/f2fs/dir.c|4 ++--
fs/f2fs/f2fs.h |8
fs/f2fs/node.c | 16
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Friday, December 06, 2013 9:43 AM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net; 谭姝
Subject: RE: [f2fs-dev] [PATCH 3/3] f2fs
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Friday, December 06, 2013 2:15 PM
Cc: Jaegeuk Kim; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net; Chao Yu
Subject: [PATCH] f2fs: add unlikely() macro
@samsung.com
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 099f06f..3ff98fa 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1600,6 +1600,39 @@ static int
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, December 09, 2013 7:37 AM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3 V2] f2fs
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, December 09, 2013 4:01 PM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3 V3] f2fs
-Original Message-
From: Chao Yu [mailto:chao2...@samsung.com]
Sent: Tuesday, December 10, 2013 9:52 AM
To: jaegeuk@samsung.com
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3 V3] f2fs
Hi Gu,
-Original Message-
From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com]
Sent: Wednesday, December 18, 2013 6:29 PM
To: Kim
Cc: fsdevel; linux-kernel; f2fs
Subject: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into
__bio_alloc
Move all the bio initialization into
Hi Kim,
One comment as following:
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Wednesday, December 18, 2013 8:12 AM
To: linux-fsde...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev]
the code of checking filename length
In f2fs_find_entry, because f2fs_lookup will be called previously to ensure of
validity of filename length.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/dir.c |3 ---
fs/f2fs/recovery.c |5 +
2 files changed, 5 insertions(+), 3 deletions
Update several comments:
1. use f2fs_{un}lock_op install of mutex_{un}lock_op.
2. update comment of get_data_block().
3. update description of node offset.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c | 14 --
fs/f2fs/dir.c |4 ++--
fs/f2fs/f2fs.h |2
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, December 23, 2013 9:26 AM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: check
the code of checking filename length
In f2fs_find_entry, because f2fs_lookup will be called previously to ensure of
validity of filename length.
V2:
o add WARN_ON() as Jaegeuk Kim suggested.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/dir.c |3 ---
fs/f2fs/recovery.c |6
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Thursday, December 26, 2013 6:55 AM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/3 V2] f2fs
);
Looks Nice!
Could we apply this to recover_inode_page?
It seems that we just use inode data only.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
Reviewed-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/dir.c | 8
fs/f2fs/f2fs.h | 5 +
fs/f2fs/inode.c| 8
We left uninitialized data in the tail of page when we read an inline data
page. So let's initialize left part of the page excluding inline data region.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/inline.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs
Change log from v1:
o reduce unneeded memset in __f2fs_convert_inline_data
From 58796be2bd2becbe8d52305210fb2a64e7dd80b6 Mon Sep 17 00:00:00 2001
From: Chao Yu chao2...@samsung.com
Date: Mon, 30 Dec 2013 09:21:33 +0800
Subject: [PATCH] f2fs: avoid to left uninitialized data in page when read
: convert inline_data for punch_hole
In the punch_hole(), let's convert inline_data all the time for simplicity and
to avoid potential deadlock conditions.
It is pretty much not a big deal to do this.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
Reviewed-by: Chao Yu chao2
of protection region, and grab all
the orphan block pages ahead.
Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com
Reviewed-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b
This patch help us to cleanup the readahead code by merging ra_{sit,nat}_pages
function into ra_meta_pages.
Additionally the new function is used to readahead cp block in
recover_orphan_inodes.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c | 78
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, January 28, 2014 2:00 PM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: use inode
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Friday, February 07, 2014 2:58 PM
To: Chao Yu
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce
This patch help us to cleanup the readahead code by merging ra_{sit,nat}_pages
function into ra_meta_pages.
Additionally the new function is used to readahead cp block in
recover_orphan_inodes.
Change log from v1:
o fix a deadloop bug pointed by Jaegeuk Kim.
Signed-off-by: Chao Yu chao2
If there are multi segments in one section, we will read those SSA blocks which
have contiguous address one by one in f2fs_gc. It may lost performance, let's
read ahead SSA blocks by merge multi read request.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c |6 --
fs
This patch use existing macro F2FS_INODE/NEXT_FREE_BLKADDR to clean up some
codes.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h |6 ++
fs/f2fs/recovery.c |2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index
Reviewed-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c| 44
fs/f2fs/segment.c |7 +--
2 files changed, 25 insertions(+), 26 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 8787469..4b7861d 100644
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, March 10, 2014 1:38 PM
To: Chao Yu
Cc: 'Gu Zheng'; 'linux-kernel'; 'f2fs'
Subject: RE: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary
slightly
Hi,
2014-03-10 (월), 13:13 +0800
Previously we do not recover inline xattr data of inode after power-cut, so
inline xattr data may be lost.
We should recover the data during the roll-forward process.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c | 33 +
1 file changed, 33
This patch introduces a help function f2fs_has_inline_xattr for better
readability.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h |9 +++--
fs/f2fs/node.c |2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index
Upper bound checking of ino should be added to f2fs_nfs_get_inode, so unneeded
process before do_read_inode in f2fs_iget could be avoided when ino is invalid.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/super.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/super.c
Hi Gu,
-Original Message-
From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com]
Sent: Thursday, March 13, 2014 5:58 PM
To: Chao Yu
Cc: 'Kim'; 'linux-kernel'; 'f2fs'
Subject: Re: [f2fs-dev] [PATCH 3/5] f2fs: format segment_info's show for
better legibility
Hi,
On 03/13/2014 05:13 PM
|512 0|512 0|512 3|512
100 3|512 0|512 3|511 0|328 3|512 0|512 0|512 3|512 0|512 0|512
110 0|512 0|512 0|512 0|512 0|512 0|512 0|512 5|0 4|0 3|512
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/super.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/fs
This patch introduces a help function f2fs_has_xattr_block for better
readability.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h |5 +
fs/f2fs/node.c |4 ++--
fs/f2fs/node.h |2 +-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs
We should return error number of read_normal_summaries instead of -EINVAL when
read_normal_summaries failed.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/segment.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
Previously 'background_gc={on***,off***}' is being parsed as correct option,
with this patch we cloud fix the trivial bug in mount process.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/super.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, March 18, 2014 8:33 AM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix incorrect
Previously 'background_gc={on***,off***}' is being parsed as correct option,
with this patch we cloud fix the trivial bug in mount process.
Change log from v1:
o need to check length of parameter suggested by Jaegeuk Kim.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/super.c |4
This patch introduce is_merged_page() to check whether current page is merged
in f2fs bio cache. When page is not in cache, we can avoid submitting bio cache,
resulting in having more chance to merge pages.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c|8
fs
In f2fs_setxattr we have limit this attribute name length, so we should also
check it in f2fs_getxattr to avoid useless lookup caused by invalid name length.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/xattr.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/xattr.c b
This patch use list_for_each_entry{_safe} instead of list_for_each{_safe} for
simplfying code.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c | 37 ++---
fs/f2fs/node.c | 16 ++--
fs/f2fs/recovery.c |6 ++
fs
We should unlock page in -readpage() path and also should unlock release page
in error path of -write_begin() to avoid deadlock or memory leak.
So let's add release code to fix the problem when we fail to read inline data.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c | 14
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, April 01, 2014 8:04 PM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid
Move kmem_cache_free out of spinlock protection region for better performance.
Change log from v1:
o remove spinlock protection for kmem_cache_free in destroy_node_manager
suggested by Jaegeuk Kim.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c | 27
If we remove a file that has inline data after mount, our statistics turns to
inaccurate.
cat /sys/kernel/debug/f2fs/status
- Inline_data Inode: 4294967295
Let's add stat_inc_inline_inode() to stat inline info of the file when lookup.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs
of in do_read_inode() for excluding wrong stat.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/namei.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 0cea874..a9409d1 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -207,6 +207,8 @@ static
Hi Levin,
Could you share dump code info like following one which can be generated
by 'objdump -Dl f2fs.ko obj'.
It may help us to get a clue for this problem.
verify_block_addr()
segment.h:543 (discriminator 3)
2f35: 39 55 eccmp%edx,-0x14(%ebp)
segment.h:542
This patch introduce raw_nat_from_node_info() to simplfy some codes, and also
use exist function node_info_from_raw_nat() to do the same job.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c | 15 +++
fs/f2fs/node.h |8
2 files changed, 11 insertions
of this value, and left the reserved nids there.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 84f9b7b..3f0bb50 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1860,7 +1860,7
We skip reading last one of NAT blocks when readahead them since max value of
valid block is calculated incorrectly. We should fix this problem to avoid it.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/checkpoint.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Friday, April 18, 2014 10:16 AM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to enable
We'd better handle inline data case independently in f2fs_bmap().
It can reduce our handling time in f2fs_bmap().
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c |5 +
1 file changed, 5 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 6b89b25..150c12a
In This patch we introduce f2fs_seek_block to support SEEK_{DATA,HOLE} of
lseek(2).
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h |6
fs/f2fs/file.c | 96 +++-
2 files changed, 101 insertions(+), 1 deletion(-)
diff
Introduce help macro ADDRS_PER_PAGE() to get the number of address pointers in
direct node or inode.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c |6 ++
fs/f2fs/file.c |5 +
fs/f2fs/recovery.c |5 +
include/linux/f2fs_fs.h |3
We should set the error number correctly when we fail in recover_dentry(), so
the recover flow could stop for the reason as error number shows instead of
continuing.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/recovery.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion
We have no so such readahead mechanism in -iterate() path as the one in
-read() path, it cause low performance when we read large directory.
This patch add readahead in f2fs_readdir() for better performance.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/dir.c |6 ++
fs/f2fs
() to fix this problem.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h |1 +
fs/f2fs/file.c |3 +++
fs/f2fs/inline.c | 18 ++
3 files changed, 22 insertions(+)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 2b67679..676a2c6 100644
--- a/fs/f2fs
() to fix this problem.
change log from v1:
o fix a bug and do not truncate first page data after truncate inline data.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/f2fs.h |1 +
fs/f2fs/file.c |3 +++
fs/f2fs/inline.c | 18 ++
3 files changed, 22 insertions
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, April 29, 2014 2:16 PM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re: [f2fs-dev][PATCH 3/3 v3] f2fs: fix
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, April 29, 2014 4:02 PM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: RE: [f2fs-dev][PATCH 3/3 v3] f2fs: fix
This patch adds a tracepoint for f2fs_write_end to trace write op of user.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c |2 ++
include/trace/events/f2fs.h | 30 ++
2 files changed, 32 insertions(+)
diff --git a/fs/f2fs/data.c b/fs
This patch adds a tracepoint for f2fs_read_data_page to trace when page is
readed by user.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c |2 ++
include/trace/events/f2fs.h | 15 +--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/fs
This patch adds a tracepoint for f2fs_read_data_pages to trace when pages are
readahead by VFS.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/data.c |3 +++
include/trace/events/f2fs.h | 26 ++
2 files changed, 29 insertions(+)
diff --git
If we use slab memory in f2fs_issue_flush(), we will face memory pressure and
latency time caused by racing of kmem_cache_{alloc,free}.
Let's alloc memory in stack instead of slab.
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/segment.c | 28 +---
1 file
This patch uses exported inode_init_owner() to simplify codes in
f2fs_new_inode().
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/namei.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index a9409d1..9138c32 100644
/0x22
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c | 49 -
1 file changed, 28 insertions(+), 21 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 3d60d3d..b5cd814 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Wednesday, May 21, 2014 11:37 AM
To: Chao Yu
Cc: Jaegeuk Kim; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs
] do_mount+0x1e8/0x900
[c1175d72] SyS_mount+0x82/0xc0
[c16059cc] sysenter_do_call+0x12/0x22
Suggested-by: Jaegeuk Kim jaegeuk@samsung.com
Signed-off-by: Chao Yu chao2...@samsung.com
---
fs/f2fs/node.c | 52
1 file changed, 24 insertions
Hi changman,
-Original Message-
From: Changman Lee [mailto:cm224@samsung.com]
Sent: Tuesday, May 27, 2014 9:25 AM
To: Chao Yu
Cc: Jaegeuk Kim; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2
Hi changman,
-Original Message-
From: Changman Lee [mailto:cm224@samsung.com]
Sent: Tuesday, May 27, 2014 3:21 PM
To: Chao Yu
Cc: 'Jaegeuk Kim'; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH
1 - 100 of 6598 matches
Mail list logo
