goto out;
}
- *submitted += _submitted;
+ *submitted_p += submitted;
}
out:
On 01/11, Chao Yu wrote:
When we overwrite compressed cluster w/ normal cluster, we should
not unlock cp_rwsem during f2fs_write_raw_pages(), otherwise data
will be corrupted if
Suggested-by: Al Viro
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
ing, my bad.
Fixes: 275dca4630c1 ("f2fs: move release of block devices to after
kill_block_super()")
Reported-by: syzbot+8f477ac014ff5b32d...@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/r/6cb174060ec34...@google.com
Signed-off-by: Eric Biggers
Reviewe
-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2024/1/12 1:15, Daeho Jeong wrote:
On Wed, Jan 10, 2024 at 5:33 PM Chao Yu wrote:
On 2024/1/11 9:18, Daeho Jeong wrote:
On Thu, Dec 28, 2023 at 6:33 AM Chao Yu wrote:
From: Sheng Yong
Compressed cluster may not be released due to we can fail in
release_compress_blocks(), fix
He
Signed-off-by: Chao Yu
---
v3:
- Recently, Zhiguo Niu reported the same issue, so I repost this
patch for comments.
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/file.c | 3 +++
fs/f2fs/xattr.c | 16 ++--
include/trace/events/f2fs.h | 3 ++-
4 files c
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 18 --
fs/f2fs/file.c | 5 ++---
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 74729db0b381..e2e0ca45f881 100
port data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 20 ++--
fs/f2fs/data.c | 3 ++-
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 9940b7886e5d..bf4cfab67aec 100644
--- a/fs/f2fs/compress.c
verify_blkaddr() will trigger panic once we inject fault into
f2fs_is_valid_blkaddr(), fix to remove this unnecessary f2fs_bug_on().
Fixes: 18792e64c86d ("f2fs: support fault injection for
f2fs_is_valid_blkaddr()")
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 4 +---
1 file changed, 1
heck error path handling in kernel side.
Signed-off-by: Chao Yu
---
v4:
- rename macro to FAULT_BLKADDR_CONSISTENCE and FAULT_BLKADDR_VALIDITY
suggested by Jaegeuk.
Documentation/ABI/testing/sysfs-fs-f2fs | 47 +
Documentation/filesystems/f2fs.rst | 47
If data block in compressed cluster is not persisted with metadata
during checkpoint, after SPOR, the data may be corrupted, let's
guarantee to write compressed page by checkpoint.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c |
oduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Signed-off-by: Chao Yu
---
fs/f2fs/data.c| 5 +++--
fs/f2fs/f2fs.h| 7 ++-
fs/f2fs/file.c| 26 ++
fs/f2fs/segment.c | 2 +-
4 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f
From: Sheng Yong
Compressed cluster may not be released due to we can fail in
release_compress_blocks(), fix to handle reserved compressed
cluster correctly in reserve_compress_blocks().
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Sheng Yong
Signed-off-b
On 2024/1/3 6:54, Jaegeuk Kim wrote:
On 12/28, Chao Yu wrote:
On 2023/12/13 6:21, Jaegeuk Kim wrote:
On 12/12, Chao Yu wrote:
On 2023/12/12 6:11, Jaegeuk Kim wrote:
On 12/10, Chao Yu wrote:
This patch adds i_size check during compress inode conversion in order
to avoid .page_mkwrite races w
On 2024/1/3 4:55, Jaegeuk Kim wrote:
On 12/28, Chao Yu wrote:
We will encounter below inconsistent status when FAULT_BLKADDR type
fault injection is on.
Info: checkpoint state = d6 : nat_bits crc fsck compacted_summary
orphan_inodes sudden-power-off
[ASSERT] (fsck_chk_inode_blk:1254
On 2024/1/11 9:18, Daeho Jeong wrote:
On Thu, Dec 28, 2023 at 6:33 AM Chao Yu wrote:
From: Sheng Yong
Compressed cluster may not be released due to we can fail in
release_compress_blocks(), fix to handle reserved compressed
cluster correctly in reserve_compress_blocks().
Fixes
On 2024/1/11 8:55, Daeho Jeong wrote:
On Thu, Dec 28, 2023 at 6:33 AM Chao Yu wrote:
If data block in compressed cluster is not persisted with metadata
during checkpoint, after SPOR, the data may be corrupted, let's
guarantee to write compressed page by checkpoint.
Fixes: 4c8ff7095bef ("
On 2023/12/13 6:21, Jaegeuk Kim wrote:
On 12/12, Chao Yu wrote:
On 2023/12/12 6:11, Jaegeuk Kim wrote:
On 12/10, Chao Yu wrote:
This patch adds i_size check during compress inode conversion in order
to avoid .page_mkwrite races w/ conversion.
Which race condition do you see?
Something
oduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Signed-off-by: Chao Yu
---
fs/f2fs/data.c| 5 +++--
fs/f2fs/f2fs.h| 7 ++-
fs/f2fs/file.c| 26 ++
fs/f2fs/segment.c | 2 +-
4 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f
can:
a) use FAULT_BLKADDR_INCONSISTENCE in f2fs_truncate_data_blocks_range()
to simulate inconsistent issue independently,
b) FAULT_BLKADDR fault will not cause any inconsistent status, we can
just use it to check error path handling in kernel side.
Signed-off-by: Chao Yu
---
v3:
- rename FAUL
port data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 20 ++--
fs/f2fs/data.c | 3 ++-
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 9940b7886e5d..bf4cfab67aec 100644
--- a/fs/f2fs/compress.c
verify_blkaddr() will trigger panic once we inject fault into
f2fs_is_valid_blkaddr(), fix to remove this unnecessary f2fs_bug_on().
Fixes: 18792e64c86d ("f2fs: support fault injection for
f2fs_is_valid_blkaddr()")
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 4 +---
1 file changed, 1
From: Sheng Yong
Compressed cluster may not be released due to we can fail in
release_compress_blocks(), fix to handle reserved compressed
cluster correctly in reserve_compress_blocks().
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Sheng Yong
Signed-off-b
If data block in compressed cluster is not persisted with metadata
during checkpoint, after SPOR, the data may be corrupted, let's
guarantee to write compressed page by checkpoint.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
v3:
- treat compressed
On 2023/12/28 7:06, Jaegeuk Kim wrote:
On 12/25, Chao Yu wrote:
We will encounter below inconsistent status when FAULT_BLKADDR type
fault injection is on.
Info: checkpoint state = d6 : nat_bits crc fsck compacted_summary
orphan_inodes sudden-power-off
[ASSERT] (fsck_chk_inode_blk:1254
On 2023/12/28 6:55, Jaegeuk Kim wrote:
On 12/27, Chao Yu wrote:
On 2023/12/27 5:02, Jaegeuk Kim wrote:
On 12/20, Chao Yu wrote:
If data block in compressed cluster is not persisted with metadata
during checkpoint, after SPOR, the data may be corrupted, let's
guarantee to write compressed page
fscrypt_destroy_keyring() just
after calling ->put_super. This is because fscrypt_destroy_keyring()
may call into f2fs_get_devices() via the fscrypt_operations.
Signed-off-by: Eric Biggers
Reviewed-by: Chao Yu
Thanks,
On 2023/12/13 12:00, Eric Biggers wrote:
From: Eric Biggers
Call destroy_device_list() and free the f2fs_sb_info from
kill_f2fs_super(), after the call to kill_block_super(). This is
necessary to order it after the call to fscrypt_destroy_keyring() once
generic_shutdown_super() starts calling
On 2023/12/27 5:02, Jaegeuk Kim wrote:
On 12/20, Chao Yu wrote:
If data block in compressed cluster is not persisted with metadata
during checkpoint, after SPOR, the data may be corrupted, let's
guarantee to write compressed page by checkpoint.
Fixes: 4c8ff7095bef ("f2fs: support
that
we can:
a) use FAULT_INCONSISTENCE in f2fs_truncate_data_blocks_range() to
simulate inconsistent issue independently,
b) FAULT_BLKADDR fault will not cause any inconsistent status, we can
just use it to check error path handling in kernel side.
Signed-off-by: Chao Yu
---
v2:
- make __f2fs_is_valid_blkaddr() vo
();
try_to_freeze();
We can change it to a simple wait_event_freezable_timeout() and then
eliminate the function calls to try_to_freeze() and freezing().
Signed-off-by: Kevin Hao
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs
oduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Signed-off-by: Chao Yu
---
v2:
- rebase code to last dev-test branch
fs/f2fs/data.c| 5 +++--
fs/f2fs/f2fs.h| 7 ++-
fs/f2fs/file.c| 26 ++
fs/f2fs/segment.c | 2 +-
4 files changed, 24 insertions(+), 16 deletion
long
Signed-off-by: Yongpeng Yang
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
ted by do_garbage_collect should immediately terminate the
current GC.
Signed-off-by: Yongpeng Yang
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
port data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 20 ++--
fs/f2fs/data.c | 3 ++-
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 1122db8cc0b0..a1426c3eadcc 100644
--- a/fs/f2fs/compress.c
From: Sheng Yong
Compressed cluster may not be released due to we can fail in
release_compress_blocks(), fix to handle reserved compressed
cluster correctly in reserve_compress_blocks().
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Sheng Yong
Signed-off-b
If data block in compressed cluster is not persisted with metadata
during checkpoint, after SPOR, the data may be corrupted, let's
guarantee to write compressed page by checkpoint.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c |
oduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Signed-off-by: Chao Yu
---
fs/f2fs/data.c| 5 +++--
fs/f2fs/f2fs.h| 7 ++-
fs/f2fs/file.c| 26 ++
fs/f2fs/segment.c | 2 +-
4 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f
verify_blkaddr() will trigger panic once we inject fault into
f2fs_is_valid_blkaddr(), fix to remove this unnecessary f2fs_bug_on().
Fixes: 18792e64c86d ("f2fs: support fault injection for
f2fs_is_valid_blkaddr()")
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 4 +---
1 file changed, 1
that
we can:
a) use FAULT_INCONSISTENCE in f2fs_truncate_data_blocks_range() to
simulate inconsistent issue independently,
b) FAULT_BLKADDR fault will not cause any inconsistent status, we can
just use it to check error path handling in kernel side.
Signed-off-by: Chao Yu
---
Documentation/ABI/testing/sysfs-fs
On 2023/12/20 9:59, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks
On 2023/12/19 12:09, Zhiguo Niu wrote:
On Tue, Dec 19, 2023 at 12:00 PM Chao Yu wrote:
On 2023/12/19 10:21, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed
On 2023/12/19 10:21, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
---
changes of v2: Improve the patch according to Chao's
On 2023/12/18 19:07, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks
On 2023/12/12 13:23, Zhiguo Niu wrote:
unify the error handling of ERROR_INVALID_BLKADDR in f2fs_is_valid_blkaddr
and remove some redundant codes in f2fs_cache_compressed_page.
Signed-off-by: Zhiguo Niu
---
changes of v2: improve patch according Chao's suggestions.
---
---
eturn EFSCORRUPTED, but try to run online
repair")
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/12/8 16:50, Zhiguo Niu wrote:
Should check return value of f2fs_recover_xattr_data in
__f2fs_setxattr rather than doing invalid retry if error happen.
Also just do set_page_dirty in f2fs_recover_xattr_data when
page is changed really.
Fixes: 50a472bbc79f ("f2fs: do not return
On 2023/12/1 13:42, Zhiguo Niu wrote:
unify the error handling of f2fs_is_valid_blkaddr and remove some
redundant codes in f2fs_cache_compressed_page.
What about moving f2fs_handle_error(ERROR_INVALID_BLKADDR) into
f2fs_is_valid_blkaddr() for cleanup?
Thanks,
Signed-off-by: Zhiguo Niu
---
On 2023/12/12 6:11, Jaegeuk Kim wrote:
On 12/10, Chao Yu wrote:
This patch adds i_size check during compress inode conversion in order
to avoid .page_mkwrite races w/ conversion.
Which race condition do you see?
Something like:
- f2fs_setflags_common
- check S_ISREG && F2FS_HA
In f2fs_preallocate_blocks(), if it is partial write in 4KB, it's not
necessary to call f2fs_map_blocks() and set FI_PREALLOCATED_ALL flag.
Cc: Eric Biggers
Signed-off-by: Chao Yu
---
v2:
- clean up codes
fs/f2fs/file.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs
In f2fs_filemap_fault(), it fixes to update iostat info only if
VM_FAULT_LOCKED is tagged in return value of filemap_fault().
Fixes: 8b83ac81f428 ("f2fs: support read iostat")
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch adds i_size check during compress inode conversion in order
to avoid .page_mkwrite races w/ conversion.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 8 +++-
fs/f2fs/file.c | 5 ++---
2 files changed, 9 insert
f2fs_move_file_range() doesn't support migrating compressed cluster
data, let's add the missing check condition and return -EOPNOTSUPP
for the case until we support it.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 5 +
1 file
In f2fs_preallocate_blocks(), if it is partial write in 4KB, it's not
necessary to call f2fs_map_blocks() and set FI_PREALLOCATED_ALL flag.
Cc: Eric Biggers
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/file.c
to
out-of-order GC and common IO.
- f2fs_read_end_io
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 7 ---
1 file changed, 4 insertions(+), 3 deletion
o tag
gcing flag on page during file defragment").
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 4 +++-
fs/f2fs/file.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index b35be5799726..c5a4364c4482 100644
--- a/fs/f2fs/
Just cleanup, no logic changes.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c| 8 +++-
fs/f2fs/f2fs.h| 7 +++
fs/f2fs/gc.c | 5 ++---
fs/f2fs/segment.c | 14 --
4 files changed, 16 insertions(+), 18 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index
ge as zero.
After commit 7bc155fec5b3 ("f2fs: kill volatile write support"), we
won't support volatile write, but it missed to remove obsolete
FI_FIRST_BLOCK_WRITTEN, delete it in this patch.
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 2 --
fs/f2fs/data.c | 2 --
fs/f2fs/f2fs.h
Just cleanup, no logic changes.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 11 ++-
fs/f2fs/f2fs.h | 18 +++---
fs/f2fs/file.c | 8 +---
fs/f2fs/inode.c | 32 ++--
4 files changed, 32 insertions(+), 37 deletions(-)
diff --git a/fs/f2fs
This patch allows caller to pass blkaddr to f2fs_set_data_blkaddr()
and let __set_data_blkaddr() inside f2fs_set_data_blkaddr() to update
dn->data_blkaddr w/ last value of blkaddr.
Just cleanup, no logic changes.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 13 ++---
fs/f2fs/f2fs.h |
FI_DROP_CACHE was introduced in commit 1e84371ffeef ("f2fs: change
atomic and volatile write policies") for volatile write feature,
after commit 7bc155fec5b3 ("f2fs: kill volatile write support"),
we won't support volatile write, let's delete related codes.
Signed-off-by: C
This patch adds to support tracepoint for f2fs_vm_page_mkwrite(),
meanwhile it prints more details for trace_f2fs_filemap_fault().
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 25 ++--
include/trace/events/f2fs.h | 39 -
2
On 2023/11/28 20:51, Wu Bo wrote:
On 2023/11/28 14:22, Chao Yu wrote:
On 2023/11/17 7:34, Wu Bo wrote:
On 2023/11/11 12:49, Chao Yu wrote:
On 2023/11/8 21:48, Wu Bo wrote:
On 2023/11/7 22:39, Chao Yu wrote:
On 2023/10/30 17:40, Wu Bo wrote:
If GC victim has pinned block, it can't
On 2023/11/30 17:23, Yangtao Li wrote:
Remove unnecessary code logic.
Signed-off-by: Yangtao Li
---
fs/f2fs/compress.c | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index
This patch supports to show i_mode field in trace_f2fs_new_inode().
Signed-off-by: Chao Yu
---
include/trace/events/f2fs.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 36d9e29ca3c5
This patch adds tracepoints for f2fs_rename().
Signed-off-by: Chao Yu
---
fs/f2fs/namei.c | 16 ++---
include/trace/events/f2fs.h | 69 +
2 files changed, 80 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index
s: 7e01e7ad746b ("f2fs: support RENAME_WHITEOUT")
Cc: Jan Kara
Reported-by: Al Viro
Signed-off-by: Chao Yu
---
fs/f2fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 3b1793cfb002..ede6afb81762 100644
--- a/fs/f2fs/namei.c
On 2023/11/20 15:55, Maxim Korotkov wrote:
Case of failed memory allocation of dev->zone_cap_blocks
doesn't release heap allocated rep
Found by RASU JSC
Fixes: f8410857b7a8(f2fs-tools: zns zone-capacity support)
Signed-off-by: Maxim Korotkov
Reviewed-by: Chao Yu
Tha
On 2023/11/17 7:34, Wu Bo wrote:
On 2023/11/11 12:49, Chao Yu wrote:
On 2023/11/8 21:48, Wu Bo wrote:
On 2023/11/7 22:39, Chao Yu wrote:
On 2023/10/30 17:40, Wu Bo wrote:
If GC victim has pinned block, it can't be recycled.
And if GC is foreground running, after many failure try, the pinned
On 2023/11/20 17:54, Yangtao Li wrote:
NFSv4 mandates a change attribute to avoid problems with timestamp
granularity, which Linux implements using the i_version counter. This is
particularly important when the underlying filesystem is fast.
Signed-off-by: Yangtao Li
---
fs/f2fs/f2fs.h | 1
On 2023/11/24 9:08, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information, which is not very meaningful. More discard information
can be shown so that we can check them through sysfs when needed.
What about adding this entry to /sys/fs/f2fs//stat/?
On 2023/11/28 8:52, Daniel Rosenberg wrote:
On Sun, Nov 26, 2023 at 5:42 PM Chao Yu wrote:
Hi Daniel,
How about this? It be more explicit to indicate the logic?
---
fsck/mount.c | 2 ++
include/f2fs_fs.h | 3 +++
lib/libf2fs_io.c | 4
3 files changed, 9 insertions
Hi Yonggil,
On 2023/10/26 17:18, Yonggil Song wrote:
Overview
Introduce a new way to select the data section first when selecting a
victim in foreground GC. This victim selection method works when the
prefer_data_victim mount option is enabled. If foreground GC migrates only
data
On 2023/11/18 10:03, Daniel Rosenberg wrote:
The initial sizes for dqblk.dqb_curspace should reflect the block size,
as that's the minimal filesize.
Signed-off-by: Daniel Rosenberg
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
On 2023/11/18 10:03, Daniel Rosenberg wrote:
The cache is initialized during the first read, however, it requires the
block size to establish its buffer. This disables the cache until the
block size is known.
Hi Daniel,
How about this? It be more explicit to indicate the logic?
---
On 2023/11/18 10:03, Daniel Rosenberg wrote:
The conversion from block size to MB in this debug statement assumes a
block size of 4K. This switches it to properly use the filesystem's
block size.
Signed-off-by: Daniel Rosenberg
Reviewed-by: Chao Yu
Thanks
.
Signed-off-by: Chao Yu
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
fs/f2fs/f2fs.h | 7 +++
fs/f2fs/segment.c | 6 +-
fs/f2fs/sysfs.c | 9 +
4 files changed, 27 insertions(+), 1 deletion(-)
diff
On 2023/11/18 4:38, Daeho Jeong wrote:
From: Daeho Jeong
Fixes: 0f503e443ccb ("f2fs-tools: do not reuse corrupted quota inodes")
Signed-off-by: Daeho Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-
On 2023/11/18 1:41, Jaegeuk Kim wrote:
Not sure other cases yet.. let's do one by one, since I hit this in real.
Sure.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thansk,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel
;
Signed-off-by: Chao Yu
---
fs/f2fs/recovery.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index b56d0f1078a7..16415c770b45 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -712,7 +712,16 @@ static
f2fs_fiemap() will only traverse metadata of inode, let's use shared
inode lock for it to avoid unnecessary race on inode lock.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 4e42b5f24deb
Just cleanup, no logic changes.
Signed-off-by: Chao Yu
---
fs/f2fs/namei.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index d0053b0284d8..a9360ee02da1 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -459,7 +459,6 @@ static
On 2023/10/27 23:49, Daeho Jeong wrote:
From: Daeho Jeong
If we write CP_UMOUNT_FLAG in fsck, f2fs will not do foll forward recovery
:s/foll/roll
Otherwise, it looks good to me.
Reviewed-by: Chao Yu
Thanks,
even though it has to do.
Signed-off-by: Daeho Jeong
---
fsck/fsck.c
On 2023/10/27 23:30, Daeho Jeong wrote:
From: Daeho Jeong
We might allocate more node blocks than total_valid_node_count, when we
recreate quota files.
Signed-off-by: Daeho Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
when writing xattrs. So, the kernel relies on
the unused space containing zeroes.
Also, add a missing free() to fix a memory leak.
Signed-off-by: Eric Biggers
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel
On 2023/10/23 23:50, Jaegeuk Kim wrote:
From: Daeho Jeong
Detect and fix a corrupted xattr entry.
Signed-off-by: Daeho Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https
On 2023/10/27 8:21, Daeho Jeong wrote:
From: Daeho Jeong
When we detect quota inode corruption, we better deallocate the current
space and allocate new ones for a clean start.
Signed-off-by: Daeho Jeong
---
v2: change node count check when creating a new node block
---
fsck/fsck.c|
On 2023/10/20 10:39, Jaegeuk Kim wrote:
Let's add list/set/removexattrs commands.
It looks it missed to add related description in man/f2fs_io.8.
Thanks,
Signed-off-by: Jaegeuk Kim
---
- add removexattrs
tools/f2fs_io/f2fs_io.c | 107
1 file
On 2023/10/17 5:58, Jaegeuk Kim wrote:
The cache offset should have been considered multiple partitions per fd.
Let's fix.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel
On 2023/10/17 5:58, Jaegeuk Kim wrote:
This reverts commit 2835107ae3908576b41ff5f6a4e63ba7ec9a6246.
There's a report that the impact was true.
Signed-off-by: Jaegeuk Kim
Sorry for delay reply, feel free to add:
Reviewed-by: Chao Yu
Thanks
On 2023/11/15 10:45, Jaegeuk Kim wrote:
On 11/15, Chao Yu wrote:
On 2023/11/15 5:24, Jaegeuk Kim wrote:
When recovering zoned UFS, sometimes we add the same zone to discard multiple
times. Simple workaround is to bypass adding it.
What about skipping f2fs_bug_on() just for zoned UFS case? so
On 2023/11/15 5:24, Jaegeuk Kim wrote:
When recovering zoned UFS, sometimes we add the same zone to discard multiple
times. Simple workaround is to bypass adding it.
What about skipping f2fs_bug_on() just for zoned UFS case? so that the check
condition can still be used for non-zoned UFS case.
On 2023/11/8 21:48, Wu Bo wrote:
On 2023/11/7 22:39, Chao Yu wrote:
On 2023/10/30 17:40, Wu Bo wrote:
If GC victim has pinned block, it can't be recycled.
And if GC is foreground running, after many failure try, the pinned file
is expected to be clear pin flag. To enable the section
-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/11/8 20:38, zangyangyang1 wrote:
This issue comes from a static code scanning tool.
When c.sparse_mode is 1, stat_buf will not be initialized,
but it will be used next.
If this issue does not require modification, please ignore this commit.
Signed-off-by: zangyangyang1
---
Hi Sergey,
Thanks for the patch.
On 2023/10/26 4:20, Sergey Shtylyov wrote:
In check_swap_activate(), if the *while* loop exits early (0- or 1-page
long swap file), an overflow happens while calculating the value of the
span parameter as the lowest_pblock variable ends up being greater than
On 2023/11/7 12:44, Eric Biggers wrote:
From: Eric Biggers
When setting an xattr, explicitly null-terminate the xattr list. This
eliminates the fragile assumption that the unused xattr space is always
zeroed.
Signed-off-by: Eric Biggers
Reviewed-by: Chao Yu
Thanks
On 2023/11/4 15:45, ds...@lzu.edu.cn wrote:
From: Yang Hubin
The macro SUMMARY_SIZE represents the size of the struct f2fs_summary,
instead of the size of the struct summary.
Signed-off-by: Yang Hubin
Signed-off-by: Qian Haolai
Reviewed-by: Chao Yu
Thanks
On 2023/11/2 9:20, Zhiguo Niu wrote:
Because the length of task'name in task_struct can not exceed
16 characters, f2fs some thread'name cannot be fully displayed,
including important device number information.
If there are more than one partition using the f2fs file system,
it is very
On 2023/10/30 17:40, Wu Bo wrote:
If GC victim has pinned block, it can't be recycled.
And if GC is foreground running, after many failure try, the pinned file
is expected to be clear pin flag. To enable the section be recycled.
But when fallocate trigger FG_GC, GC can never recycle the pinned
301 - 400 of 6621 matches
Mail list logo
