Re: [f2fs-dev] [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Herbert Xu via Linux-f2fs-devel
Eric Biggers wrote: > > While testing this patchset I notice that none of the crypto API drivers for > crc32 or crc32c even need to be loaded on my system anymore, as everything on > my > system that uses those algorithms (such as ext4) just uses the library APIs > now. > That makes the "check /

Re: [f2fs-dev] [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Herbert Xu via Linux-f2fs-devel
On Sat, Nov 02, 2024 at 10:58:53AM +0100, Ard Biesheuvel wrote: > > At least btrfs supports a variety of checksums/hashes (crc32c, xxhash, > sha) via the shash API. OK, given that btrfs is still doing this, I think we should still register crc32c-arch conditionally. Having it point to crc32c-gene

Re: [f2fs-dev] [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-02 Thread Herbert Xu via Linux-f2fs-devel
On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote: > > The only issue resulting from *not* taking this patch is that btrfs > may misidentify the CRC32 implementation as being 'slow' and take an > alternative code path, which does not necessarily result in worse > performance. If we we