Since many filesystems have done the new mount API conversion,
we introduce the new mount API conversion in f2fs.
The series can be applied on top of the current mainline tree
and the work is based on the patches from Lukas Czerner (has
done this in ext4[1]). His patch give me a lot of ideas.
Her
Use an array of `fs_parameter_spec` called f2fs_param_specs to
hold the mount option specifications for the new mount api.
Signed-off-by: Hongbo Li
---
fs/f2fs/super.c | 86 +
1 file changed, 86 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs
Sorry, just ignore this, I will send the whole patch set later.
Thanks,
Hongbo
On 2024/8/12 17:12, Hongbo Li wrote:
Since many filesystems have done the new mount API conversion,
we introduce the new mount API conversion in f2fs.
The series can be applied on top of the current mainline tree
an
The new mount api separates option parsing and super block setup
into two distinc steps and so we need to separate the options
parsing out of the parse_options().
In order to achieve this, here we handle the mount options with
three steps:
- Firstly, we move sb/sbi out of handle_mount_opt.
A
The match_table_t and other some functions (which have been replaced
during reconstructure) now are not used, so we can remove them.
Signed-off-by: Hongbo Li
---
fs/f2fs/super.c | 264
1 file changed, 264 deletions(-)
diff --git a/fs/f2fs/super.c
The new mount api will excute .parse_param, .init_fs_context, .get_tree
and will call .remount if remount happened. So we add the necessary
functions for the fs_context_operations. If .init_fs_context is added,
the old .mount should remove.
See Documentation/filesystems/mount_api.rst for more info
The handle_mount_opt() helper is used to parse mount parameters,
and so we can rename this function to f2fs_parse_param() and set
it as .param_param in fs_context_operations.
Signed-off-by: Hongbo Li
---
fs/f2fs/super.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/
At the parsing phase of the new mount api, sbi will not be
available. So here allows sbi to be NULL in f2fs log helpers
and use that in handle_mount_opt().
Signed-off-by: Hongbo Li
---
fs/f2fs/super.c | 106 ++--
1 file changed, 57 insertions(+), 49 de
Since many filesystems have done the new mount API conversion,
we introduce the new mount API conversion in f2fs.
The series can be applied on top of the current mainline tree
and the work is based on the patches from Lukas Czerner (has
done this in ext4[1]). His patch give me a lot of ideas.
Her
In handle_mount_opt, we use fs_parameter to pass each options.
However we're still using the old API to get the options string.
There are some change about parsering options:
1. For `active_logs`, `inline_xattr_size` and `fault_injection`,
we use s32 type according the internal structure to re
Use an array of `fs_parameter_spec` called f2fs_param_specs to
hold the mount option specifications for the new mount api.
Signed-off-by: Hongbo Li
---
fs/f2fs/super.c | 79 +
1 file changed, 79 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs
At the parsing phase of mouont in the new mount api, options
value will be recorded with the context, and then it will be
used in fill_super and other helpers.
Notes that, this is a temporary status, we want remove the sb
and sbi usages in handle_mount_opt. So here the f2fs_fs_context
only records
Just move option validation out of parse_options(), and the
validation logic is enclosed within f2fs_validate_options.
Signed-off-by: Hongbo Li
---
fs/f2fs/super.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index
Does there exist CI test for f2fs? I can only write the mount test for
f2fs refer to tests/ext4/053. And I have tested this in local.
Thanks,
Hongbo
On 2024/8/14 10:39, Hongbo Li wrote:
Since many filesystems have done the new mount API conversion,
we introduce the new mount API conversion in
On 2024/8/31 1:07, Eric Sandeen wrote:
Just FWIW -
I had missed this thread when I got temporarily unsubscribed from fsdevel.
I have a series that I was hacking on for this same work, at
https://git.kernel.org/pub/scm/linux/kernel/git/sandeen/linux.git/commit/?h=f2fs-mount-api
but it's very ro
Is the subject of the email required to be [f2fs-dev][PATCH]?
Thanks,
Hongbo
On 2024/8/14 10:39, Hongbo Li wrote:
Since many filesystems have done the new mount API conversion,
we introduce the new mount API conversion in f2fs.
The series can be applied on top of the current mainline tree
and
On 2024/9/12 9:11, Chao Yu wrote:
On 2024/9/11 10:04, Hongbo Li wrote:
Is the subject of the email required to be [f2fs-dev][PATCH]?
Hongbo,
"[f2fs-dev]" prefix is added by f2fs mailing list when it forwards
your patch to someone who subscribes the list, if you receive a patch
w/o f2fs-dev
On 2025/4/24 1:08, Eric Sandeen wrote:
From: Hongbo Li
Use an array of `fs_parameter_spec` called f2fs_param_specs to
hold the mount option specifications for the new mount api.
Add constant_table structures for several options to facilitate
parsing.
Signed-off-by: Hongbo Li
[sandeen: for
On 2025/5/12 11:32, Chao Yu wrote:
On 5/8/25 23:52, Eric Sandeen wrote:
On 5/8/25 3:13 AM, Chao Yu wrote:
On 4/24/25 01:08, Eric Sandeen wrote:
From: Hongbo Li
...
+ if (ctx->qname_mask) {
+ for (i = 0; i < MAXQUOTAS; i++) {
+ if (!(ctx->qname_
On 2025/5/8 23:52, Eric Sandeen wrote:
On 5/8/25 3:13 AM, Chao Yu wrote:
On 4/24/25 01:08, Eric Sandeen wrote:
From: Hongbo Li
...
+ if (ctx->qname_mask) {
+ for (i = 0; i < MAXQUOTAS; i++) {
+ if (!(ctx->qname_mask & (1 << i)))
+
On 2025/5/13 16:59, Chao Yu wrote:
On 4/24/25 01:08, Eric Sandeen wrote:
From: Hongbo Li
The new mount api will execute .parse_param, .init_fs_context, .get_tree
and will call .remount if remount happened. So we add the necessary
functions for the fs_context_operations. If .init_fs_context
On 2025/5/14 23:30, Jaegeuk Kim wrote:
Hi, Hongbo,
It seems we're getting more issues in the patch set. May I ask for some
help sending the new patch series having all the fixes that I made as well
as addressing the concerns? You can get the patches from [1].
Ok, thank you and Chao for revie
On 2025/5/14 12:03, Chao Yu wrote:
On 5/14/25 10:33, Hongbo Li wrote:
On 2025/5/13 16:59, Chao Yu wrote:
On 4/24/25 01:08, Eric Sandeen wrote:
From: Hongbo Li
The new mount api will execute .parse_param, .init_fs_context, .get_tree
and will call .remount if remount happened. So we add th
On 2025/5/17 1:35, Jaegeuk Kim wrote:
On 05/16, Hongbo Li wrote:
On 2025/5/14 23:30, Jaegeuk Kim wrote:
Hi, Hongbo,
It seems we're getting more issues in the patch set. May I ask for some
help sending the new patch series having all the fixes that I made as well
as addressing the concerns?
On 2025/5/14 23:30, Jaegeuk Kim wrote:
Hi, Hongbo,
It seems we're getting more issues in the patch set. May I ask for some
help sending the new patch series having all the fixes that I made as well
as addressing the concerns? You can get the patches from [1].
[1]
https://git.kernel.org/pub/s
In handle_mount_opt, we use fs_parameter to parse each option.
However we're still using the old API to get the options string.
Using fsparams parse_options allows us to remove many of the Opt_
enums, so remove them.
The checkpoint disable cap (or percent) involves rather complex
parsing; we retai
At the parsing phase of the new mount api, sbi will not be
available. So here allows sbi to be NULL in f2fs log helpers
and use that in handle_mount_opt().
Signed-off-by: Hongbo Li
[sandeen: forward port]
Signed-off-by: Eric Sandeen
---
fs/f2fs/super.c | 90 +++--
At the parsing phase of mouont in the new mount api, options
value will be recorded with the context, and then it will be
used in fill_super and other helpers.
Note that, this is a temporary status, we want remove the sb
and sbi usages in handle_mount_opt. So here the f2fs_fs_context
only records
In this version, we have finished the issues pointed in v3.
First, I'd like to express my sincere thanks to Jaegeuk and Chao
for reviewing this patch series and providing corrections. I also
appreciate Eric for rebasing the patches onto the latest branch to
ensure forward compatibility.
The latest
Use an array of `fs_parameter_spec` called f2fs_param_specs to
hold the mount option specifications for the new mount api.
Add constant_table structures for several options to facilitate
parsing.
Signed-off-by: Hongbo Li
[sandeen: forward port, minor fixes and updates, more fsparam_enum]
Signed-
On 2025/6/3 0:05, Jaegeuk Kim wrote:
Thanks you, Hongbo.
I just applied this series to the dev-test branch as below, and will
keep testing with incoming patches together. Let's see. :)
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test
Ok, I will keep followin
The new mount api separates option parsing and super block setup
into two distinct steps and so we need to separate the options
parsing out of the parse_options().
In order to achieve this, here we handle the mount options with
three steps:
- Firstly, we move sb/sbi out of handle_mount_opt.
The handle_mount_opt() helper is used to parse mount parameters,
and so we can rename this function to f2fs_parse_param() and set
it as .param_param in fs_context_operations.
Signed-off-by: Hongbo Li
[sandeen: forward port]
Signed-off-by: Eric Sandeen
---
fs/f2fs/super.c | 8 ++--
1 file ch
The new mount api will execute .parse_param, .init_fs_context, .get_tree
and will call .remount if remount happened. So we add the necessary
functions for the fs_context_operations. If .init_fs_context is added,
the old .mount should remove.
See Documentation/filesystems/mount_api.rst for more inf
On 2025/7/7 20:17, Chao Yu wrote:
On 6/2/25 17:02, Hongbo Li wrote:G
The new mount api separates option parsing and super block setup
into two distinct steps and so we need to separate the options
parsing out of the parse_options().
In order to achieve this, here we handle the mount options
On 2025/7/4 11:27, Chao Yu wrote:
On 6/2/25 17:02, Hongbo Li wrote:
In handle_mount_opt, we use fs_parameter to parse each option.
However we're still using the old API to get the options string.
Using fsparams parse_options allows us to remove many of the Opt_
enums, so remove them.
The che
In this version, we have finished the issues pointed in v4.
First, I'd like to express my sincere thanks to Jaegeuk and Chao
for reviewing this patch series and providing corrections. I also
appreciate Eric for rebasing the patches onto the latest branch to
ensure forward compatibility.
The latest
The handle_mount_opt() helper is used to parse mount parameters,
and so we can rename this function to f2fs_parse_param() and set
it as .param_param in fs_context_operations.
Signed-off-by: Hongbo Li
[sandeen: forward port]
Signed-off-by: Eric Sandeen
---
fs/f2fs/super.c | 8 ++--
1 file ch
The new mount api separates option parsing and super block setup
into two distinct steps and so we need to separate the options
parsing out of the parse_options().
In order to achieve this, here we handle the mount options with
three steps:
- Firstly, we move sb/sbi out of handle_mount_opt.
Use an array of `fs_parameter_spec` called f2fs_param_specs to
hold the mount option specifications for the new mount api.
Add constant_table structures for several options to facilitate
parsing.
Signed-off-by: Hongbo Li
[sandeen: forward port, minor fixes and updates, more fsparam_enum]
Signed-
At the parsing phase of mouont in the new mount api, options
value will be recorded with the context, and then it will be
used in fill_super and other helpers.
Note that, this is a temporary status, we want remove the sb
and sbi usages in handle_mount_opt. So here the f2fs_fs_context
only records
At the parsing phase of the new mount api, sbi will not be
available. So here allows sbi to be NULL in f2fs log helpers
and use that in handle_mount_opt().
Signed-off-by: Hongbo Li
[sandeen: forward port]
Signed-off-by: Eric Sandeen
---
fs/f2fs/super.c | 90 +++--
The new mount api will execute .parse_param, .init_fs_context, .get_tree
and will call .remount if remount happened. So we add the necessary
functions for the fs_context_operations. If .init_fs_context is added,
the old .mount should remove.
See Documentation/filesystems/mount_api.rst for more inf
In handle_mount_opt, we use fs_parameter to parse each option.
However we're still using the old API to get the options string.
Using fsparams parse_options allows us to remove many of the Opt_
enums, so remove them.
The checkpoint disable cap (or percent) involves rather complex
parsing; we retai
On 2025/7/10 20:14, Hongbo Li wrote:
In this version, we have finished the issues pointed in v4.
First, I'd like to express my sincere thanks to Jaegeuk and Chao
for reviewing this patch series and providing corrections. I also
appreciate Eric for rebasing the patches onto the latest branch to
On 2025/7/10 1:48, Jaegeuk Kim wrote:
Hongbo,
Could you please post v5?
Ok, so I summary the new comments:
1. The missing in f2fs_check_opt_consistency for bggc_mode(off) with
blkzoned.
2. The 0day-ci robot reports in [1]
[1]
https://lore.kernel.org/oe-kbuild-all/20250704.t8n0otve-
46 matches
Mail list logo
