Re: [f2fs-dev] [PATCH 3/4] f2fs: handle error of f2fs_iget correctly

2015-08-11 Thread Jaegeuk Kim
On Tue, Aug 11, 2015 at 06:42:19PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, August 11, 2015 3:32 AM To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org; linux-fsde

Re: [f2fs-dev] Data lost in Android app for not write new checkpoint

2015-08-04 Thread Jaegeuk Kim
Hi He, On Tue, Aug 04, 2015 at 09:16:21PM +0800, He YunLei wrote: On 2015/7/31 18:49, Chao Yu wrote: Hi Bintian, -Original Message- From: He YunLei [mailto:heyun...@huawei.com] Sent: Friday, July 31, 2015 10:29 AM To: linux-f2fs-devel@lists.sourceforge.net; Jaegeuk Kim Cc

Re: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages

2015-08-04 Thread Jaegeuk Kim
On Wed, Jul 29, 2015 at 05:32:00PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, July 28, 2015 11:57 PM To: Chao Yu Cc: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel

Re: [f2fs-dev] general stability of f2fs?

2015-08-10 Thread Jaegeuk Kim
Hi Marc, I'm very interested in trying f2fs on SMR drives too. I also think that several characteristics of SMR drives are very similar with flash drives. So far, the f2fs has been well performed on embedded systems like smart phones. For server environement, however, I couldn't actually test

Re: [f2fs-dev] general stability of f2fs?

2015-08-10 Thread Jaegeuk Kim
On Mon, Aug 10, 2015 at 10:53:32PM +0200, Marc Lehmann wrote: On Mon, Aug 10, 2015 at 01:31:06PM -0700, Jaegeuk Kim jaeg...@kernel.org wrote: I'm very interested in trying f2fs on SMR drives too. I also think that several characteristics of SMR drives are very similar with flash

Re: [f2fs-dev] [PATCH 3/4] f2fs: handle error of f2fs_iget correctly

2015-08-10 Thread Jaegeuk Kim
Hi Chao, On Fri, Aug 07, 2015 at 06:41:02PM +0800, Chao Yu wrote: In recover_orphan_inode, if f2fs_iget failed, we change to report the error number to its caller instead of bug_on. Let's keep this in order to catch any bugs. Or, is there another issue on this? Thanks, Signed-off-by: Chao

[f2fs-dev] [PATCH 1/2] f2fs: increase the number of max hard links

2015-08-10 Thread Jaegeuk Kim
This patch increases the number of maximum hard links for one file. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 3884794..f18d31e 100644 --- a/fs/f2fs/f2fs.h +++ b/fs

[f2fs-dev] [PATCH 1/3] mkfs.f2fs: fix wrong documentation

2015-08-10 Thread Jaegeuk Kim
The -s should be the number of segments per a section. Reported-by: Marc Lehmann schm...@schmorp.de Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- man/mkfs.f2fs.8 | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/man/mkfs.f2fs.8 b/man/mkfs.f2fs.8 index f386ac6

[f2fs-dev] [PATCH 3/3] mkfs.f2fs: don't need to limit MIN_VOLUME SIZE

2015-08-10 Thread Jaegeuk Kim
The minimum volume size is determined while preparing superblock. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- include/f2fs_fs.h | 1 - lib/libf2fs.c | 7 --- 2 files changed, 8 deletions(-) diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index 59cc0d1..38a774c 100644

Re: [f2fs-dev] general stability of f2fs?

2015-08-14 Thread Jaegeuk Kim
On Thu, Aug 13, 2015 at 02:26:41AM +0200, Marc Lehmann wrote: Okay, let me jump into the original issues. I still haven't found the right kernel for my main server, but I did some preliminary experiments today, with 3.19.8-ckt5 (an ubuntu kernel). I backported the latest f2fs into 3.19 here.

Re: [f2fs-dev] [PATCH 1/2] f2fs: increase the number of max hard links

2015-08-14 Thread Jaegeuk Kim
Change log from v1: o increase to the maximum since we have 32 bit structure From 448ffa6a623cae1c3537114b9d10f92d1ddf03f5 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaeg...@kernel.org Date: Mon, 10 Aug 2015 15:01:12 -0700 Subject: [PATCH] f2fs: increase the number of max hard links This patch

[f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-14 Thread Jaegeuk Kim
memory pressure. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c| 3 +-- fs/f2fs/f2fs.h| 15 +++ fs/f2fs/segment.c | 14 +++--- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index cad9ebe..726e58b 100644

[f2fs-dev] [PATCH 2/2] f2fs: avoid garbage collecting already moved node blocks

2015-08-14 Thread Jaegeuk Kim
If node blocks were already moved, we don't need to move them again. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/gc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 81de28d8..0a5d573 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: skip checkpoint if there is no dirty segments

2015-08-11 Thread Jaegeuk Kim
Change log from v1: - fix skipping gc incorrectly From 06f90d3757a6b7ff524cc112168488f31bbf830f Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaeg...@kernel.org Date: Tue, 11 Aug 2015 21:59:49 -0700 Subject: [PATCH] f2fs: skip checkpoint if there is no dirty and prefree segments We should avoid

Re: [f2fs-dev] f2fs: callers take care of the page from bio error

2015-08-12 Thread Jaegeuk Kim
Hi Dan, On Wed, Aug 12, 2015 at 01:40:10PM +0300, Dan Carpenter wrote: Hello Jaegeuk Kim, The patch 86531d6b84bc: f2fs: callers take care of the page from bio error from Jul 15, 2015, leads to the following static checker warning: fs/f2fs/node.c:1042 ra_node_page() warn

[f2fs-dev] [GIT PULL] f2fs urgent fix

2015-07-27 Thread Jaegeuk Kim
) Jaegeuk Kim (2): f2fs: handle error cases in move_encrypted_block f2fs: call set_page_dirty to attach i_wb for cgroup fs/f2fs/data.c| 2 -- fs/f2fs/file.c| 7 --- fs/f2fs/gc.c | 30 +- fs/f2fs/inline.c | 2 ++ fs/f2fs/segment.c | 1 + 5

Re: [f2fs-dev] [PATCH] f2fs: initialize both two copies of NAT and SIT area

2015-07-24 Thread Jaegeuk Kim
Hi Yunlei, On Fri, Jul 24, 2015 at 05:55:58PM +0800, He YunLei wrote: Hi Jaegeuk On 2015/7/24 2:18, Jaegeuk Kim wrote: Hi Yunlei, On Thu, Jul 23, 2015 at 09:43:04AM +0800, Yunlei He wrote: In the process of formatting, we zero out only one copy of NAT and SIT area, but we use both of them

Re: [f2fs-dev] [PATCH 1/2] f2fs: reorganize __f2fs_add_link

2015-07-24 Thread Jaegeuk Kim
Hi Chao, On Fri, Jul 24, 2015 at 06:31:16PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, July 24, 2015 2:15 AM To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org Subject

Re: [f2fs-dev] [PATCH 1/2] f2fs: reorganize __f2fs_add_link

2015-07-24 Thread Jaegeuk Kim
Hi Chao, BTW, isn't there any problem on update_inode/mark_inode_dirty stuffs? And, is there a hole to write uncompleted node pages unnecessarily? On Fri, Jul 24, 2015 at 08:52:00AM -0700, Jaegeuk Kim wrote: Hi Chao, On Fri, Jul 24, 2015 at 06:31:16PM +0800, Chao Yu wrote: Hi Jaegeuk

[f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages

2015-07-25 Thread Jaegeuk Kim
This patch adds to handle error cases in commit_inmem_pages. If an error occurs, it stops to write the pages and return the error right away. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h| 2 +- fs/f2fs/file.c| 6 -- fs/f2fs/segment.c | 10 -- 3 files

Re: [f2fs-dev] [PATCH] f2fs: initialize both two copies of NAT and SIT area

2015-07-23 Thread Jaegeuk Kim
Hi Yunlei, On Thu, Jul 23, 2015 at 09:43:04AM +0800, Yunlei He wrote: In the process of formatting, we zero out only one copy of NAT and SIT area, but we use both of them when the filesystem is sucessfully mounted. So I change the code to initialize both of two copies in mkfs. After mounted,

[f2fs-dev] [PATCH 1/2] f2fs: handle error cases in move_encrypted_block

2015-07-14 Thread Jaegeuk Kim
This patch fixes some missing error handlers. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/gc.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 11046db..db11861 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs

[f2fs-dev] [PATCH 2/2] f2fs: use a page temporarily for encrypted gced page

2015-07-14 Thread Jaegeuk Kim
That encrypted page is used temporarily, so we don't need to mark it accessed. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/gc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index db11861..ca562df 100644 --- a/fs/f2fs/gc.c +++ b

Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file

2015-07-14 Thread Jaegeuk Kim
On Tue, Jul 14, 2015 at 06:10:50PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Chao Yu [mailto:yuchaoch...@hotmail.com] Sent: Thursday, July 09, 2015 12:16 AM To: 'Jaegeuk Kim' Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject

[f2fs-dev] [PATCH 1/3] f2fs: callers take care of the page from bio error

2015-07-15 Thread Jaegeuk Kim
This patch changes for a caller to handle the page after its bio gets an error. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/checkpoint.c | 4 +++- fs/f2fs/data.c | 27 +-- fs/f2fs/node.c | 21 ++--- 3 files changed, 26 insertions

[f2fs-dev] [PATCH 2/3] f2fs: handle error cases in move_encrypted_block

2015-07-15 Thread Jaegeuk Kim
This patch fixes some missing error handlers. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/gc.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 93aff5b..22007ad 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs

[f2fs-dev] [PATCH 3/3] f2fs: allow zeroed name length during find_dentry

2015-07-15 Thread Jaegeuk Kim
Since find_dentry doesn't lock its dentry page, it can traverse intermediate bit positions consisting of a big dentry. For these bit positions, this patch fills the intermediate name length fields as zeros and skips them during look-up. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs

Re: [f2fs-dev] [PATCH 1/2] f2fs: handle error cases in move_encrypted_block

2015-07-15 Thread Jaegeuk Kim
On Wed, Jul 15, 2015 at 09:39:47AM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, July 15, 2015 3:18 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page

2015-07-13 Thread Jaegeuk Kim
Hi Chao, On Sat, Jul 11, 2015 at 10:02:51AM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 11, 2015 8:17 AM To: Chao Yu; Chao Yu Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH f2fs] f2fs: f2fs_write_cache_pages() can be static

2015-07-13 Thread Jaegeuk Kim
Merged this into the original patch. Thanks, On Tue, Jul 14, 2015 at 08:23:34AM +0800, kbuild test robot wrote: Signed-off-by: Fengguang Wu fengguang...@intel.com --- data.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Jaegeuk Kim
Hi Chao, On Mon, Aug 24, 2015 at 09:54:23AM -0700, Jaegeuk Kim wrote: On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote: In following call stack, if unfortunately we lose all chances to truncate inode page in remove_inode_page, eventually we will add the nid allocated previously

Re: [f2fs-dev] [PATCH] f2fs: support file defragment

2015-10-22 Thread Jaegeuk Kim
Hi, On Thu, Oct 22, 2015 at 07:59:14PM +0800, Chao Yu wrote: > This patch introduces a new ioctl F2FS_IOC_DEFRAGMENT to support file > defragment in a specified range of regular file. > > This ioctl can be used in very limited workload: if user expects high > sequential read performance in

Re: [f2fs-dev] [PATCH] f2fs: support file defragment

2015-10-26 Thread Jaegeuk Kim
Hi, On Fri, Oct 23, 2015 at 02:57:03PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Friday, October 23, 2015 2:12 AM > > To: Chao Yu > > Cc: linux-f2fs-devel@lists.sourcefor

Re: [f2fs-dev] Reservation amount

2015-10-21 Thread Jaegeuk Kim
> On Wednesday, October 21, 2015 5:36 AM, Chao Yu <chao2...@samsung.com> wrote: > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Wednesday, October 21, 2015 2:32 AM > > To: Chao Yu > > Cc: 'Chao Yu'; linux-f2fs-devel@li

[f2fs-dev] [PATCH] f2fs: refactor __find_rev_next_{zero}_bit

2015-10-21 Thread Jaegeuk Kim
This patch refactors __find_rev_next_{zero}_bit which was disabled previously due to bugs. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/segment.c | 106 +- 1 file changed, 49 insertions(+), 57 deletions(-) diff --git a/f

[f2fs-dev] [PATCH] fsck.f2fs: support a preen mode

2015-10-23 Thread Jaegeuk Kim
Generic fsck uses -p, preen mode, and fsck.f2fs can support it as -a for now. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fsck/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fsck/main.c b/fsck/main.c index b5ad46e..844ee8a 100644 --- a/fsck/main.c

Re: [f2fs-dev] [PATCH] f2fs: refactor __find_rev_next_{zero}_bit

2015-10-21 Thread Jaegeuk Kim
On Wed, Oct 21, 2015 at 02:16:43PM -0700, Jaegeuk Kim wrote: > This patch refactors __find_rev_next_{zero}_bit which was disabled previously > due to bugs. > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > --- >

[f2fs-dev] [PATCH 1/2] f2fs: fix leakage of inmemory atomic pages

2015-10-21 Thread Jaegeuk Kim
If we got failure during commit_atomic_write, abort_volatile_write will be called, but will not drop the inmemory pages due to no FI_ATOMIC_FILE. Actually, there is no reason to check the flag in abort_volatile_write. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/file.

[f2fs-dev] [PATCH 2/2] f2fs: don't need to submit bio on error case

2015-10-21 Thread Jaegeuk Kim
If commit_atomic_write is failed, we don't need to submit any bio. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 7835e41..7efd96ad 100644 --- a/f

Re: [f2fs-dev] next-20151021 - compile error in fs/f2fs/checkpoint.c

2015-10-21 Thread Jaegeuk Kim
On Thu, Oct 22, 2015 at 09:47:22AM +0800, Chao Yu wrote: > Hello, > > > -Original Message- > > From: Valdis Kletnieks [mailto:valdis.kletni...@vt.edu] > > Sent: Thursday, October 22, 2015 2:06 AM > > To: Chao Yu; Jaegeuk Kim; Changman Lee > > Cc: li

Re: [f2fs-dev] [PATCH] Doc: f2fs: Fix typos in Documentation/filesystems/f2fs.txt

2015-11-16 Thread Jaegeuk Kim
On Mon, Nov 16, 2015 at 08:35:16AM -0800, Randy Dunlap wrote: > On 11/16/15 03:46, Masanari Iida wrote: > > This patch fix some typos in Documentation/filesystems/f2fs.txt > > > > Signed-off-by: Masanari Iida > > --- > > Documentation/filesystems/f2fs.txt | 8 > >

Re: [f2fs-dev] blog article about f2fs on smr drives

2015-11-16 Thread Jaegeuk Kim
On Tue, Nov 17, 2015 at 12:52:47AM +0100, Marc Lehmann wrote: > On Mon, Nov 16, 2015 at 12:31:06PM +0800, Chao Yu > wrote: > > I think you could get the change information in below link: > > > > http://sourceforge.net/p/linux-f2fs/mailman/message/34427519/ > > Right, I

[f2fs-dev] [GIT PULL] f2fs updates for v4.4

2015-11-05 Thread Jaegeuk Kim
e code of f2fs_update_extent_tree_range Jaegeuk Kim (22): f2fs: cover number of dirty node pages under node_write lock f2fs: no need to lock for update_inode_page all the time f2fs: declare f2fs_update_extent_tree_range as static f2fs crypto: allocate buffer for decrypting filename f2fs: check

[f2fs-dev] [PATCH] f2fs: convert inline_data for f2fs_fiemap

2015-10-16 Thread Jaegeuk Kim
For fiemap, we should convert inline_data for user. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/data.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 77dfc9e..174a299 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@

[f2fs-dev] [PATCH 2/2] f2fs: support fiemap for inline_data

2015-10-19 Thread Jaegeuk Kim
There is a FIEMAP_EXTENT_INLINE_DATA, pointed out by Marc. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/data.c | 6 ++ fs/f2fs/f2fs.h | 2 ++ fs/f2fs/inline.c | 36 3 files changed, 44 insertions(+) diff --git a/fs/f2fs/data.

[f2fs-dev] [PATCH 1/2] f2fs: flush dirty data for bmap

2015-10-19 Thread Jaegeuk Kim
Users expect bmap will give allocated block addresses. Let's play likewise ext4. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/data.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 77dfc9e..b052e7c

Re: [f2fs-dev] Reservation amount

2015-10-19 Thread Jaegeuk Kim
Hello, On Mon, Oct 19, 2015 at 06:44:40PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Josh Dener [mailto:denerj...@yahoo.com] > > Sent: Sunday, October 18, 2015 12:58 PM > > To: linux-f2fs-devel@lists.sourceforge.net > > Subject: [f2fs-dev] Reservation amount >

Re: [f2fs-dev] Reservation amount

2015-10-20 Thread Jaegeuk Kim
On Tue, Oct 20, 2015 at 11:31:45PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Tuesday, October 20, 2015 2:59 AM > > To: Chao Yu; Chao Yu > > Cc: linux-f2fs-devel@lists.so

[f2fs-dev] [PATCH 2/2] Revert "f2fs: do not skip dentry block writes"

2015-10-08 Thread Jaegeuk Kim
The periodic checkpoint can resolve the previous issue. So, now we can use this again to improve the reported performance regression: https://lkml.org/lkml/2015/10/8/20 This reverts commit 15bec0ff5a9ba6d203178fa8772259df6207942a. --- fs/f2fs/data.c| 5 + fs/f2fs/node.c| 5 +

[f2fs-dev] [PATCH 1/2] f2fs: add F2FS_GOING_DOWN_METAFLUSH to test power-failure

2015-10-08 Thread Jaegeuk Kim
This patch introduces F2FS_GOING_DOWN_METAFLUSH which flushes meta pages like SSA blocks and then blocks all the writes. This can be used by power-failure tests. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 4 2 files changed, 5 inse

Re: [f2fs-dev] [PATCH] f2fs crypto: fix racing of accessing encrypted page among different competitors

2015-10-12 Thread Jaegeuk Kim
On Thu, Oct 08, 2015 at 08:50:39PM +0800, Chao Yu wrote: > >From 0211c6ed82440891b3369851d079f6c69b432b6c Mon Sep 17 00:00:00 2001 > From: Chao Yu > Date: Thu, 8 Oct 2015 13:27:34 +0800 > Subject: [PATCH] f2fs crypto: fix racing of accessing encrypted page among > different

Re: [f2fs-dev] [PATCH] f2fs: merge meta writes as many possible

2015-10-06 Thread Jaegeuk Kim
Hi Chao, On Tue, Oct 06, 2015 at 10:54:12PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Saturday, October 03, 2015 12:48 AM > > To: linux-ker...@vger.kernel.org; linux-fsde...@v

Re: [f2fs-dev] [PATCH 3/3] f2fs: introduce a periodic checkpoint flow

2015-10-06 Thread Jaegeuk Kim
On Tue, Oct 06, 2015 at 10:54:47PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Tuesday, October 06, 2015 6:44 AM > > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.ke

Re: [f2fs-dev] more gc / gc script refinements

2015-10-06 Thread Jaegeuk Kim
On Wed, Oct 07, 2015 at 12:41:45AM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Tuesday, October 06, 2015 7:17 AM > > To: Chao Yu > > Cc: 'Marc Lehmann'; linux-f2fs-devel@l

Re: [f2fs-dev] blog article about f2fs on smr drives

2015-10-08 Thread Jaegeuk Kim
On Thu, Oct 08, 2015 at 03:56:35PM +0200, Marc Lehmann wrote: > Hi! > > I write a short and very preliminary blog article about hoe to get SMR drives > to work, fast, with f2fs. > >http://blog.schmorp.de/2015-10-08-smr-archive-drives-fast-now.html > > This is just a heads up - due to

[f2fs-dev] [PATCH] f2fs: set GFP_NOFS for grab_cache_page

2015-10-09 Thread Jaegeuk Kim
grab_cache_page_write_begin() with AOP_FLAG_NOFS. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/data.c | 16 +--- fs/f2fs/dir.c | 6 +++--- fs/f2fs/f2fs.h | 12 ++-- fs/f2fs/file.c | 6 +++--- fs/f2fs/gc.c | 6 +++--- 5 files changed, 28 insertions(+), 18 deletions(-) diff

Re: [f2fs-dev] [PATCH 2/3] f2fs: add a tracepoint for background gc

2015-10-13 Thread Jaegeuk Kim
On Sat, Oct 10, 2015 at 03:08:26PM +0800, He YunLei wrote: > On 2015/10/6 6:43, Jaegeuk Kim wrote: > > This patch introduces a tracepoint to monitor background gc behaviors. > > > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > > --- > > fs/f2fs/gc.

Re: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page

2015-07-10 Thread Jaegeuk Kim
Hi Chao, On Thu, Jul 09, 2015 at 06:20:08PM +0800, Chao Yu wrote: get_new_data_page should release inode page when we encounter any error in its procedure, but there is one error path didn't cover this, fix it. Nice catch. But, I think we should fix its caller: in init_inode_metadata(),

Re: [f2fs-dev] [PATCH 2/2] f2fs: shrink unreferenced extent_caches first

2015-07-10 Thread Jaegeuk Kim
On Wed, Jul 08, 2015 at 05:41:57PM +0800, Chao Yu wrote: [snip] You're right. We don't need to drop it having the lowest ino first. Actually, I was supposed to add an LRU list for extent_trees. But, do we need to really take care of its order for already evicted inodes?

Re: [f2fs-dev] [PATCH] mkfs.f2fs: introduce -b option to support specified fs size formating

2015-11-14 Thread Jaegeuk Kim
Hello, On Sat, Nov 14, 2015 at 01:32:29PM +0800, He YunLei wrote: > hi, > > We can specify fs size in function f2fs_parse_options as follow: > if ((optind + 1) < argc) { > /* We have a sector count. */ > config.total_sectors = atoll(argv[optind+1]); > which one is better?

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-25 Thread Jaegeuk Kim
On Tue, Aug 25, 2015 at 02:38:00PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, August 25, 2015 6:53 AM To: Chao Yu Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject: Re

[f2fs-dev] [GIT PULL] f2fs updates for v4.3

2015-09-02 Thread Jaegeuk Kim
rfaces for extent tree f2fs: change the timing of f2fs_wait_on_page_writeback f2fs: use extent cache to optimize f2fs_reserve_block f2fs: fix to update cached_en of extent tree properly Jaegeuk Kim (30): f2fs: avoid freed stat information f2fs: avoid to use failed inode immed

[f2fs-dev] [PATCH] f2fs crypto: allocate buffer for decrypting filename

2015-09-10 Thread Jaegeuk Kim
ed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/dir.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 8f15fc1..f3fe1a1 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -788,8 +788,9 @@ bool f2fs_fill_dentries(struct dir_

Re: [f2fs-dev] [PATCH v2] f2fs crypto: allocate buffer for decrypting filename

2015-09-11 Thread Jaegeuk Kim
Change log from v1: o fix wrong pointer assignment >From a0f3577cab882adc70d71e733d62c48aab61c3a4 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim <jaeg...@kernel.org> Date: Thu, 3 Sep 2015 13:38:23 -0700 Subject: [PATCH] f2fs crypto: allocate buffer for decrypting filename We got dentry p

Re: [f2fs-dev] [PATCH v2] f2fs: optimize code of f2fs_update_extent_tree_range

2015-09-15 Thread Jaegeuk Kim
Hi Fan, On Thu, Sep 10, 2015 at 04:48:22PM +0800, Fan Li wrote: > Fix 3 potential problems: > 1. when largest extent needs to be invalidated, it will be reset in >__drop_largest_extent, which makes __is_extent_same after always >return false, and largest extent unchanged. Now we update it

Re: [f2fs-dev] [PATCH v3] f2fs crypto: allocate buffer for decrypting filename

2015-09-15 Thread Jaegeuk Kim
Change log from v1: o fix wrong pointer assignment Chang log from v2: o add one more missing call path: f2fs_encrypted_follow_link >From 84574dd5c3e8ed9ca9fdfcbd251b354cdbc5ecab Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim <jaeg...@kernel.org> Date: Thu, 3 Sep 2015 13:38:23 -070

[f2fs-dev] [PATCH 1/2] f2fs: cover number of dirty node pages under node_write lock

2015-09-15 Thread Jaegeuk Kim
This number is referenced by checkpoint under node_write lock. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/node.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 27d1a74..4d9bedf 100644 --- a/fs/f2fs/

[f2fs-dev] [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time

2015-09-15 Thread Jaegeuk Kim
As comment says, we don't need to call f2fs_lock_op in write_inode to prevent from producing dirty node pages all the time. That happens only when there is not enough free sections and we can avoid that by calling balance_fs in prior to that. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.

Re: [f2fs-dev] [PATCH] fs/f2fs: avoid redundant convert of inline inode

2015-09-15 Thread Jaegeuk Kim
Hi Zhang, On Tue, Sep 15, 2015 at 03:10:11PM +0800, Zhang Zhen wrote: > Encrypted inode for regular file should not have inline_data. > Here we check encrypted inode before convert of inline inode > to avoid redundant convert. When a new file is created in an encrypted dir, it does not set

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-15 Thread Jaegeuk Kim
Hi Chao, On Fri, Sep 11, 2015 at 02:41:53PM +0800, Chao Yu wrote: > When dio writes perform concurrently, our performace will be low because of > Thread A's allocation of multi continuous blocks will be break by Thread B, > there are two cases as below: > - In Thread B, we may change current

Re: [f2fs-dev] [PATCH v2] f2fs: optimize code of f2fs_update_extent_tree_range

2015-09-16 Thread Jaegeuk Kim
all the time */ - __drop_largest_extent(inode, fofs); + __drop_largest_extent(inode, fofs, len); /* 1. lookup first extent node in range [fofs, fofs + len - 1] */ en = __lookup_extent_tree_ret(et, fofs, _en, _en, -- 2.1.1 On Tue, Sep 15, 2015 at 11:36:46AM -0700, Jaegeuk Kim wrote: > Hi Fan

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-16 Thread Jaegeuk Kim
Hi Chao, On Wed, Sep 16, 2015 at 06:15:55PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Wednesday, September 16, 2015 5:21 AM > > To: Chao Yu > > Cc: linux-f2fs-de

Re: [f2fs-dev] [PATCH 2/7] f2fs: do in batches truncation in truncate_hole

2015-09-16 Thread Jaegeuk Kim
Hi Chao, How about changing the original patch slightly like below? o don't have to use index variable o should not skip the entire dnode indices, when one of them is -ENOENT --- fs/f2fs/file.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/file.c

Re: [f2fs-dev] [PATCH v4] f2fs crypto: allocate buffer for decrypting filename

2015-09-16 Thread Jaegeuk Kim
rom: Jaegeuk Kim <jaeg...@kernel.org> Date: Thu, 3 Sep 2015 13:38:23 -0700 Subject: [PATCH] f2fs crypto: allocate buffer for decrypting filename We got dentry pages from high_mem, and its address space directly goes into the decryption path via f2fs_fname_disk_to_usr. But, sg_init_on

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-17 Thread Jaegeuk Kim
Hi Chao, On Thu, Sep 17, 2015 at 08:52:10PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Thursday, September 17, 2015 2:13 AM > > To: Chao Yu > > Cc: linux-f2fs-de

Re: [f2fs-dev] [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time

2015-09-17 Thread Jaegeuk Kim
On Thu, Sep 17, 2015 at 08:19:06PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Wednesday, September 16, 2015 12:56 AM > > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.ke

Re: [f2fs-dev] write performance difference 3.18.21/4.2.1

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 05:22:18AM +0200, Marc Lehmann wrote: > On Fri, Sep 25, 2015 at 05:47:12PM +0800, Chao Yu > wrote: > > Please revert the commit 7c5e466755ff ("f2fs: readahead cp payload > > pages when mount") since in this commit we try to access invalid > >

Re: [f2fs-dev] sync/umount hang on 3.18.21, 1.4TB gone after crash

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 05:08:33AM +0200, Marc Lehmann wrote: > On Fri, Sep 25, 2015 at 11:42:02AM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > AFAIK, there-in *commit* means syncing metadata, not userdata. Doesn't it? > > In general, no, they commit userdata,

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 05:32:53AM +0200, Marc Lehmann wrote: > On Fri, Sep 25, 2015 at 10:45:46AM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > > He :) It's a nothing-special number between 64 and 128, that's all. > > > > Oh, then, I don't think that

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 07:25:51AM +0200, Marc Lehmann wrote: > Ok, before I tried the f2fs git I made another short test with the > original 3.18.21 f2fs, and it was as fast as before. Then I used the > faulty f2fs module,. which forced a reboot. > > Now I started to redo the 3.18.21 test + git

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-28 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 03:53:53PM +0200, Marc Lehmann wrote: > On Sat, Sep 26, 2015 at 12:36:55AM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > > Care to share why? :) > > > > Mostly, in the flash storages, it is multiple 2MB normally. :) > > We

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-09-28 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 03:59:57PM +0200, Marc Lehmann wrote: > On Sat, Sep 26, 2015 at 12:52:53AM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > > Just for fun I'll start doing a -s64 run. > > (which had the same result). > > > Okay, so before findi

Re: [f2fs-dev] [PATCH v2] f2fs: should get a victim from retrials

2015-09-28 Thread Jaegeuk Kim
Change log from v1: o avoid __get_victim call twice, since each call registers the victim in bitmap >From 45c3aaea805751e5c1899dd9c76d89e6f73a7a8f Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim <jaeg...@kernel.org> Date: Fri, 18 Sep 2015 17:33:00 -0700 Subject: [PATCH] f2fs: should get a vi

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-09-29 Thread Jaegeuk Kim
On Tue, Sep 29, 2015 at 01:02:04PM +0200, Marc Lehmann wrote: > On Mon, Sep 28, 2015 at 10:59:44AM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > In order to verify this also, could you retrieve the following logs? > > First thing, the allocation-failure-on-mount is

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-10-02 Thread Jaegeuk Kim
On Thu, Oct 01, 2015 at 08:51:24PM +0200, Marc Lehmann wrote: > On Thu, Oct 01, 2015 at 02:11:20PM +0200, Marc Lehmann > wrote: > > WOW, THAT HELPED A LOT. While the peak throughput seems quite a bit lower > > Ok, for completeness, here is the full log and a description of

[f2fs-dev] [PATCH] f2fs: merge meta writes as many possible

2015-10-02 Thread Jaegeuk Kim
f2fs_submit_write_bio: dev = (8,18), WRITE_SYNC(MP), META, sector = 107240, size = 270336 f2fs_submit_write_bio: dev = (8,18), WRITE_SYNC(MP), META, sector = 107768, size = 180224 ... Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/checkpoint.c | 8 +++- 1 file changed, 7 inse

Re: [f2fs-dev] 100% system time hang with git f2fs

2015-10-02 Thread Jaegeuk Kim
On Fri, Oct 02, 2015 at 10:53:40AM +0200, Marc Lehmann wrote: > On Thu, Oct 01, 2015 at 08:51:24PM +0200, Marc Lehmann > wrote: > > Ok, for completeness, here is the full log and a description of what was > > going on. > > Ok, so I did a fsck, which took one hour, which is

Re: [f2fs-dev] dir_level explained?

2015-10-05 Thread Jaegeuk Kim
On Sun, Oct 04, 2015 at 11:56:47AM +0200, Marc Lehmann wrote: > Hi! > > In all my tests I intentionally didn't play with dir_level, to get an idea of > baseline performance. I also wasn't worried because my standard response to > slow random reads is dmcache, but now that I realised I can't use

[f2fs-dev] [PATCH 1/3] f2fs: introduce background_gc=sync mount option

2015-10-05 Thread Jaegeuk Kim
This patch introduce background_gc=sync enabling synchronous cleaning in background. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- Documentation/filesystems/f2fs.txt | 3 ++- fs/f2fs/f2fs.h | 1 + fs/f2fs/gc.c | 2 +- fs/f2fs/seg

Re: [f2fs-dev] assumptions and misconceptions about f2fs behaviour, please correct

2015-10-05 Thread Jaegeuk Kim
Hello, On Sun, Oct 04, 2015 at 11:54:30AM +0200, Marc Lehmann wrote: > Hi! > > In this mail I describe what I would expect of f2fs in general, and the gc > in particular. I already know my expectations or assumptions are partially > incorrect, and will note so when I know of it. The idea of this

[f2fs-dev] [PATCH 2/3] f2fs: add a tracepoint for background gc

2015-10-05 Thread Jaegeuk Kim
This patch introduces a tracepoint to monitor background gc behaviors. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fs/f2fs/gc.c| 3 +++ include/trace/events/f2fs.h | 28 2 files changed, 31 insertions(+) diff --git a/fs/f2fs/gc.c b/f

Re: [f2fs-dev] more gc / gc script refinements

2015-10-05 Thread Jaegeuk Kim
Thanks Chao, On Mon, Oct 05, 2015 at 11:02:42PM +0800, Chao Yu wrote: > > -Original Message- > > From: Marc Lehmann [mailto:schm...@schmorp.de] > > Sent: Monday, October 05, 2015 3:26 PM > > To: linux-f2fs-devel@lists.sourceforge.net; > > linux-f2fs-devel@lists.sourceforge.net > >

Re: [f2fs-dev] [PATCH] f2fs: fix to correct freed section number during gc

2015-09-22 Thread Jaegeuk Kim
Hi Chao, On Tue, Sep 22, 2015 at 09:18:18PM +0800, Chao Yu wrote: > We pass 'nfree' to has_not_enough_free_secs to check whether there is > enough free section, but 'nfree' indicates the number of segment gced, > should alter the value to section number. Yeah, but I think we need to increase

Re: [f2fs-dev] SMR drive test 3: full 8TB partition, mount problems, fsck error after delete

2015-09-22 Thread Jaegeuk Kim
-=/_/_//_/\_,_/ /_/\_\ > > -- > ___ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinf

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-24 Thread Jaegeuk Kim
On Thu, Sep 24, 2015 at 01:43:24AM +0200, Marc Lehmann wrote: > On Thu, Sep 24, 2015 at 01:30:22AM +0200, Marc Lehmann > wrote: > > > One thing I note is that gc_min_sleep_time is not be set in your script, > > > so in some condition gc may still do the sleep with

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-24 Thread Jaegeuk Kim
On Thu, Sep 24, 2015 at 01:39:38AM +0200, Marc Lehmann wrote: > On Wed, Sep 23, 2015 at 03:08:23PM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > >root@shag:/sys/fs/f2fs/dm-1# df -H /mnt > > >FilesystemSize Used Avail Use% Mounted o

Re: [f2fs-dev] sync/umount hang on 3.18.21, 1.4TB gone after crash

2015-09-24 Thread Jaegeuk Kim
On Wed, Sep 23, 2015 at 11:58:51PM +0200, Marc Lehmann wrote: > Hi! > > I moved one of the SMR disks to another box with a 3.18.21 kernel. > > I formatted and mounted like this: > >/opt/f2fs-tools/sbin/mkfs.f2fs -lTEST -s90 -t0 -a0 /dev/vg_test/test >mount -t f2fs

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-24 Thread Jaegeuk Kim
On Thu, Sep 24, 2015 at 01:24:14AM +0200, Marc Lehmann wrote: > On Wed, Sep 23, 2015 at 02:29:31PM -0700, Jaegeuk Kim <jaeg...@kernel.org> > wrote: > > > Can you elaborate? I do get a speed improvement with only two logs, but of > > > course, GC time is an impoprt

Re: [f2fs-dev] write performance difference 3.18.21/4.2.1

2015-09-24 Thread Jaegeuk Kim
On Thu, Sep 24, 2015 at 01:11:03AM +0200, Marc Lehmann wrote: > I tried twice with the same options, on linux 3.8.21 and 4.2.1, and write > performance is very different on these kernels (I rebooted every time in > between). > > On 3.18.21, the source raid is hardly able to keep up with the write

[f2fs-dev] [PATCH] fsck.f2fs: check sit types for node or data only

2015-09-24 Thread Jaegeuk Kim
Previously, check_sit_types didn't handle different numbers of active logs and SSR cases. But, it didn't cause any problem since fixing sit types is harmless. Nevertheless, we still don't need to change them all. Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> --- fsck/fsck.

<    3   4   5   6   7   8   9   10   11   12   >