[f2fs-dev] 答复: [PATCH -next] f2fs: total hit count should only be increased when entry found

2022-09-06 Thread zhangqilong via Linux-f2fs-devel
> when entry found > > On 2022/9/5 22:12, Zhang Qilong wrote: > > We should not increase total hit count when not found the entry in > > cache extent tree. Remove the stat_inc_total_hit when > > f2fs_lookup_rb_tree returns nullptr. > > Actually, f2fs will account total lookup count into

[f2fs-dev] 答复: [PATCH] f2fs: Fix data consistency in f2fs_move_file_range()

2022-10-20 Thread zhangqilong via Linux-f2fs-devel
> On 2022/10/18 10:45, Zhang Qilong wrote: > > In the following case: > > process 1 process 2 > > ->open A > >->mmap > > ->read # the first time > > ->ioctl w/h F2FS_IOC_MOVE_RANGE > > #

[f2fs-dev] 答复: 答复: [PATCH] f2fs: Fix data consistency in f2fs_move_file_range()

2022-10-25 Thread zhangqilong via Linux-f2fs-devel
> On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote: > >> On 2022/10/18 10:45, Zhang Qilong wrote: > >>> In the following case: > >>> process 1 process 2 > >>>->open A > >>> ->mmap > >>>

[f2fs-dev] 答复: 答复: 答复: [PATCH] f2fs: Fix data consistency in f2fs_move_file_range()

2022-10-25 Thread zhangqilong via Linux-f2fs-devel
> On 2022/10/25 14:27, zhangqilong wrote: > >> On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote: > >>>> On 2022/10/18 10:45, Zhang Qilong wrote: > >>>>> In the following case: > >>>>> process 1 process

[f2fs-dev] 答复: 答复: 答复: 答复: [PATCH] f2fs: Fix data consistency in f2fs_move_file_range()

2022-10-25 Thread zhangqilong via Linux-f2fs-devel
> On 2022/10/25 15:01, zhangqilong wrote: > >> On 2022/10/25 14:27, zhangqilong wrote: > >>>> On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote: > >>>>>> On 2022/10/18 10:45, Zhang Qilong wrote: > >>>>>>>

[f2fs-dev] 答复: [PATCH -next] f2fs: add a trace interface for f2fs_update_extent_tree_range_compressed

2022-09-19 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/15 21:44, Zhang Qilong wrote: > > For f2fs_update_extent_tree_range_compressed, keeping the trace > and > > function name consistent to distinguish from trace of > > f2fs_update_extent_tree_range. And we add "c_len" into the trace, > > result like: > > > >[003] . 228.568157:

[f2fs-dev] Reply: Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-21 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/21 20:14, zhangqilong wrote: > >> On 2022/9/21 15:57, Zhang Qilong wrote: > >>> No-compressed file may suffer read performance issue due to it can't > >>> use extent cache or the largest extent in inode can't covered other > >>> parts of continuous blocks in readonly format f2fs image.

[f2fs-dev] Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-21 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/21 15:57, Zhang Qilong wrote: > > No-compressed file may suffer read performance issue due to it can't > > use extent cache or the largest extent in inode can't covered other > > parts of continuous blocks in readonly format f2fs image. > > > > Now it won't build extent cacge tree for

[f2fs-dev] Reply: Reply: Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-21 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/21 21:57, zhangqilong wrote: > >> On 2022/9/21 20:14, zhangqilong wrote: > On 2022/9/21 15:57, Zhang Qilong wrote: > > No-compressed file may suffer read performance issue due to it > > can't use extent cache or the largest extent in inode can't > > covered other parts

[f2fs-dev] 答复: [PATCH -next] f2fs: add flush_dcache_page after page was written

2022-09-12 Thread zhangqilong via Linux-f2fs-devel
> > On 2022/8/25 10:41, Zhang Qilong wrote: > > If the written page was mapped more than twice, the written data here > > will not be seen by others. We add the flush_dcache_page to fix it. > > > > Fixes:0a2aa8fbb9693 ("f2fs: refactor __exchange_data_block for speed > > up") > > Signed-off-by:

[f2fs-dev] 答复: [PATCH -next 0/3] f2fs: clean code and fix type error

2022-09-13 Thread zhangqilong via Linux-f2fs-devel
> > On 09/13, Zhang Qilong wrote: > > Found serveral code type errors when review the code and fix it. > > There is no function change. > > Could you please combine them into single patch? > Thanks, > Just fine :), I will send a new patch. Thanks, > > > > Zhang Qilong (3): > > f2fs: insert

[f2fs-dev] 答复: 答复: [PATCH -next] f2fs: adding truncate page cache after being moved

2022-09-12 Thread zhangqilong via Linux-f2fs-devel
> > On 2022/9/13 11:41, zhangqilong wrote: > >> On 2022/9/13 11:05, Zhang Qilong wrote: > >>> If we do not truncate source page cache, user can still see the > >>> previous source data after being moved. We fix it by adding > >>> truncating after __exchange_data_block. > >>> > >>>

[f2fs-dev] 答复: [PATCH -next] f2fs: adding truncate page cache after being moved

2022-09-12 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/13 11:05, Zhang Qilong wrote: > > If we do not truncate source page cache, user can still see the > > previous source data after being moved. We fix it by adding truncating > > after __exchange_data_block. > > > > Fixes:4dd6f977fc778 ("f2fs: support an ioctl to move a range of data > >

Re: [f2fs-dev] Reply: Reply: Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-22 Thread zhangqilong via Linux-f2fs-devel
> > On 2022/9/22 12:54, zhangqilong wrote: > >> On 2022/9/22 10:07, zhangqilong wrote: > On 2022/9/22 0:00, zhangqilong wrote: > >> On 2022/9/21 21:57, zhangqilong wrote: > On 2022/9/21 20:14, zhangqilong wrote: > >> On 2022/9/21 15:57, Zhang Qilong wrote: > >>>

[f2fs-dev] 答复: Reply: Reply: Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-22 Thread zhangqilong via Linux-f2fs-devel
> > On 2022/9/22 17:32, zhangqilong wrote: > >> > >> On 2022/9/22 12:54, zhangqilong wrote: > On 2022/9/22 10:07, zhangqilong wrote: > >> On 2022/9/22 0:00, zhangqilong wrote: > On 2022/9/21 21:57, zhangqilong wrote: > >> On 2022/9/21 20:14, zhangqilong wrote: >

[f2fs-dev] 答复: 答复: 答复: [PATCH -next] f2fs: adding truncate page cache after being moved

2022-09-20 Thread zhangqilong via Linux-f2fs-devel
> > On 2022/9/13 14:10, Chao Yu wrote: > > On 2022/9/13 12:37, zhangqilong wrote: > >>> > >>> On 2022/9/13 11:41, zhangqilong wrote: > > On 2022/9/13 11:05, Zhang Qilong wrote: > >> If we do not truncate source page cache, user can still see the > >> previous source data after being

Re: [f2fs-dev] Reply: Reply: Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-21 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/22 10:07, zhangqilong wrote: > >> On 2022/9/22 0:00, zhangqilong wrote: > On 2022/9/21 21:57, zhangqilong wrote: > >> On 2022/9/21 20:14, zhangqilong wrote: > On 2022/9/21 15:57, Zhang Qilong wrote: > > No-compressed file may suffer read performance issue due

Re: [f2fs-dev] Reply: Reply: Reply: [PATCH -next 2/4] f2fs: extent cache: support extent for no-compressed file

2022-09-21 Thread zhangqilong via Linux-f2fs-devel
> On 2022/9/22 0:00, zhangqilong wrote: > >> On 2022/9/21 21:57, zhangqilong wrote: > On 2022/9/21 20:14, zhangqilong wrote: > >> On 2022/9/21 15:57, Zhang Qilong wrote: > >>> No-compressed file may suffer read performance issue due to it > >>> can't use extent cache or the

[f2fs-dev] 答复: [PATCH] mkfs.f2fs: update allocation policy for ro feature

2022-09-27 Thread zhangqilong via Linux-f2fs-devel
> On 09/25, Chao Yu wrote: > > Update allocation policy for ro feature: > > - hot_data: allocating blocks by LBA ascending order > > - hot_node: allocating blocks by LBA descending order > > This will increase the RO image size. > > > > > Signed-off-by: Chao Yu > > --- > > mkfs/f2fs_format.c |