Re: [f2fs-dev] [PATCH] f2fs: avoid the deadlock case when stopping discard thread

2024-03-22 Thread Hillf Danton
On Thu, 21 Mar 2024 17:29:03 -0700 Jaegeuk Kim > > I posted this patch before Light reported. Yeah, his report's timestamp is 2024-03-20 6:59, nearly 7 hours later, which shows that you constructed the deadlock with nothing to do with his report. > > And, in the report, I didn't get this: >

Re: [f2fs-dev] [PATCH] f2fs: avoid the deadlock case when stopping discard thread

2024-03-21 Thread Hillf Danton
On Tue, 19 Mar 2024 17:14:42 -0700 Jaegeuk Kim > f2fs_ioc_shutdown(F2FS_GOING_DOWN_NOSYNC) issue_discard_thread > - mnt_want_write_file() >- sb_start_write(SB_FREEZE_WRITE) __sb_start_write() percpu_down_read() > - >

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-27 Thread Hillf Danton
On Fri, 25 Feb 2022 16:32:39 +0800 Hillf Danton wrote: > On Fri, 25 Feb 2022 09:47:16 +0800 Hillf Danton wrote: > > On Thu, 24 Feb 2022 16:47:30 +0800 Hillf Danton wrote: > > > On Sat, 8 Jan 2022 08:46:17 -0800 > > > > From: Tim Murray > > > > > &g

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-25 Thread Hillf Danton
On Fri, 25 Feb 2022 09:47:16 +0800 Hillf Danton wrote: > On Thu, 24 Feb 2022 16:47:30 +0800 Hillf Danton wrote: > > On Sat, 8 Jan 2022 08:46:17 -0800 > > > From: Tim Murray > > > > > > f2fs rw_semaphores work better if writers can starve readers, > &

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-24 Thread Hillf Danton
On Thu, 24 Feb 2022 16:47:30 +0800 Hillf Danton wrote: > On Sat, 8 Jan 2022 08:46:17 -0800 > > From: Tim Murray > > > > f2fs rw_semaphores work better if writers can starve readers, > > especially for the checkpoint thread, because writers are strictly > > m

[f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-24 Thread Hillf Danton
On Sat, 8 Jan 2022 08:46:17 -0800 > From: Tim Murray > > f2fs rw_semaphores work better if writers can starve readers, > especially for the checkpoint thread, because writers are strictly > more important than reader threads. This prevents significant priority > inversion between low-priority

Re: [f2fs-dev] [syzbot] BUG: unable to handle kernel NULL pointer dereference in f2fs_update_meta_page

2021-07-26 Thread Hillf Danton
On Sun, 25 Jul 2021 23:00:19 -0700 > syzbot found the following issue on: > > HEAD commit:6498f6151825 Merge tag 'riscv-for-linus-5.14-rc3' of git:/.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14bbce4630 > kernel config:

Re: [f2fs-dev] [PATCH] f2fs: use rwlock instead of rwsem for journal

2021-07-21 Thread Hillf Danton
On Wed, 21 Jul 2021 18:41:49 -0700 Jaegeuk Kim wrote: > >This tries to fix priority inversion in the below condition resulting in >long checkpoint delay. If you are right and the patch makes real sense, feel free to specify a bit more on the priority inversion you are trying to fix, and how the