Re: [f2fs-dev] assertion failed

2014-03-23 Thread Kim Jaegeuk
Hi, Thank you for the report. Could you share the kernel and f2fs-tools versions? Let me check. Thank you, 2014-03-23 23:22 GMT+09:00 folkert folk...@vanheusden.com: Hi, Got an assertion failed in fsck.f2fs: Info: sector size = 512 Info: total sectors = 7503872 (in 512bytes) Assertion

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
Hi, 2013/9/11 Chao Yu chao2...@samsung.com Hi Kim, I did some tests as you mention of using random instead of spin_lock. The test model is as following: eight threads race to grab one of eight locks for one thousand times, and I used four methods to generate lock num:

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
Hi Russ, The usage of fs_locks is for the recovery, so it doesn't matter with stress-testing. Actually what I've concerned is that we should not grab two or more fs_locks in the same call path. Thanks, 2013/9/11 Russ Knize russ.kn...@motorola.com: Hi Jaegeuk/Gu, I've removed the lock and have

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
Hi Gu, 2013/9/11 Gu Zheng guz.f...@cn.fujitsu.com: Hi Jaegeuk, Chao, On 09/10/2013 08:52 AM, Jaegeuk Kim wrote: Hi, At first, thank you for the report and please follow the email writing rules. :) Anyway, I agree to the below issue. One thing that I can think of is that we don't need