Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Mukesh Ojha
( __field(dev_t, dev) __field(ino_t, ino) - __field(nid_t, nid[3]) + __array(nid_t, nid, 3) Good catch. Reviewed-by: Mukesh Ojha -Mukesh __field(int,depth) __field(int,err

[f2fs-dev] [PATCH 2/2] f2fs: fix the msg data type

2022-10-27 Thread Mukesh Ojha
Data type of msg in f2fs_write_checkpoint trace should be const char * instead of char *. Signed-off-by: Mukesh Ojha --- include/trace/events/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index ff57e7f

[f2fs-dev] [PATCH v2 1/2] f2fs: fix the assign logic of iocb

2022-10-27 Thread Mukesh Ojha
0_svc+0x28/0xa0 Fix it by copying the required variables for printing and while at it fix the similar issue at some other places in the same file. Fixes: 18ae8d12991b ("f2fs: show more DIO information in tracepoint") Signed-off-by: Mukesh Ojha --- Changes in v2: - Added commit text wi

Re: [f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-20 Thread Mukesh Ojha
Hi, On 10/20/2022 2:31 PM, Chao Yu wrote: On 2022/10/20 0:17, Mukesh Ojha wrote: commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") introduces iocb field in 'f2fs_direct_IO_enter' trace event And it only assigns the pointer and later it accesses its field in trace

[f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-19 Thread Mukesh Ojha
ae8d12991b ("f2fs: show more DIO information in tracepoint") Signed-off-by: Mukesh Ojha --- include/trace/events/f2fs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index c6b3724..7727ec9 100644

Re: [f2fs-dev] [PATCH] f2fs: data: fix warning Using plain integer as NULL pointer

2019-04-06 Thread Mukesh Ojha
On 4/6/2019 4:29 PM, Hariprasad Kelam wrote: changed passing function argument "0 to NULL" to fix below sparse warning fs/f2fs/data.c:426:47: warning: Using plain integer as NULL pointer Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- fs/f2fs/

Re: [f2fs-dev] [PATCH] fs: fix warning about Using plain integer as NULL pointer

2019-03-27 Thread Mukesh Ojha
pointer CHECK fs/ubifs/xattr.c fs/ubifs/xattr.c:615:58: warning: Using plain integer as NULL pointer Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh Ojha -Mukesh --- fs/f2fs/data.c | 2 +- fs/notify/fdinfo.c | 2 +- fs/ubifs/xattr.c | 2 +- 3 files changed, 3 insertions