On Thu, Nov 28, 2013 at 06:24:41PM +0900, Jaegeuk Kim wrote:
> 2013-11-28 (목), 11:08 +0300, Dan Carpenter:
> > On Thu, Nov 28, 2013 at 01:04:47PM +0900, Jaegeuk Kim wrote:
> > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > > index b7ad1ec..5fa54c1 100644
> > > --- a/fs/f2fs/gc.c
> > > +++ b/fs/f2fs
2013-11-28 (목), 11:08 +0300, Dan Carpenter:
> On Thu, Nov 28, 2013 at 01:04:47PM +0900, Jaegeuk Kim wrote:
> > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > index b7ad1ec..5fa54c1 100644
> > --- a/fs/f2fs/gc.c
> > +++ b/fs/f2fs/gc.c
> > @@ -664,8 +664,6 @@ static void do_garbage_collect(struct f2fs_
On Thu, Nov 28, 2013 at 01:04:47PM +0900, Jaegeuk Kim wrote:
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index b7ad1ec..5fa54c1 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -664,8 +664,6 @@ static void do_garbage_collect(struct f2fs_sb_info
> *sbi, unsigned int segno,
>
> /* read
Thank you Dan.
I wrote two patches to address the warnings below.
Thanks.
>From 1745cd1e14eff75089a8d88fe07f07549e1f3946 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Thu, 28 Nov 2013 12:44:05 +0900
Subject: [PATCH 1/2] f2fs: bug fix on bit overflow from 32bits to 64bits
Cc: linux-fsde...@vge
On Wed, Nov 27, 2013 at 06:04:57PM +0900, Jaegeuk Kim wrote:
> Hi,
>
> 2013-11-27 (수), 11:31 +0300, Dan Carpenter:
> > On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote:
> > > Hi Dan,
> > >
> > > Thank you for the report.
> > >
> > > How about this?
> > > Thanks,
> >
> > You've just d
Hi,
2013-11-27 (수), 11:31 +0300, Dan Carpenter:
> On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote:
> > Hi Dan,
> >
> > Thank you for the report.
> >
> > How about this?
> > Thanks,
>
> You've just disguised the bug instead of fixing it. Later versions of
> this static checker will
On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote:
> Hi Dan,
>
> Thank you for the report.
>
> How about this?
> Thanks,
You've just disguised the bug instead of fixing it. Later versions of
this static checker will complain about the new code as well. We're
unlikely to support 18TB
Hi Dan,
Thank you for the report.
How about this?
Thanks,
>From e053b711dcf9424974d232829b9c589269c98b4d Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Tue, 12 Nov 2013 16:55:17 +0900
Subject: [PATCH] f2fs: introduce f2fs_issue_discard() to clean up
Cc: linux-fsde...@vger.kernel.org, linux-ke
Hello Jaegeuk Kim,
The patch 3fa7fb17dc9a: "f2fs: introduce f2fs_issue_discard() to clean
up" from Nov 12, 2013, leads to the following static checker warning:
"fs/f2fs/segment.c:274 f2fs_issue_discard()
warn: should 'blklen << sbi->log_sectors_per_block' be a 64 bit
type
