Re: [f2fs-dev] [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Chao Yu
On 2019/9/9 22:37, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 17:33, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 16:37, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 15:58, Chao Yu wrote: >>> On 2019/9/9 15:44, Jaegeuk Kim wrote:

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 17:33, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:37, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 15:58, Chao Yu wrote: > > On 2019/9/9 15:44, Jaegeuk Kim wrote: > >> On 09/07, Chao Yu wrote: > >>>

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Chao Yu
On 2019/9/9 17:33, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 16:37, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 15:58, Chao Yu wrote: > On 2019/9/9 15:44, Jaegeuk Kim wrote: >> On 09/07, Chao Yu wrote: >>> On 2019-9-7 7:48, Jaegeuk Kim wrote:

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 16:37, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 15:58, Chao Yu wrote: > >>> On 2019/9/9 15:44, Jaegeuk Kim wrote: > On 09/07, Chao Yu wrote: > > On 2019-9-7 7:48, Jaegeuk Kim wrote: > >> On 09/06, Chao Yu wrote: > >>>

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Chao Yu
On 2019/9/9 16:37, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 15:58, Chao Yu wrote: >>> On 2019/9/9 15:44, Jaegeuk Kim wrote: On 09/07, Chao Yu wrote: > On 2019-9-7 7:48, Jaegeuk Kim wrote: >> On 09/06, Chao Yu wrote: >>> If inode is newly created, inode page may

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 15:58, Chao Yu wrote: > > On 2019/9/9 15:44, Jaegeuk Kim wrote: > >> On 09/07, Chao Yu wrote: > >>> On 2019-9-7 7:48, Jaegeuk Kim wrote: > On 09/06, Chao Yu wrote: > > If inode is newly created, inode page may not synchronize with inode > >

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Chao Yu
On 2019/9/9 15:58, Chao Yu wrote: > On 2019/9/9 15:44, Jaegeuk Kim wrote: >> On 09/07, Chao Yu wrote: >>> On 2019-9-7 7:48, Jaegeuk Kim wrote: On 09/06, Chao Yu wrote: > If inode is newly created, inode page may not synchronize with inode > cache, > so fields like .i_inline or

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Chao Yu
On 2019/9/9 15:44, Jaegeuk Kim wrote: > On 09/07, Chao Yu wrote: >> On 2019-9-7 7:48, Jaegeuk Kim wrote: >>> On 09/06, Chao Yu wrote: If inode is newly created, inode page may not synchronize with inode cache, so fields like .i_inline or .i_extra_isize could be wrong, in below call

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-09 Thread Jaegeuk Kim
On 09/07, Chao Yu wrote: > On 2019-9-7 7:48, Jaegeuk Kim wrote: > > On 09/06, Chao Yu wrote: > >> If inode is newly created, inode page may not synchronize with inode cache, > >> so fields like .i_inline or .i_extra_isize could be wrong, in below call > >> path, we may access such wrong fields,

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-06 Thread Chao Yu
On 2019-9-7 7:48, Jaegeuk Kim wrote: > On 09/06, Chao Yu wrote: >> If inode is newly created, inode page may not synchronize with inode cache, >> so fields like .i_inline or .i_extra_isize could be wrong, in below call >> path, we may access such wrong fields, result in failing to migrate valid >>

Re: [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-06 Thread Jaegeuk Kim
On 09/06, Chao Yu wrote: > If inode is newly created, inode page may not synchronize with inode cache, > so fields like .i_inline or .i_extra_isize could be wrong, in below call > path, we may access such wrong fields, result in failing to migrate valid > target block. If data is valid, how can

[f2fs-dev] [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()

2019-09-06 Thread Chao Yu
If inode is newly created, inode page may not synchronize with inode cache, so fields like .i_inline or .i_extra_isize could be wrong, in below call path, we may access such wrong fields, result in failing to migrate valid target block. - gc_data_segment - is_alive - datablock_addr -