Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-15 Thread Chao Yu
Hi all, > > It looks good to me, but can we releasing grabbed block buffer > > 'sbi->raw_super_buf' > > as Chao Yu said. > > If then, don't we need to recover the polluted superblock? We need, if we change to not grab super block buffer header, instead, we have to record current super block no

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-14 Thread Jaegeuk Kim
Hi, On Mon, Dec 14, 2015 at 05:56:49PM +0800, He YunLei wrote: > On 2015/12/9 2:19, Jaegeuk Kim wrote: > >Hi Yunlei, > > > >On Tue, Dec 08, 2015 at 09:17:13PM +0800, Yunlei He wrote: > >>write_checkpoint() tries to get cp_blkaddr from superblock buffer, > >>if the buffer happen to be destroied by

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-14 Thread He YunLei
On 2015/12/9 2:19, Jaegeuk Kim wrote: > Hi Yunlei, > > On Tue, Dec 08, 2015 at 09:17:13PM +0800, Yunlei He wrote: >> write_checkpoint() tries to get cp_blkaddr from superblock buffer, >> if the buffer happen to be destroied by something else, it may >> bring in unpredictable effect on f2fs. >> >> t

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-10 Thread Chao Yu
He > >> Cc: linux-f2fs-devel@lists.sourceforge.net; chao2...@samsung.com; > >> hebi...@huawei.com; > >> stuart...@huawei.com > >> Subject: Re: [f2fs-dev] [PATCH] back-up raw_super in sbi > >> > >> Hi Yunlei, > >> > >> On Tue,

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-08 Thread He YunLei
m; >> hebi...@huawei.com; >> stuart...@huawei.com >> Subject: Re: [f2fs-dev] [PATCH] back-up raw_super in sbi >> >> Hi Yunlei, >> >> On Tue, Dec 08, 2015 at 09:17:13PM +0800, Yunlei He wrote: >>> write_checkpoint() tries to get cp_blkaddr from superbloc

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-08 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, December 09, 2015 2:19 AM > To: Yunlei He > Cc: linux-f2fs-devel@lists.sourceforge.net; chao2...@samsung.com; > hebi...@huawei.com; > stuart...@huawei.com > Subject: Re: [f

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-08 Thread Jaegeuk Kim
Hi Yunlei, On Tue, Dec 08, 2015 at 09:17:13PM +0800, Yunlei He wrote: > write_checkpoint() tries to get cp_blkaddr from superblock buffer, > if the buffer happen to be destroied by something else, it may > bring in unpredictable effect on f2fs. > > this patch fix it by back-up a raw_super copy. >

[f2fs-dev] [PATCH] back-up raw_super in sbi

2015-12-08 Thread Yunlei He
write_checkpoint() tries to get cp_blkaddr from superblock buffer, if the buffer happen to be destroied by something else, it may bring in unpredictable effect on f2fs. this patch fix it by back-up a raw_super copy. Signed-off-by: Yunlei He --- fs/f2fs/checkpoint.c | 3 ++- fs/f2fs/f2fs.h