Re: [f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-23 Thread Google
On Fri, 21 Oct 2022 10:30:46 +0530 Pavan Kondeti wrote: > Hi Mukesh, > > On Wed, Oct 19, 2022 at 09:47:57PM +0530, Mukesh Ojha wrote: > > commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") > > introduces iocb field in 'f2fs_direct_IO_enter' trace event > > And it only assigns

Re: [f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-20 Thread Pavan Kondeti
Hi Mukesh, On Wed, Oct 19, 2022 at 09:47:57PM +0530, Mukesh Ojha wrote: > commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") > introduces iocb field in 'f2fs_direct_IO_enter' trace event > And it only assigns the pointer and later it accesses its field > in trace print log. >

Re: [f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-20 Thread Chao Yu
On 2022/10/20 17:27, Mukesh Ojha wrote: Hi, On 10/20/2022 2:31 PM, Chao Yu wrote: On 2022/10/20 0:17, Mukesh Ojha wrote: commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") introduces iocb field in 'f2fs_direct_IO_enter' trace event And it only assigns the pointer and later

Re: [f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-20 Thread Mukesh Ojha
Hi, On 10/20/2022 2:31 PM, Chao Yu wrote: On 2022/10/20 0:17, Mukesh Ojha wrote: commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") introduces iocb field in 'f2fs_direct_IO_enter' trace event And it only assigns the pointer and later it accesses its field in trace print log.

Re: [f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-20 Thread Chao Yu
On 2022/10/20 0:17, Mukesh Ojha wrote: commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") introduces iocb field in 'f2fs_direct_IO_enter' trace event And it only assigns the pointer and later it accesses its field in trace print log. Fix it by correcting data type and memcpy

[f2fs-dev] [PATCH] f2fs: fix the assign logic of iocb

2022-10-19 Thread Mukesh Ojha
commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint") introduces iocb field in 'f2fs_direct_IO_enter' trace event And it only assigns the pointer and later it accesses its field in trace print log. Fix it by correcting data type and memcpy the content of iocb. Fixes: 18ae8d12991b