Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
an integer value and still I don't think this value should be covered by any kind of locks. Thanks, thanks --- Original Message --- Sender : ???jaegeuk@samsung.com S5(??)/??/?(???)/ Date : 九月 10, 2013 09:52 (GMT+09:00) Title : Re: [f2fs-dev][PATCH] f2fs: optimize fs_lock

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
when f2fs_initxattrs() is called. Let's think about ut in more detail. Thanks, thanks again! --- Original Message --- Sender : Russ Knizeruss.kn...@motorola.com Date : 九月 07, 2013 04:25 (GMT+09:00) Title : Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
Hi Gu, 2013/9/11 Gu Zheng guz.f...@cn.fujitsu.com: Hi Jaegeuk, Chao, On 09/10/2013 08:52 AM, Jaegeuk Kim wrote: Hi, At first, thank you for the report and please follow the email writing rules. :) Anyway, I agree to the below issue. One thing that I can think of is that we don't need

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Russ Knize
in more detail. Thanks, thanks again! --- Original Message --- Sender : Russ Knizeruss.kn...@motorola.com Date : 九月 07, 2013 04:25 (GMT+09:00) Title : Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance I encountered this same issue

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Jin Xu
detail. Thanks, thanks again! --- Original Message --- Sender : Russ Knizeruss.kn...@motorola.com Date : 九月 07, 2013 04:25 (GMT+09:00) Title : Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance I encountered this same issue recently and solved it in much

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread 俞超
-dev][PATCH] f2fs: optimize fs_lock for better performance Hi, 2013/9/11 Chao Yu chao2...@samsung.com Hi Kim, I did some tests as you mention of using random instead of spin_lock. The test model is as following: eight threads race to grab one of eight locks for one thousand times

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread 俞超
@lists.sourceforge.net Subject: Re: [f2fs-dev][PATCH] f2fs: optimize fs_lock for better performance Hi Jaegeuk, Chao, On 09/10/2013 08:52 AM, Jaegeuk Kim wrote: Hi, At first, thank you for the report and please follow the email writing rules. :) Anyway, I agree to the below issue. One

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-10 Thread Gu Zheng
! --- Original Message --- Sender : Russ Knizeruss.kn...@motorola.com Date : 九月 07, 2013 04:25 (GMT+09:00) Title : Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance I encountered this same issue recently and solved it in much the same way. Can we rename

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-10 Thread Gu Zheng
Hi Jaegeuk, Chao, On 09/10/2013 08:52 AM, Jaegeuk Kim wrote: Hi, At first, thank you for the report and please follow the email writing rules. :) Anyway, I agree to the below issue. One thing that I can think of is that we don't need to use the spin_lock, since we don't care about the

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-09 Thread Jaegeuk Kim
Hi, At first, thank you for the report and please follow the email writing rules. :) Anyway, I agree to the below issue. One thing that I can think of is that we don't need to use the spin_lock, since we don't care about the exact lock number, but just need to get any not-collided number. So,

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-09 Thread Russ Knize
Date : 九月 07, 2013 04:25 (GMT+09:00) Title : Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance I encountered this same issue recently and solved it in much the same way. Can we rename spin_lock to something more meaningful? This race actually exposed

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-06 Thread Russ Knize
I encountered this same issue recently and solved it in much the same way. Can we rename spin_lock to something more meaningful? This race actually exposed a potential deadlock between f2fs_create() and f2fs_initxattrs(): - vfs_create() - f2fs_create() - takes an fs_lock - f2fs_add_link()