Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jaegeuk Kim
On 10/17, Chao Yu wrote: > On 2018/10/17 10:19, Jaegeuk Kim wrote: > > On 10/17, Chao Yu wrote: > >> Hi Jaegeuk, Jens, > >> > >> On 2018/10/17 3:23, Jaegeuk Kim wrote: > >>> Thanks Jens, > >>> > >>> On top of the patch killing the dead code, I wrote another one to detect > >>> the idle time by the

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Chao Yu
On 2018/10/17 10:19, Jaegeuk Kim wrote: > On 10/17, Chao Yu wrote: >> Hi Jaegeuk, Jens, >> >> On 2018/10/17 3:23, Jaegeuk Kim wrote: >>> Thanks Jens, >>> >>> On top of the patch killing the dead code, I wrote another one to detect >>> the idle time by the internal account logic like below. IMHO,

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jaegeuk Kim
On 10/17, Chao Yu wrote: > Hi Jaegeuk, Jens, > > On 2018/10/17 3:23, Jaegeuk Kim wrote: > > Thanks Jens, > > > > On top of the patch killing the dead code, I wrote another one to detect > > the idle time by the internal account logic like below. IMHO, it'd be > > better to decouple f2fs with

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Chao Yu
Hi Jaegeuk, Jens, On 2018/10/17 3:23, Jaegeuk Kim wrote: > Thanks Jens, > > On top of the patch killing the dead code, I wrote another one to detect > the idle time by the internal account logic like below. IMHO, it'd be > better to decouple f2fs with other layers, if possible. > > Thanks, >

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Chao Yu
On 2018/10/17 0:20, Jens Axboe wrote: > On 10/16/18 10:06 AM, Chao Yu wrote: >> Hi Jens, >> >> On 2018-10-16 22:34, Jens Axboe wrote: >>> This doesn't work on stacked devices, and it doesn't work on >>> blk-mq devices. The request_list is only used on legacy, which >>> we don't have much of

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jens Axboe
On 10/16/18 1:31 PM, Jaegeuk Kim wrote: > On 10/16, Jens Axboe wrote: >> On 10/16/18 1:23 PM, Jaegeuk Kim wrote: >>> Thanks Jens, >>> >>> On top of the patch killing the dead code, I wrote another one to detect >>> the idle time by the internal account logic like below. IMHO, it'd be >>> better to

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jaegeuk Kim
On 10/16, Jens Axboe wrote: > On 10/16/18 1:23 PM, Jaegeuk Kim wrote: > > Thanks Jens, > > > > On top of the patch killing the dead code, I wrote another one to detect > > the idle time by the internal account logic like below. IMHO, it'd be > > better to decouple f2fs with other layers, if

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jens Axboe
On 10/16/18 1:23 PM, Jaegeuk Kim wrote: > Thanks Jens, > > On top of the patch killing the dead code, I wrote another one to detect > the idle time by the internal account logic like below. IMHO, it'd be > better to decouple f2fs with other layers, if possible. I agree, that's what got us into

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jaegeuk Kim
Thanks Jens, On top of the patch killing the dead code, I wrote another one to detect the idle time by the internal account logic like below. IMHO, it'd be better to decouple f2fs with other layers, if possible. Thanks, >From 85daf5190671b3d98ef779bdea77b4a046658708 Mon Sep 17 00:00:00 2001

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jens Axboe
On 10/16/18 10:06 AM, Chao Yu wrote: > Hi Jens, > > On 2018-10-16 22:34, Jens Axboe wrote: >> This doesn't work on stacked devices, and it doesn't work on >> blk-mq devices. The request_list is only used on legacy, which >> we don't have much of anymore, and soon won't have any of. >> >> Kill the

Re: [f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Chao Yu
Hi Jens, On 2018-10-16 22:34, Jens Axboe wrote: > This doesn't work on stacked devices, and it doesn't work on > blk-mq devices. The request_list is only used on legacy, which > we don't have much of anymore, and soon won't have any of. > > Kill the check. In order to avoid conflicting with

[f2fs-dev] [PATCH] f2fs: remove request_list check in is_idle()

2018-10-16 Thread Jens Axboe
This doesn't work on stacked devices, and it doesn't work on blk-mq devices. The request_list is only used on legacy, which we don't have much of anymore, and soon won't have any of. Kill the check. Cc: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net Signed-off-by: Jens Axboe ---