Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-09 Thread Chao Yu
On 2022/11/9 20:56, qixiaoyu wrote: On Tue, Nov 08, 2022 at 10:30:13PM +0800, Chao Yu wrote: On 2022/11/8 20:32, qixiaoyu wrote: On Sun, Nov 06, 2022 at 09:54:59PM +0800, Chao Yu wrote: On 2022/11/2 20:25, qixiaoyu wrote: Hi Chao, fdatasync do in-place-update to avoid additional node writes,

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-09 Thread qixiaoyu
On Tue, Nov 08, 2022 at 10:30:13PM +0800, Chao Yu wrote: > On 2022/11/8 20:32, qixiaoyu wrote: > >On Sun, Nov 06, 2022 at 09:54:59PM +0800, Chao Yu wrote: > >>On 2022/11/2 20:25, qixiaoyu wrote: > >>>Hi Chao, > >>> > >>>fdatasync do in-place-update to avoid additional node writes, but currently > >

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-08 Thread Chao Yu
On 2022/11/8 20:32, qixiaoyu wrote: On Sun, Nov 06, 2022 at 09:54:59PM +0800, Chao Yu wrote: On 2022/11/2 20:25, qixiaoyu wrote: Hi Chao, fdatasync do in-place-update to avoid additional node writes, but currently it only do that with F2FS_IPU_FSYNC as: f2fs_do_sync_file: if (datasync

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-08 Thread qixiaoyu
On Sun, Nov 06, 2022 at 09:54:59PM +0800, Chao Yu wrote: > On 2022/11/2 20:25, qixiaoyu wrote: > >Hi Chao, > > > >fdatasync do in-place-update to avoid additional node writes, but currently > >it only do that with F2FS_IPU_FSYNC as: > > > >f2fs_do_sync_file: > > if (datasync || get_dirty_pages(

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-06 Thread Chao Yu
On 2022/11/2 20:25, qixiaoyu wrote: Hi Chao, fdatasync do in-place-update to avoid additional node writes, but currently it only do that with F2FS_IPU_FSYNC as: f2fs_do_sync_file: if (datasync || get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks) set_inode_flag(inode

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-02 Thread qixiaoyu
Hi Chao, fdatasync do in-place-update to avoid additional node writes, but currently it only do that with F2FS_IPU_FSYNC as: f2fs_do_sync_file: if (datasync || get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks) set_inode_flag(inode, FI_NEED_IPU); check_inplace_update_

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-11-01 Thread Chao Yu
On 2022/10/21 10:31, qixiaoyu1 wrote: Currently IPU policy for fdatasync is coupled with F2FS_IPU_FSYNC. Fix to apply it to all IPU policy. Xiaoyu, Sorry for the delay. I didn't get the point, can you please explain more about the issue? Thanks, Signed-off-by: qixiaoyu1 --- fs/f2fs/dat

Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-10-31 Thread qixiaoyu
Friendly ping... On Fri, Oct 21, 2022 at 10:31:36AM +0800, qixiaoyu1 wrote: > Currently IPU policy for fdatasync is coupled with F2FS_IPU_FSYNC. > Fix to apply it to all IPU policy. > > Signed-off-by: qixiaoyu1 > --- > fs/f2fs/data.c | 8 +++- > fs/f2fs/file.c | 4 +++- > 2 files changed, 6

[f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC

2022-10-20 Thread qixiaoyu1
Currently IPU policy for fdatasync is coupled with F2FS_IPU_FSYNC. Fix to apply it to all IPU policy. Signed-off-by: qixiaoyu1 --- fs/f2fs/data.c | 8 +++- fs/f2fs/file.c | 4 +++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index a71e818cd6