Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Chao Yu
On 2019/8/19 10:55, Eric Biggers wrote: > On Mon, Aug 19, 2019 at 09:58:30AM +0800, Chao Yu wrote: >> On 2019/8/19 9:33, Chao Yu wrote: >>> On 2019/8/18 23:41, Eric Biggers wrote: On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: > On 2019/8/16 13:55, Eric Biggers wrote: >> From

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Eric Biggers
On Mon, Aug 19, 2019 at 09:58:30AM +0800, Chao Yu wrote: > On 2019/8/19 9:33, Chao Yu wrote: > > On 2019/8/18 23:41, Eric Biggers wrote: > >> On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: > >>> On 2019/8/16 13:55, Eric Biggers wrote: > From: Eric Biggers > > Userspace pro

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Chao Yu
On 2019/8/19 9:33, Chao Yu wrote: > On 2019/8/18 23:41, Eric Biggers wrote: >> On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: >>> On 2019/8/16 13:55, Eric Biggers wrote: From: Eric Biggers Userspace provides a null-terminated string, so don't assume that the full FSLA

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Chao Yu
On 2019/8/18 23:41, Eric Biggers wrote: > On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: >> On 2019/8/16 13:55, Eric Biggers wrote: >>> From: Eric Biggers >>> >>> Userspace provides a null-terminated string, so don't assume that the >>> full FSLABEL_MAX bytes can always be copied.> >>> F

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Eric Biggers
On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: > On 2019/8/16 13:55, Eric Biggers wrote: > > From: Eric Biggers > > > > Userspace provides a null-terminated string, so don't assume that the > > full FSLABEL_MAX bytes can always be copied.> > > Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-16 Thread Chao Yu
On 2019/8/16 13:55, Eric Biggers wrote: > From: Eric Biggers > > Userspace provides a null-terminated string, so don't assume that the > full FSLABEL_MAX bytes can always be copied.> > Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") It may only copy redundant zero bytes, and will n

[f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-15 Thread Eric Biggers
From: Eric Biggers Userspace provides a null-terminated string, so don't assume that the full FSLABEL_MAX bytes can always be copied. Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") Signed-off-by: Eric Biggers --- fs/f2fs/file.c | 22 +- 1 file changed, 5 inse