Re: [f2fs-dev] [PATCH 2/7] f2fs: do in batches truncation in truncate_hole

2015-09-17 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, September 17, 2015 2:01 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org > Subject: Re: [PATCH 2/7] f2fs: do in batches truncation in truncate_hole > > Hi

Re: [f2fs-dev] [PATCH 2/7] f2fs: do in batches truncation in truncate_hole

2015-09-16 Thread Jaegeuk Kim
Hi Chao, How about changing the original patch slightly like below? o don't have to use index variable o should not skip the entire dnode indices, when one of them is -ENOENT --- fs/f2fs/file.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/file.c

[f2fs-dev] [PATCH 2/7] f2fs: do in batches truncation in truncate_hole

2015-09-11 Thread Chao Yu
truncate_data_blocks_range can do in batches truncation which makes all changes in dnode page content, dnode page status, extent cache, block count updating together. But previously, truncate_hole() always truncates one block in dnode page at a time by invoking truncate_data_blocks_range(,1),