Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

2022-10-27 Thread Chao Yu
On 2022/10/28 11:17, Jaegeuk Kim wrote: On 10/28, Chao Yu wrote: On 2022/10/28 10:33, Yangtao Li wrote: It won't pollute global namespace since it's a static function just be used in f2fs/super.c... emm, I think it would be nice to see the f2fs_record_error_work symbol in the stack, it can b

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

2022-10-27 Thread Jaegeuk Kim
On 10/28, Chao Yu wrote: > On 2022/10/28 10:33, Yangtao Li wrote: > > > It won't pollute global namespace since it's a static function just be > > > used in f2fs/super.c... > > > > emm, I think it would be nice to see the f2fs_record_error_work symbol > > in the stack, it can be explicitly a func

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

2022-10-27 Thread Chao Yu
On 2022/10/28 10:33, Yangtao Li wrote: It won't pollute global namespace since it's a static function just be used in f2fs/super.c... emm, I think it would be nice to see the f2fs_record_error_work symbol in the stack, it can be explicitly a function of f2fs. personal opinion for reference on

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

2022-10-27 Thread Yangtao Li via Linux-f2fs-devel
> It won't pollute global namespace since it's a static function just be used > in f2fs/super.c... emm, I think it would be nice to see the f2fs_record_error_work symbol in the stack, it can be explicitly a function of f2fs. personal opinion for reference only. > Do you mind letting me merge th

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

2022-10-27 Thread Chao Yu
On 2022/10/27 20:08, Yangtao Li wrote: When a fatal error occurs in the file system and it is remounted to ro mode, the flush thread needs to be stopped. Fixes: d81ab30e85a5 ("f2fs: support errors=remount-ro|continue|panic mountoption") Do you mind letting me merge these two patches into orig

[f2fs-dev] [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro

2022-10-27 Thread Yangtao Li via Linux-f2fs-devel
When a fatal error occurs in the file system and it is remounted to ro mode, the flush thread needs to be stopped. Fixes: d81ab30e85a5 ("f2fs: support errors=remount-ro|continue|panic mountoption") Signed-off-by: Yangtao Li --- fs/f2fs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a