Re: [f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin()

2019-08-18 Thread Eric Biggers
On Tue, Aug 13, 2019 at 10:40:39AM +0800, Chao Yu wrote: > Hi Eric, > > On 2019/8/13 6:58, Eric Biggers wrote: > > Hi Chao, > > > > On Mon, Aug 12, 2019 at 08:25:33PM +0800, Chao Yu wrote: > >> Hi Eric, > >> > >> On 2019/8/12 5:35, Eric Biggers wrote: > >>> From: Eric Biggers > >>> > >>> When

Re: [f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin()

2019-08-12 Thread Chao Yu
Hi Eric, On 2019/8/13 6:58, Eric Biggers wrote: > Hi Chao, > > On Mon, Aug 12, 2019 at 08:25:33PM +0800, Chao Yu wrote: >> Hi Eric, >> >> On 2019/8/12 5:35, Eric Biggers wrote: >>> From: Eric Biggers >>> >>> When an error (e.g. ENOSPC) occurs during f2fs_write_begin() when called >>> from

Re: [f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin()

2019-08-12 Thread Eric Biggers
Hi Chao, On Mon, Aug 12, 2019 at 08:25:33PM +0800, Chao Yu wrote: > Hi Eric, > > On 2019/8/12 5:35, Eric Biggers wrote: > > From: Eric Biggers > > > > When an error (e.g. ENOSPC) occurs during f2fs_write_begin() when called > > from f2fs_write_merkle_tree_block(), skip truncating the file.

Re: [f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin()

2019-08-12 Thread Chao Yu
Hi Eric, On 2019/8/12 5:35, Eric Biggers wrote: > From: Eric Biggers > > When an error (e.g. ENOSPC) occurs during f2fs_write_begin() when called > from f2fs_write_merkle_tree_block(), skip truncating the file. i_size > is not meaningful in this case, and the truncation is handled by >

[f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin()

2019-08-11 Thread Eric Biggers
From: Eric Biggers When an error (e.g. ENOSPC) occurs during f2fs_write_begin() when called from f2fs_write_merkle_tree_block(), skip truncating the file. i_size is not meaningful in this case, and the truncation is handled by f2fs_end_enable_verity() instead. Fixes: 60d7bf0f790f ("f2fs: add